diff --git a/cameraserver/src/main/java/edu/wpi/first/cameraserver/CameraServer.java b/cameraserver/src/main/java/edu/wpi/first/cameraserver/CameraServer.java index 3ef23c3300..787b944108 100644 --- a/cameraserver/src/main/java/edu/wpi/first/cameraserver/CameraServer.java +++ b/cameraserver/src/main/java/edu/wpi/first/cameraserver/CameraServer.java @@ -1,5 +1,5 @@ /*----------------------------------------------------------------------------*/ -/* Copyright (c) 2016-2019 FIRST. All Rights Reserved. */ +/* Copyright (c) 2016-2020 FIRST. All Rights Reserved. */ /* Open Source Software - may be modified and shared by FRC teams. The code */ /* must be accompanied by the FIRST BSD license file in the root directory of */ /* the project. */ @@ -37,7 +37,6 @@ import edu.wpi.first.networktables.NetworkTableInstance; * Singleton class for creating and keeping camera servers. * Also publishes camera information to NetworkTables. */ -@SuppressWarnings("PMD.TooManyMethods") public final class CameraServer { public static final int kBasePort = 1181; diff --git a/hal/src/main/java/edu/wpi/first/hal/HAL.java b/hal/src/main/java/edu/wpi/first/hal/HAL.java index ca1e90c2d0..5e07488c69 100644 --- a/hal/src/main/java/edu/wpi/first/hal/HAL.java +++ b/hal/src/main/java/edu/wpi/first/hal/HAL.java @@ -12,7 +12,7 @@ import java.nio.ByteBuffer; /** * JNI Wrapper for HAL
. */ -@SuppressWarnings({"AbbreviationAsWordInName", "MethodName", "PMD.TooManyMethods"}) +@SuppressWarnings({"AbbreviationAsWordInName", "MethodName"}) public final class HAL extends JNIWrapper { public static native void waitForDSData(); diff --git a/styleguide/pmd-ruleset.xml b/styleguide/pmd-ruleset.xml index 50f7cc7195..57ff225f41 100644 --- a/styleguide/pmd-ruleset.xml +++ b/styleguide/pmd-ruleset.xml @@ -39,6 +39,7 @@ + diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java index 5ef3ad1e20..ba950c79ed 100644 --- a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java +++ b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java @@ -18,7 +18,6 @@ import java.util.function.BooleanSupplier; *

Commands are run synchronously from the main robot loop; no multithreading is used, unless * specified explicitly from the command implementation. */ -@SuppressWarnings("PMD.TooManyMethods") public interface Command { /** diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/CommandScheduler.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/CommandScheduler.java index 1f9866134b..60488d29ea 100644 --- a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/CommandScheduler.java +++ b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/CommandScheduler.java @@ -38,7 +38,7 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableRegistry; * {@link CommandScheduler#registerSubsystem(Subsystem...)} in order for their {@link * Subsystem#periodic()} methods to be called and for their default commands to be scheduled. */ -@SuppressWarnings({"PMD.GodClass", "PMD.TooManyMethods", "PMD.TooManyFields"}) +@SuppressWarnings({"PMD.GodClass", "PMD.TooManyFields"}) public final class CommandScheduler implements Sendable, AutoCloseable { /** * The Singleton Instance. diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/button/Button.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/button/Button.java index 0d8ae592f3..d672a382ec 100644 --- a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/button/Button.java +++ b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/button/Button.java @@ -22,7 +22,6 @@ import edu.wpi.first.wpilibj2.command.Subsystem; * operator interface as a common use case of the more generalized Trigger objects. This is a simple * wrapper around Trigger with the method names renamed to fit the Button object use. */ -@SuppressWarnings("PMD.TooManyMethods") public class Button extends Trigger { /** * Default constructor; creates a button that is never pressed (unless {@link Button#get()} is diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/button/Trigger.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/button/Trigger.java index 5167e4ae4f..e5e17639cc 100644 --- a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/button/Trigger.java +++ b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/button/Trigger.java @@ -1,5 +1,5 @@ /*----------------------------------------------------------------------------*/ -/* Copyright (c) 2008-2019 FIRST. All Rights Reserved. */ +/* Copyright (c) 2008-2020 FIRST. All Rights Reserved. */ /* Open Source Software - may be modified and shared by FRC teams. The code */ /* must be accompanied by the FIRST BSD license file in the root directory of */ /* the project. */ @@ -27,7 +27,6 @@ import static edu.wpi.first.wpilibj.util.ErrorMessages.requireNonNullParam; * reading a certain sensor input). For this, they only have to write the {@link Trigger#get()} * method to get the full functionality of the Trigger class. */ -@SuppressWarnings("PMD.TooManyMethods") public class Trigger { private final BooleanSupplier m_isActive; diff --git a/wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command/CommandRequirementsTest.java b/wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command/CommandRequirementsTest.java index 5a356e4d0f..d19331b8d2 100644 --- a/wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command/CommandRequirementsTest.java +++ b/wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command/CommandRequirementsTest.java @@ -14,7 +14,6 @@ import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; import static org.mockito.Mockito.verify; -@SuppressWarnings("PMD.TooManyMethods") class CommandRequirementsTest extends CommandTestBase { @Test void requirementInterruptTest() { diff --git a/wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/command/Command.java b/wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/command/Command.java index 76a1618b06..6233a43daa 100644 --- a/wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/command/Command.java +++ b/wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/command/Command.java @@ -40,7 +40,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableRegistry; * @see CommandGroup * @see IllegalUseOfCommandException */ -@SuppressWarnings("PMD.TooManyMethods") public abstract class Command implements Sendable, AutoCloseable { /** * The time since this command was initialized. diff --git a/wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/command/CommandGroup.java b/wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/command/CommandGroup.java index 525e681ae2..ef4f353245 100644 --- a/wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/command/CommandGroup.java +++ b/wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/command/CommandGroup.java @@ -1,5 +1,5 @@ /*----------------------------------------------------------------------------*/ -/* Copyright (c) 2008-2019 FIRST. All Rights Reserved. */ +/* Copyright (c) 2008-2020 FIRST. All Rights Reserved. */ /* Open Source Software - may be modified and shared by FRC teams. The code */ /* must be accompanied by the FIRST BSD license file in the root directory of */ /* the project. */ @@ -31,7 +31,6 @@ import static java.util.Objects.requireNonNull; * @see Subsystem * @see IllegalUseOfCommandException */ -@SuppressWarnings("PMD.TooManyMethods") public class CommandGroup extends Command { /** * The commands in this group (stored in entries). diff --git a/wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/command/Scheduler.java b/wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/command/Scheduler.java index 40ceaf1dda..c48f604a87 100644 --- a/wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/command/Scheduler.java +++ b/wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/command/Scheduler.java @@ -33,7 +33,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableRegistry; * * @see Command */ -@SuppressWarnings("PMD.TooManyMethods") public final class Scheduler implements Sendable, AutoCloseable { /** * The Singleton Instance. diff --git a/wpilibOldCommands/src/test/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardTabTest.java b/wpilibOldCommands/src/test/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardTabTest.java index 16f088f18d..8e304ebead 100644 --- a/wpilibOldCommands/src/test/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardTabTest.java +++ b/wpilibOldCommands/src/test/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardTabTest.java @@ -1,5 +1,5 @@ /*----------------------------------------------------------------------------*/ -/* Copyright (c) 2018-2019 FIRST. All Rights Reserved. */ +/* Copyright (c) 2018-2020 FIRST. All Rights Reserved. */ /* Open Source Software - may be modified and shared by FRC teams. The code */ /* must be accompanied by the FIRST BSD license file in the root directory of */ /* the project. */ @@ -25,7 +25,6 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertThrows; -@SuppressWarnings({"PMD.TooManyMethods"}) public class ShuffleboardTabTest { private NetworkTableInstance m_ntInstance; private ShuffleboardTab m_tab; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/CAN.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/CAN.java index d24fcc23a9..2dde3ab3b0 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/CAN.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/CAN.java @@ -25,7 +25,6 @@ import edu.wpi.first.hal.HAL; * read methods and the byte[] passed into the write methods need to not * be modified for the duration of their respective calls. */ -@SuppressWarnings("PMD.TooManyMethods") public class CAN implements Closeable { public static final int kTeamManufacturer = 8; public static final int kTeamDeviceType = 10; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/CameraServer.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/CameraServer.java index 178d5ee998..c8948b91ed 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/CameraServer.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/CameraServer.java @@ -1,5 +1,5 @@ /*----------------------------------------------------------------------------*/ -/* Copyright (c) 2016-2019 FIRST. All Rights Reserved. */ +/* Copyright (c) 2016-2020 FIRST. All Rights Reserved. */ /* Open Source Software - may be modified and shared by FRC teams. The code */ /* must be accompanied by the FIRST BSD license file in the root directory of */ /* the project. */ @@ -39,7 +39,6 @@ import edu.wpi.first.networktables.NetworkTableInstance; * * @deprecated Replaced with edu.wpi.first.cameraserver.CameraServer */ -@SuppressWarnings("PMD.TooManyMethods") @Deprecated public final class CameraServer { public static final int kBasePort = 1181; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java index bd8a44bab3..80693a425c 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java @@ -25,8 +25,7 @@ import edu.wpi.first.networktables.NetworkTableInstance; * Provide access to the network communication data to / from the Driver Station. */ @SuppressWarnings({"PMD.CyclomaticComplexity", "PMD.ExcessiveClassLength", - "PMD.ExcessivePublicCount", "PMD.GodClass", "PMD.TooManyFields", - "PMD.TooManyMethods"}) + "PMD.ExcessivePublicCount", "PMD.GodClass", "PMD.TooManyFields"}) public class DriverStation { /** * Number of Joystick Ports. diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/I2C.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/I2C.java index ca8374a2a3..58b96aa8a7 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/I2C.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/I2C.java @@ -1,5 +1,5 @@ /*----------------------------------------------------------------------------*/ -/* Copyright (c) 2008-2019 FIRST. All Rights Reserved. */ +/* Copyright (c) 2008-2020 FIRST. All Rights Reserved. */ /* Open Source Software - may be modified and shared by FRC teams. The code */ /* must be accompanied by the FIRST BSD license file in the root directory of */ /* the project. */ @@ -22,7 +22,7 @@ import static edu.wpi.first.wpilibj.util.ErrorMessages.requireNonNullParam; *

This class is intended to be used by sensor (and other I2C device) drivers. It probably should * not be used directly. */ -@SuppressWarnings({"PMD.GodClass", "PMD.TooManyMethods"}) +@SuppressWarnings("PMD.GodClass") public class I2C implements AutoCloseable { public enum Port { kOnboard(0), kMXP(1); diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/InterruptableSensorBase.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/InterruptableSensorBase.java index bd21d24b0e..8fb734b53b 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/InterruptableSensorBase.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/InterruptableSensorBase.java @@ -1,5 +1,5 @@ /*----------------------------------------------------------------------------*/ -/* Copyright (c) 2008-2019 FIRST. All Rights Reserved. */ +/* Copyright (c) 2008-2020 FIRST. All Rights Reserved. */ /* Open Source Software - may be modified and shared by FRC teams. The code */ /* must be accompanied by the FIRST BSD license file in the root directory of */ /* the project. */ @@ -16,7 +16,6 @@ import edu.wpi.first.hal.util.AllocationException; /** * Base for sensors to be used with interrupts. */ -@SuppressWarnings("PMD.TooManyMethods") public abstract class InterruptableSensorBase implements AutoCloseable { @SuppressWarnings("JavadocMethod") public enum WaitResult { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java index 974c529534..daa5bdba5e 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java @@ -42,7 +42,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SmartDashboard; * - teleopPeriodic() * - testPeriodic() */ -@SuppressWarnings("PMD.TooManyMethods") public abstract class IterativeRobotBase extends RobotBase { protected double m_period; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Preferences.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Preferences.java index a45b6de276..0edbbf3c85 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Preferences.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Preferences.java @@ -31,7 +31,6 @@ import static edu.wpi.first.wpilibj.util.ErrorMessages.requireNonNullParam; *

This will also interact with {@link NetworkTable} by creating a table called "Preferences" * with all the key-value pairs.

*/ -@SuppressWarnings("PMD.TooManyMethods") public final class Preferences { /** * The Preferences table name. diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/RobotDrive.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/RobotDrive.java index 104fb26c60..f79d74af4d 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/RobotDrive.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/RobotDrive.java @@ -1,5 +1,5 @@ /*----------------------------------------------------------------------------*/ -/* Copyright (c) 2008-2019 FIRST. All Rights Reserved. */ +/* Copyright (c) 2008-2020 FIRST. All Rights Reserved. */ /* Open Source Software - may be modified and shared by FRC teams. The code */ /* must be accompanied by the FIRST BSD license file in the root directory of */ /* the project. */ @@ -25,7 +25,7 @@ import static edu.wpi.first.wpilibj.util.ErrorMessages.requireNonNullParam; * or {@link edu.wpi.first.wpilibj.drive.MecanumDrive} classes instead. */ @Deprecated -@SuppressWarnings({"PMD.GodClass", "PMD.TooManyMethods"}) +@SuppressWarnings("PMD.GodClass") public class RobotDrive extends MotorSafety implements AutoCloseable { /** * The location of a motor on the robot for the purpose of driving. diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SPI.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SPI.java index 9dcdc65ceb..aa3c67998a 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SPI.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SPI.java @@ -19,7 +19,7 @@ import edu.wpi.first.hal.SPIJNI; /** * Represents a SPI bus port. */ -@SuppressWarnings({"PMD.CyclomaticComplexity", "PMD.TooManyMethods"}) +@SuppressWarnings("PMD.CyclomaticComplexity") public class SPI implements AutoCloseable { public enum Port { kOnboardCS0(0), kOnboardCS1(1), kOnboardCS2(2), kOnboardCS3(3), kMXP(4); diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SerialPort.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SerialPort.java index 86bd941da8..0f509c7f45 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SerialPort.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SerialPort.java @@ -1,5 +1,5 @@ /*----------------------------------------------------------------------------*/ -/* Copyright (c) 2008-2019 FIRST. All Rights Reserved. */ +/* Copyright (c) 2008-2020 FIRST. All Rights Reserved. */ /* Open Source Software - may be modified and shared by FRC teams. The code */ /* must be accompanied by the FIRST BSD license file in the root directory of */ /* the project. */ @@ -16,7 +16,6 @@ import edu.wpi.first.hal.SerialPortJNI; /** * Driver for the serial ports (USB, MXP, Onboard) on the roboRIO. */ -@SuppressWarnings("PMD.TooManyMethods") public class SerialPort implements AutoCloseable { private int m_portHandle; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Watchdog.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Watchdog.java index 8287f66665..aaf56711cf 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Watchdog.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Watchdog.java @@ -21,7 +21,6 @@ import edu.wpi.first.hal.NotifierJNI; * *

The watchdog is initialized disabled, so the user needs to call enable() before use. */ -@SuppressWarnings("PMD.TooManyMethods") public class Watchdog implements Closeable, Comparable { // Used for timeout print rate-limiting private static final long kMinPrintPeriod = 1000000; // microseconds diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/controller/ProfiledPIDController.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/controller/ProfiledPIDController.java index ec7c728233..3955c5be86 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/controller/ProfiledPIDController.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/controller/ProfiledPIDController.java @@ -18,7 +18,6 @@ import edu.wpi.first.wpilibj.trajectory.TrapezoidProfile; * profile. Users should call reset() when they first start running the controller * to avoid unwanted behavior. */ -@SuppressWarnings("PMD.TooManyMethods") public class ProfiledPIDController implements Sendable { private static int instances; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ContainerHelper.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ContainerHelper.java index 6a5fef9862..26649d0899 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ContainerHelper.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ContainerHelper.java @@ -27,7 +27,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableRegistry; /** * A helper class for Shuffleboard containers to handle common child operations. */ -@SuppressWarnings("PMD.TooManyMethods") final class ContainerHelper { private final ShuffleboardContainer m_container; private final Set m_usedTitles = new HashSet<>(); diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardContainer.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardContainer.java index 331b7f198b..9a8940436f 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardContainer.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardContainer.java @@ -1,5 +1,5 @@ /*----------------------------------------------------------------------------*/ -/* Copyright (c) 2018-2019 FIRST. All Rights Reserved. */ +/* Copyright (c) 2018-2020 FIRST. All Rights Reserved. */ /* Open Source Software - may be modified and shared by FRC teams. The code */ /* must be accompanied by the FIRST BSD license file in the root directory of */ /* the project. */ @@ -19,7 +19,6 @@ import edu.wpi.first.wpilibj.Sendable; /** * Common interface for objects that can contain shuffleboard components. */ -@SuppressWarnings("PMD.TooManyMethods") public interface ShuffleboardContainer extends ShuffleboardValue { /** diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardLayout.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardLayout.java index 054fefcf23..b6ed776e81 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardLayout.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardLayout.java @@ -21,7 +21,6 @@ import static edu.wpi.first.wpilibj.util.ErrorMessages.requireNonNullParam; /** * A layout in a Shuffleboard tab. Layouts can contain widgets and other layouts. */ -@SuppressWarnings("PMD.TooManyMethods") public class ShuffleboardLayout extends ShuffleboardComponent implements ShuffleboardContainer { private final ContainerHelper m_helper = new ContainerHelper(this); diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardTab.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardTab.java index b46c6d2c76..5d575df131 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardTab.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardTab.java @@ -1,5 +1,5 @@ /*----------------------------------------------------------------------------*/ -/* Copyright (c) 2018-2019 FIRST. All Rights Reserved. */ +/* Copyright (c) 2018-2020 FIRST. All Rights Reserved. */ /* Open Source Software - may be modified and shared by FRC teams. The code */ /* must be accompanied by the FIRST BSD license file in the root directory of */ /* the project. */ @@ -22,7 +22,6 @@ import edu.wpi.first.wpilibj.Sendable; * can also be added to layouts with {@link #getLayout(String, String)}; layouts can be nested * arbitrarily deep (note that too many levels may make deeper components unusable). */ -@SuppressWarnings("PMD.TooManyMethods") public final class ShuffleboardTab implements ShuffleboardContainer { private final ContainerHelper m_helper = new ContainerHelper(this); private final ShuffleboardRoot m_root; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/AnalogInputSim.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/AnalogInputSim.java index d9494f7e74..1709d6a674 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/AnalogInputSim.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/AnalogInputSim.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.AnalogInput; /** * Class to control a simulated analog input. */ -@SuppressWarnings("PMD.TooManyMethods") public class AnalogInputSim { private final int m_index; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/EncoderSim.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/EncoderSim.java index 34d4219276..9df5187e90 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/EncoderSim.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/EncoderSim.java @@ -15,7 +15,6 @@ import java.util.NoSuchElementException; /** * Class to control a simulated encoder. */ -@SuppressWarnings("PMD.TooManyMethods") public class EncoderSim { private final int m_index; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/RoboRioSim.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/RoboRioSim.java index 7742336998..f90ce0fb05 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/RoboRioSim.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/RoboRioSim.java @@ -13,7 +13,7 @@ import edu.wpi.first.hal.simulation.RoboRioDataJNI; /** * Class to control a simulated RoboRIO. */ -@SuppressWarnings({"PMD.ExcessivePublicCount", "PMD.TooManyMethods", "PMD.UseUtilityClass"}) +@SuppressWarnings({"PMD.ExcessivePublicCount", "PMD.UseUtilityClass"}) public class RoboRioSim { public static CallbackStore registerFPGAButtonCallback(NotifyCallback callback, boolean initialNotify) { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableBuilderImpl.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableBuilderImpl.java index e0d308ab9f..a82f26bb00 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableBuilderImpl.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableBuilderImpl.java @@ -21,7 +21,6 @@ import edu.wpi.first.networktables.NetworkTable; import edu.wpi.first.networktables.NetworkTableEntry; import edu.wpi.first.networktables.NetworkTableValue; -@SuppressWarnings("PMD.TooManyMethods") public class SendableBuilderImpl implements SendableBuilder { private static class Property { Property(NetworkTable table, String key) { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableRegistry.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableRegistry.java index 99b72a0006..3cafbf7eaa 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableRegistry.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableRegistry.java @@ -24,7 +24,6 @@ import edu.wpi.first.wpilibj.Sendable; * The SendableRegistry class is the public interface for registering sensors * and actuators for use on dashboards and LiveWindow. */ -@SuppressWarnings("PMD.TooManyMethods") public class SendableRegistry { private static class Component { Component() {} diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SmartDashboard.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SmartDashboard.java index 457ae46e02..1b022c18b0 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SmartDashboard.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SmartDashboard.java @@ -1,5 +1,5 @@ /*----------------------------------------------------------------------------*/ -/* Copyright (c) 2008-2019 FIRST. All Rights Reserved. */ +/* Copyright (c) 2008-2020 FIRST. All Rights Reserved. */ /* Open Source Software - may be modified and shared by FRC teams. The code */ /* must be accompanied by the FIRST BSD license file in the root directory of */ /* the project. */ @@ -26,7 +26,7 @@ import edu.wpi.first.wpilibj.Sendable; *

When a value is put into the SmartDashboard here, it pops up on the SmartDashboard on the * laptop. Users can put values into and get values from the SmartDashboard. */ -@SuppressWarnings({"PMD.GodClass", "PMD.TooManyMethods"}) +@SuppressWarnings("PMD.GodClass") public final class SmartDashboard { /** * The {@link NetworkTable} used by {@link SmartDashboard}. diff --git a/wpilibj/src/test/java/edu/wpi/first/wpilibj/TimedRobotTest.java b/wpilibj/src/test/java/edu/wpi/first/wpilibj/TimedRobotTest.java index 84b1edc0bb..6942ca0df4 100644 --- a/wpilibj/src/test/java/edu/wpi/first/wpilibj/TimedRobotTest.java +++ b/wpilibj/src/test/java/edu/wpi/first/wpilibj/TimedRobotTest.java @@ -20,7 +20,6 @@ import edu.wpi.first.wpilibj.simulation.SimHooks; import static org.junit.jupiter.api.Assertions.assertEquals; class TimedRobotTest { - @SuppressWarnings("PMD.TooManyMethods") class MockRobot extends TimedRobot { public final AtomicInteger m_robotInitCount = new AtomicInteger(0); public final AtomicInteger m_simulationInitCount = new AtomicInteger(0); diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/pacgoat/subsystems/Shooter.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/pacgoat/subsystems/Shooter.java index 5c70e71f00..6fa7e680d0 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/pacgoat/subsystems/Shooter.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/pacgoat/subsystems/Shooter.java @@ -1,5 +1,5 @@ /*----------------------------------------------------------------------------*/ -/* Copyright (c) 2017-2018 FIRST. All Rights Reserved. */ +/* Copyright (c) 2017-2020 FIRST. All Rights Reserved. */ /* Open Source Software - may be modified and shared by FRC teams. The code */ /* must be accompanied by the FIRST BSD license file in the root directory of */ /* the project. */ @@ -22,7 +22,6 @@ import edu.wpi.first.wpilibj.command.Subsystem; *

NOTE: Simulation currently approximates this as as single pneumatic * cylinder and ignores the latch. */ -@SuppressWarnings("PMD.TooManyMethods") public class Shooter extends Subsystem { // Devices DoubleSolenoid m_piston1 = new DoubleSolenoid(1, 3, 4); diff --git a/wpimath/src/generate/Nat.java.in b/wpimath/src/generate/Nat.java.in index 8c471f6f47..666bd1c32a 100644 --- a/wpimath/src/generate/Nat.java.in +++ b/wpimath/src/generate/Nat.java.in @@ -17,7 +17,7 @@ package edu.wpi.first.wpiutil.math; * * @param The {@link Num} this represents. */ -@SuppressWarnings({"MethodName", "unused", "PMD.TooManyMethods"}) +@SuppressWarnings({"MethodName", "unused"}) public interface Nat { /** * The number this interface represents. diff --git a/wpimath/src/main/java/edu/wpi/first/wpilibj/math/Discretization.java b/wpimath/src/main/java/edu/wpi/first/wpilibj/math/Discretization.java index 1c3ee1cbdc..ad9bf27b17 100644 --- a/wpimath/src/main/java/edu/wpi/first/wpilibj/math/Discretization.java +++ b/wpimath/src/main/java/edu/wpi/first/wpilibj/math/Discretization.java @@ -14,7 +14,7 @@ import edu.wpi.first.wpiutil.math.Nat; import edu.wpi.first.wpiutil.math.Num; import edu.wpi.first.wpiutil.math.Pair; -@SuppressWarnings({"PMD.TooManyMethods", "ParameterName", "MethodTypeParameterName"}) +@SuppressWarnings({"ParameterName", "MethodTypeParameterName"}) public final class Discretization { private Discretization() { // Utility class diff --git a/wpimath/src/main/java/edu/wpi/first/wpilibj/math/StateSpaceUtil.java b/wpimath/src/main/java/edu/wpi/first/wpilibj/math/StateSpaceUtil.java index 1df0f43469..02ca7c1e5f 100644 --- a/wpimath/src/main/java/edu/wpi/first/wpilibj/math/StateSpaceUtil.java +++ b/wpimath/src/main/java/edu/wpi/first/wpilibj/math/StateSpaceUtil.java @@ -21,7 +21,7 @@ import edu.wpi.first.wpiutil.math.VecBuilder; import edu.wpi.first.wpiutil.math.numbers.N1; import edu.wpi.first.wpiutil.math.numbers.N3; -@SuppressWarnings({"PMD.TooManyMethods", "ParameterName"}) +@SuppressWarnings("ParameterName") public final class StateSpaceUtil { private StateSpaceUtil() { // Utility class diff --git a/wpimath/src/main/java/edu/wpi/first/wpilibj/system/LinearSystem.java b/wpimath/src/main/java/edu/wpi/first/wpilibj/system/LinearSystem.java index 703133c237..4a90caa304 100644 --- a/wpimath/src/main/java/edu/wpi/first/wpilibj/system/LinearSystem.java +++ b/wpimath/src/main/java/edu/wpi/first/wpilibj/system/LinearSystem.java @@ -12,7 +12,7 @@ import edu.wpi.first.wpiutil.math.Matrix; import edu.wpi.first.wpiutil.math.Num; import edu.wpi.first.wpiutil.math.numbers.N1; -@SuppressWarnings({"PMD.TooManyMethods", "ClassTypeParameterName"}) +@SuppressWarnings("ClassTypeParameterName") public class LinearSystem { diff --git a/wpimath/src/main/java/edu/wpi/first/wpiutil/math/Matrix.java b/wpimath/src/main/java/edu/wpi/first/wpiutil/math/Matrix.java index 5a0c6920a7..a87b98ada8 100644 --- a/wpimath/src/main/java/edu/wpi/first/wpiutil/math/Matrix.java +++ b/wpimath/src/main/java/edu/wpi/first/wpiutil/math/Matrix.java @@ -29,7 +29,7 @@ import edu.wpi.first.wpiutil.math.numbers.N1; * @param The number of rows in this matrix. * @param The number of columns in this matrix. */ -@SuppressWarnings({"PMD.TooManyMethods", "PMD.ExcessivePublicCount"}) +@SuppressWarnings("PMD.ExcessivePublicCount") public class Matrix { protected final SimpleMatrix m_storage; diff --git a/wpimath/src/main/java/edu/wpi/first/wpiutil/math/SimpleMatrixUtils.java b/wpimath/src/main/java/edu/wpi/first/wpiutil/math/SimpleMatrixUtils.java index a6fa072298..3f281d269d 100644 --- a/wpimath/src/main/java/edu/wpi/first/wpiutil/math/SimpleMatrixUtils.java +++ b/wpimath/src/main/java/edu/wpi/first/wpiutil/math/SimpleMatrixUtils.java @@ -18,7 +18,6 @@ import org.ejml.simple.SimpleMatrix; import edu.wpi.first.math.WPIMathJNI; -@SuppressWarnings("PMD.TooManyMethods") public final class SimpleMatrixUtils { private SimpleMatrixUtils() { } diff --git a/wpimath/src/main/java/edu/wpi/first/wpiutil/math/VecBuilder.java b/wpimath/src/main/java/edu/wpi/first/wpiutil/math/VecBuilder.java index 96075267e1..98200b70be 100644 --- a/wpimath/src/main/java/edu/wpi/first/wpiutil/math/VecBuilder.java +++ b/wpimath/src/main/java/edu/wpi/first/wpiutil/math/VecBuilder.java @@ -25,7 +25,6 @@ import edu.wpi.first.wpiutil.math.numbers.N9; * * @param The dimension of the vector to be constructed. */ -@SuppressWarnings("PMD.TooManyMethods") public class VecBuilder extends MatBuilder { public VecBuilder(Nat rows) { super(rows, Nat.N1()); diff --git a/wpimath/src/test/java/edu/wpi/first/wpilibj/geometry/Translation2dTest.java b/wpimath/src/test/java/edu/wpi/first/wpilibj/geometry/Translation2dTest.java index 4be8565cb4..d6844a5333 100644 --- a/wpimath/src/test/java/edu/wpi/first/wpilibj/geometry/Translation2dTest.java +++ b/wpimath/src/test/java/edu/wpi/first/wpilibj/geometry/Translation2dTest.java @@ -13,7 +13,6 @@ import static org.junit.jupiter.api.Assertions.assertAll; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotEquals; -@SuppressWarnings("PMD.TooManyMethods") class Translation2dTest { private static final double kEpsilon = 1E-9; diff --git a/wpimath/src/test/java/edu/wpi/first/wpilibj/kinematics/MecanumDriveKinematicsTest.java b/wpimath/src/test/java/edu/wpi/first/wpilibj/kinematics/MecanumDriveKinematicsTest.java index 86a3687bd9..93c8d6a647 100644 --- a/wpimath/src/test/java/edu/wpi/first/wpilibj/kinematics/MecanumDriveKinematicsTest.java +++ b/wpimath/src/test/java/edu/wpi/first/wpilibj/kinematics/MecanumDriveKinematicsTest.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.geometry.Translation2d; import static org.junit.jupiter.api.Assertions.assertAll; import static org.junit.jupiter.api.Assertions.assertEquals; -@SuppressWarnings("PMD.TooManyMethods") class MecanumDriveKinematicsTest { private static final double kEpsilon = 1E-9; diff --git a/wpimath/src/test/java/edu/wpi/first/wpilibj/kinematics/SwerveDriveKinematicsTest.java b/wpimath/src/test/java/edu/wpi/first/wpilibj/kinematics/SwerveDriveKinematicsTest.java index 5cbec50b3b..e9fbcd1099 100644 --- a/wpimath/src/test/java/edu/wpi/first/wpilibj/kinematics/SwerveDriveKinematicsTest.java +++ b/wpimath/src/test/java/edu/wpi/first/wpilibj/kinematics/SwerveDriveKinematicsTest.java @@ -15,7 +15,6 @@ import edu.wpi.first.wpilibj.geometry.Translation2d; import static org.junit.jupiter.api.Assertions.assertAll; import static org.junit.jupiter.api.Assertions.assertEquals; -@SuppressWarnings("PMD.TooManyMethods") class SwerveDriveKinematicsTest { private static final double kEpsilon = 1E-9; diff --git a/wpimath/src/test/java/edu/wpi/first/wpilibj/math/StateSpaceUtilTest.java b/wpimath/src/test/java/edu/wpi/first/wpilibj/math/StateSpaceUtilTest.java index 252bf6e1b2..244ca53f1d 100644 --- a/wpimath/src/test/java/edu/wpi/first/wpilibj/math/StateSpaceUtilTest.java +++ b/wpimath/src/test/java/edu/wpi/first/wpilibj/math/StateSpaceUtilTest.java @@ -27,7 +27,6 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertTrue; -@SuppressWarnings("PMD.TooManyMethods") public class StateSpaceUtilTest { @Test public void testCostArray() { diff --git a/wpimath/src/test/java/edu/wpi/first/wpilibj/trajectory/TrapezoidProfileTest.java b/wpimath/src/test/java/edu/wpi/first/wpilibj/trajectory/TrapezoidProfileTest.java index 3552e41248..e155188935 100644 --- a/wpimath/src/test/java/edu/wpi/first/wpilibj/trajectory/TrapezoidProfileTest.java +++ b/wpimath/src/test/java/edu/wpi/first/wpilibj/trajectory/TrapezoidProfileTest.java @@ -13,7 +13,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotEquals; import static org.junit.jupiter.api.Assertions.assertTrue; -@SuppressWarnings({"PMD.TooManyMethods", "PMD.AvoidInstantiatingObjectsInLoops"}) +@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops") class TrapezoidProfileTest { private static final double kDt = 0.01;