Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-22 01:11:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Upgrade maven deps to latest versions and fix new linter errors (#3772)

Browse Source 
This also makes the Gradle build work with JDK 17.

The extra JVM args in gradle.properties works around a bug with spotless
and JDK 17: https://github.com/diffplug/spotless/issues/834

PMD.CloseResource was ignored because it's almost always a false
positive, and there are many of them.
This commit is contained in:
Tyler Veness
2021-12-09 12:20:08 -08:00
committed by GitHub
parent 441f2ed9b0
commit 7269a170fb
100 changed files with 306 additions and 338 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/CommandScheduler.java
View File

@@ -170,7 +170,7 @@ public final class CommandScheduler implements NTSendable, AutoCloseable {
// Do nothing if the scheduler is disabled, the robot is disabled and the command doesn't
// run when disabled, or the command is already scheduled.
if (m_disabled
|| (RobotState.isDisabled() && !command.runsWhenDisabled())
|| RobotState.isDisabled() && !command.runsWhenDisabled()
|| m_scheduledCommands.containsKey(command)) {
return;
}

2
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelDeadlineGroup.java
View File

@@ -92,7 +92,7 @@ public class ParallelDeadlineGroup extends CommandGroupBase {
if (commandRunning.getKey().isFinished()) {
commandRunning.getKey().end(false);
commandRunning.setValue(false);
if (commandRunning.getKey() == m_deadline) {
if (commandRunning.getKey().equals(m_deadline)) {
m_finished = true;
}
}