Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-26 01:51:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Upgrade maven deps to latest versions and fix new linter errors (#3772)

Browse Source 
This also makes the Gradle build work with JDK 17.

The extra JVM args in gradle.properties works around a bug with spotless
and JDK 17: https://github.com/diffplug/spotless/issues/834

PMD.CloseResource was ignored because it's almost always a false
positive, and there are many of them.
This commit is contained in:
Tyler Veness
2021-12-09 12:20:08 -08:00
committed by GitHub
parent 441f2ed9b0
commit 7269a170fb
100 changed files with 306 additions and 338 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/PIDBase.java
View File

@@ -639,8 +639,8 @@ public class PIDBase implements PIDInterface, PIDOutput, Sendable, AutoCloseable
* number of iterations to average with setToleranceBuffer() (defaults to 1). getAvgError() is
* used for the onTarget() function.
*
* @deprecated Use getError(), which is now already filtered.
* @return the current average of the error
* @deprecated Use getError(), which is now already filtered.
*/
@Deprecated
public double getAvgError() {
@@ -676,9 +676,9 @@ public class PIDBase implements PIDInterface, PIDOutput, Sendable, AutoCloseable
* object. Use it by creating the type of tolerance that you want to use: setTolerance(new
* PIDController.AbsoluteTolerance(0.1))
*
* @deprecated Use setPercentTolerance() instead.
* @param tolerance A tolerance object of the right type, e.g. PercentTolerance or
* AbsoluteTolerance
* @deprecated Use setPercentTolerance() instead.
*/
@Deprecated
public void setTolerance(Tolerance tolerance) {
@@ -721,8 +721,8 @@ public class PIDBase implements PIDInterface, PIDOutput, Sendable, AutoCloseable
* erroneous measurements when the mechanism is on target. However, the mechanism will not
* register as on target for at least the specified bufLength cycles.
*
* @deprecated Use a LinearFilter as the input.
* @param bufLength Number of previous cycles to average.
* @deprecated Use a LinearFilter as the input.
*/
@Deprecated
public void setToleranceBuffer(int bufLength) {

3
wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/command/CommandGroup.java
View File

@@ -205,7 +205,7 @@ public class CommandGroup extends Command {
}
@Override
@SuppressWarnings("MethodName")
@SuppressWarnings({"MethodName", "PMD.AvoidReassigningLoopVariables"})
void _execute() {
Entry entry = null;
Command cmd = null;
@@ -357,6 +357,7 @@ public class CommandGroup extends Command {
return true;
}
@SuppressWarnings("PMD.AvoidReassigningLoopVariables")
private void cancelConflicts(Command command) {
for (int i = 0; i < m_children.size(); i++) {
Command child = m_children.elementAt(i).m_command;