Upgrade maven deps to latest versions and fix new linter errors (#3772)

This also makes the Gradle build work with JDK 17.

The extra JVM args in gradle.properties works around a bug with spotless
and JDK 17: https://github.com/diffplug/spotless/issues/834

PMD.CloseResource was ignored because it's almost always a false
positive, and there are many of them.

wpilibOldCommands/src/test/java/edu/wpi/first/wpilibj/command/AbstractCommandTest.java

@@ -11,7 +11,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
 import org.junit.jupiter.api.BeforeEach;
 
 /** The basic test for all {@link Command} tests. */
-public abstract class AbstractCommandTest {
+public class AbstractCommandTest {
   @BeforeEach
   void commandSetup() {
     Scheduler.getInstance().removeAll();

wpilibOldCommands/src/test/java/edu/wpi/first/wpilibj/command/CommandSequentialGroupTest.java

@@ -16,7 +16,7 @@ class CommandSequentialGroupTest extends AbstractCommandTest {
    * timeout.
    */
   @Test
-  public void testThreeCommandOnSubSystem() {
+  void testThreeCommandOnSubSystem() {
     logger.fine("Beginning Test");
     final ASubsystem subsystem = new ASubsystem();
 

wpilibOldCommands/src/test/java/edu/wpi/first/wpilibj/command/CommandSupersedeTest.java

@@ -60,12 +60,8 @@ class CommandSupersedeTest extends AbstractCommandTest {
   void commandFailingSupersedingBecauseFirstCanNotBeInterruptedTest() {
     final ASubsystem subsystem = new ASubsystem();
 
-    final MockCommand command1 =
-        new MockCommand(subsystem) {
-          {
-            setInterruptible(false);
-          }
-        };
+    final MockCommand command1 = new MockCommand(subsystem);
+    command1.setInterruptible(false);
 
     final MockCommand command2 = new MockCommand(subsystem);
 

wpilibOldCommands/src/test/java/edu/wpi/first/wpilibj/command/DefaultCommandTest.java

@@ -7,7 +7,7 @@ package edu.wpi.first.wpilibj.command;
 import org.junit.jupiter.api.Test;
 
 /** Tests the {@link Command} library. */
-public class DefaultCommandTest extends AbstractCommandTest {
+class DefaultCommandTest extends AbstractCommandTest {
   /** Testing of default commands where the interrupting command ends itself. */
   @Test
   void defaultCommandWhereTheInteruptingCommandEndsItselfTest() {

wpilibOldCommands/src/test/java/edu/wpi/first/wpilibj/shuffleboard/ShuffleboardTabTest.java

@@ -20,7 +20,7 @@ import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public class ShuffleboardTabTest {
+class ShuffleboardTabTest {
   private NetworkTableInstance m_ntInstance;
   private ShuffleboardTab m_tab;
   private ShuffleboardInstance m_instance;