Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-23 01:21:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpilib] GenericHID.setRumble: Fix Java integer overflow (#6529)

Browse Source
This commit is contained in:
Ryan Blue
2024-05-04 11:36:40 -04:00
committed by GitHub
parent c76b358290
commit 7596aeda10
5 changed files with 112 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
wpilibj/src/main/java/edu/wpi/first/wpilibj/GenericHID.java
View File

@@ -95,8 +95,8 @@ public class GenericHID {
private final int m_port;
private int m_outputs;
private short m_leftRumble;
private short m_rightRumble;
private int m_leftRumble;
private int m_rightRumble;
/**
* Construct an instance of a device.
@@ -455,8 +455,7 @@ public class GenericHID {
*/
public void setRumble(RumbleType type, double value) {
value = MathUtil.clamp(value, 0, 1);
short rumbleValue = (short) (value * 65535);
int rumbleValue = (int) (value * 65535);
switch (type) {
case kLeftRumble:
this.m_leftRumble = rumbleValue;