Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-22 01:11:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpiutil] Fix bug in uleb128 (#3540)

Browse Source 
Caused by UB in left shift; identified by ubsan.
This commit is contained in:
Tyler Veness
2021-09-08 16:24:28 -07:00
committed by GitHub
parent 697e2dd330
commit 7810f665f1
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
wpiutil/src/main/native/cpp/leb128.cpp
View File

@@ -45,7 +45,7 @@ uint64_t ReadUleb128(const char* addr, uint64_t* ret) {
addr++;
count++;
result |= (byte & 0x7f) << shift;
result |= (byte & 0x7fULL) << shift;
shift += 7;
if (!(byte & 0x80)) {
@@ -69,7 +69,7 @@ bool ReadUleb128(raw_istream& is, uint64_t* ret) {
return false;
}
result |= (byte & 0x7f) << shift;
result |= (byte & 0x7fULL) << shift;
shift += 7;
if (!(byte & 0x80)) {