Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-21 01:01:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpilib] Fix precision issue in Color round-and-clamp (#6100)

Browse Source
This commit is contained in:
Tyler Veness
2023-12-26 13:38:15 -08:00
committed by GitHub
parent 7aa9ad44b8
commit 795d4be9fd
4 changed files with 36 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
wpilibc/src/test/native/cpp/util/ColorTest.cpp
View File

@@ -17,11 +17,22 @@ TEST(ColorTest, ConstructDefault) {
}
TEST(ColorTest, ConstructFromDoubles) {
constexpr frc::Color color{1.0, 0.5, 0.25};
{
constexpr frc::Color color{1.0, 0.5, 0.25};
EXPECT_NEAR(1.0, color.red, 1e-2);
EXPECT_NEAR(0.5, color.green, 1e-2);
EXPECT_NEAR(0.25, color.blue, 1e-2);
EXPECT_NEAR(1.0, color.red, 1e-2);
EXPECT_NEAR(0.5, color.green, 1e-2);
EXPECT_NEAR(0.25, color.blue, 1e-2);
}
{
constexpr frc::Color color{1.0, 0.0, 0.0};
// Check for exact match to ensure round-and-clamp is correct
EXPECT_EQ(1.0, color.red);
EXPECT_EQ(0.0, color.green);
EXPECT_EQ(0.0, color.blue);
}
}
TEST(ColorTest, ConstructFromInts) {
@@ -52,9 +63,9 @@ TEST(ColorTest, ConstructFromHexString) {
TEST(ColorTest, FromHSV) {
constexpr frc::Color color = frc::Color::FromHSV(90, 128, 64);
EXPECT_DOUBLE_EQ(0.1256103515625, color.red);
EXPECT_DOUBLE_EQ(0.2510986328125, color.green);
EXPECT_DOUBLE_EQ(0.2510986328125, color.blue);
EXPECT_DOUBLE_EQ(0.125732421875, color.red);
EXPECT_DOUBLE_EQ(0.251220703125, color.green);
EXPECT_DOUBLE_EQ(0.251220703125, color.blue);
}
TEST(ColorTest, ToHexString) {