Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ntcore] Avoid duplicate addition of publishers in server (#7052)

Browse Source 
We emitted a warning but went on to do unsafe things. This could cause a delayed crash.
This commit is contained in:
Peter Johnson
2024-09-08 10:36:00 -07:00
committed by GitHub
parent 306e190f78
commit 7c85c33666
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ntcore/src/main/native/cpp/net/ServerImpl.cpp
View File

@@ -211,14 +211,14 @@ void ServerImpl::ClientData4Base::ClientPublish(int64_t pubuid,
pubuid, std::make_unique<PublisherData>(this, topic, pubuid));
if (!isNew) {
WARN("client {} duplicate publish of pubuid {}", m_id, pubuid);
} else {
// add publisher to topic
topic->AddPublisher(this, publisherIt->getSecond().get());
// update meta data
m_server.UpdateMetaTopicPub(topic);
}
// add publisher to topic
topic->AddPublisher(this, publisherIt->getSecond().get());
// update meta data
m_server.UpdateMetaTopicPub(topic);
// respond with announce with pubuid to client
DEBUG4("client {}: announce {} pubuid {}", m_id, topic->name, pubuid);
SendAnnounce(topic, pubuid);