Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-21 01:01:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ntcore] Fix use-after-free in server (#5101)

Browse Source 
The client name deduplication didn't properly deduplicate.  Instead,
always append the client index to guarantee a unique name.
This commit is contained in:
Peter Johnson
2023-02-16 22:45:50 -08:00
committed by GitHub
parent fd18577ba0
commit 805c837a42
2 changed files with 21 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ntcore/src/test/native/cpp/net/ServerImplTest.cpp
View File

@@ -51,7 +51,7 @@ TEST_F(ServerImplTest, AddClient) {
MockSetPeriodicFunc setPeriodic;
auto [name, id] = server.AddClient("test", "connInfo", false, wire,
setPeriodic.AsStdFunction());
EXPECT_EQ(name, "test");
EXPECT_EQ(name, "test@1");
EXPECT_NE(id, -1);
}
@@ -67,9 +67,9 @@ TEST_F(ServerImplTest, AddDuplicateClient) {
setPeriodic1.AsStdFunction());
auto [name2, id2] = server.AddClient("test", "connInfo2", false, wire2,
setPeriodic2.AsStdFunction());
EXPECT_EQ(name1, "test");
EXPECT_EQ(name1, "test@1");
EXPECT_NE(id1, -1);
EXPECT_EQ(name2, "test@1");
EXPECT_EQ(name2, "test@2");
EXPECT_NE(id1, id2);
EXPECT_NE(id2, -1);
}