Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-30 02:31:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix std::unique_ptrs using incomplete types

Browse Source 
CANTalon declared a std::unique_ptr<CanTalonSRX> with CanTalonSRX as an incomplete type. This causes a compilation error in code using CANTalons. The CANTalonTest didn't catch this because it included ctre/CanTalonSRX.h as well as CANTalon.h. Normal user code doesn't do that.

I reviewed uses of std::unique_ptr elsewhere and determined that PIDCommand may suffer from the same problem. There is no test for PIDCommand to prove otherwise.

Change-Id: I54caf4941927910471ffb7170eb6737ba0e08437
This commit is contained in:
Tyler Veness
2015-07-20 19:58:13 -07:00
parent eb7d55fd59
commit 881dcd08e5
5 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
wpilibc/wpilibC++/src/Commands/PIDCommand.cpp
View File

@@ -7,7 +7,6 @@
#include "Commands/PIDCommand.h"
#include "PIDController.h"
#include "float.h"
PIDCommand::PIDCommand(const std::string &name, double p, double i, double d, double f,