Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

For property events, provide property name rather than source name.

Browse Source 
This is much more useful.
This commit is contained in:
Peter Johnson
2017-01-02 19:43:04 -08:00
parent 7ddbf20108
commit 883fd5b062
8 changed files with 26 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/SourceImpl.cpp
View File

@@ -337,13 +337,14 @@ void SourceImpl::PutError(llvm::StringRef msg, Frame::Time time) {
void SourceImpl::NotifyPropertyCreated(int propIndex, PropertyImpl& prop) {
auto& notifier = Notifier::GetInstance();
notifier.NotifySourceProperty(*this, CS_SOURCE_PROPERTY_CREATED, propIndex,
prop.propKind, prop.value, prop.valueStr);
notifier.NotifySourceProperty(*this, CS_SOURCE_PROPERTY_CREATED, prop.name,
propIndex, prop.propKind, prop.value,
prop.valueStr);
// also notify choices updated event for enum types
if (prop.propKind == CS_PROP_ENUM)
notifier.NotifySourceProperty(*this, CS_SOURCE_PROPERTY_CHOICES_UPDATED,
propIndex, prop.propKind, prop.value,
llvm::StringRef{});
prop.name, propIndex, prop.propKind,
prop.value, llvm::StringRef{});
}
void SourceImpl::UpdatePropertyValue(int property, bool setString, int value,
@@ -359,8 +360,8 @@ void SourceImpl::UpdatePropertyValue(int property, bool setString, int value,
// Only notify updates after we've notified created
if (m_properties_cached)
Notifier::GetInstance().NotifySourceProperty(
*this, CS_SOURCE_PROPERTY_VALUE_UPDATED, property, prop->propKind,
prop->value, prop->valueStr);
*this, CS_SOURCE_PROPERTY_VALUE_UPDATED, prop->name, property,
prop->propKind, prop->value, prop->valueStr);
}
void SourceImpl::ReleaseImage(std::unique_ptr<Image> image) {