From 89b97a21d8aaa5b4a837960e0e4c0900346eba5e Mon Sep 17 00:00:00 2001 From: Ryan Blue Date: Wed, 11 Jun 2025 00:55:51 -0400 Subject: [PATCH] [ntcore] Change 'null' to 'empty string' in NT StartServer docs (NFC) (#8017) --- .../main/native/include/networktables/NetworkTableInstance.h | 5 +++-- ntcore/src/main/native/include/ntcore_c.h | 5 +++-- ntcore/src/main/native/include/ntcore_cpp.h | 5 +++-- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/ntcore/src/main/native/include/networktables/NetworkTableInstance.h b/ntcore/src/main/native/include/networktables/NetworkTableInstance.h index 64772199a7..7ffe822815 100644 --- a/ntcore/src/main/native/include/networktables/NetworkTableInstance.h +++ b/ntcore/src/main/native/include/networktables/NetworkTableInstance.h @@ -603,8 +603,9 @@ class NetworkTableInstance final { * * @param persist_filename the name of the persist file to use (UTF-8 string, * null terminated) - * @param listen_address the address to listen on, or null to listen on any - * address (UTF-8 string, null terminated) + * @param listen_address the address to listen on, or an empty string to + * listen on any address. (UTF-8 string, null + * terminated) * @param port port to communicate over */ void StartServer(std::string_view persist_filename = "networktables.json", diff --git a/ntcore/src/main/native/include/ntcore_c.h b/ntcore/src/main/native/include/ntcore_c.h index ab384757e6..40729f0ecc 100644 --- a/ntcore/src/main/native/include/ntcore_c.h +++ b/ntcore/src/main/native/include/ntcore_c.h @@ -1113,8 +1113,9 @@ void NT_StopLocal(NT_Inst inst); * @param inst instance handle * @param persist_filename the name of the persist file to use (UTF-8 string, * null terminated) - * @param listen_address the address to listen on, or null to listen on any - * address. (UTF-8 string, null terminated) + * @param listen_address the address to listen on, or an empty string to + * listen on any address. (UTF-8 string, null + * terminated) * @param port port to communicate over */ void NT_StartServer(NT_Inst inst, const struct WPI_String* persist_filename, diff --git a/ntcore/src/main/native/include/ntcore_cpp.h b/ntcore/src/main/native/include/ntcore_cpp.h index f46ef2e335..6f73dff91f 100644 --- a/ntcore/src/main/native/include/ntcore_cpp.h +++ b/ntcore/src/main/native/include/ntcore_cpp.h @@ -1055,8 +1055,9 @@ void StopLocal(NT_Inst inst); * @param inst instance handle * @param persist_filename the name of the persist file to use (UTF-8 string, * null terminated) - * @param listen_address the address to listen on, or null to listen on any - * address. (UTF-8 string) + * @param listen_address the address to listen on, or an empty string to + * listen on any address. (UTF-8 string, null + * terminated) * @param port port to communicate over */ void StartServer(NT_Inst inst, std::string_view persist_filename,