Include thirdparty libraries with angle brackets (#5578)

wpilibcIntegrationTests/src/main/native/cpp/AnalogLoopTest.cpp

@@ -2,6 +2,7 @@
 // Open Source Software; you can modify and/or share it under the terms of
 // the WPILib BSD license file in the root directory of this project.
 
+#include <gtest/gtest.h>
 #include <units/time.h>
 
 #include "TestBench.h"
@@ -11,7 +12,6 @@
 #include "frc/AsynchronousInterrupt.h"
 #include "frc/Counter.h"
 #include "frc/Timer.h"
-#include "gtest/gtest.h"
 
 static constexpr auto kDelayTime = 10_ms;
 

wpilibcIntegrationTests/src/main/native/cpp/AnalogPotentiometerTest.cpp

@@ -4,11 +4,12 @@
 
 #include "frc/AnalogPotentiometer.h"  // NOLINT(build/include_order)
 
+#include <gtest/gtest.h>
+
 #include "TestBench.h"
 #include "frc/AnalogOutput.h"
 #include "frc/RobotController.h"
 #include "frc/Timer.h"
-#include "gtest/gtest.h"
 
 static constexpr double kScale = 270.0;
 static constexpr double kAngle = 180.0;

wpilibcIntegrationTests/src/main/native/cpp/BuiltInAccelerometerTest.cpp

@@ -4,8 +4,9 @@
 
 #include "frc/BuiltInAccelerometer.h"  // NOLINT(build/include_order)
 
+#include <gtest/gtest.h>
+
 #include "frc/Timer.h"
-#include "gtest/gtest.h"
 
 static constexpr double kAccelerationTolerance = 0.1;
 

wpilibcIntegrationTests/src/main/native/cpp/CounterTest.cpp

@@ -4,6 +4,7 @@
 
 #include "frc/Counter.h"  // NOLINT(build/include_order)
 
+#include <gtest/gtest.h>
 #include <units/time.h>
 
 #include "TestBench.h"
@@ -11,7 +12,6 @@
 #include "frc/motorcontrol/Jaguar.h"
 #include "frc/motorcontrol/Talon.h"
 #include "frc/motorcontrol/Victor.h"
-#include "gtest/gtest.h"
 
 static constexpr auto kMotorDelay = 2.5_s;
 

wpilibcIntegrationTests/src/main/native/cpp/DIOLoopTest.cpp

@@ -6,6 +6,7 @@
 
 #include "frc/DigitalOutput.h"  // NOLINT(build/include_order)
 
+#include <gtest/gtest.h>
 #include <units/math.h>
 #include <units/time.h>
 
@@ -14,7 +15,6 @@
 #include "frc/Counter.h"
 #include "frc/SynchronousInterrupt.h"
 #include "frc/Timer.h"
-#include "gtest/gtest.h"
 
 #define EXPECT_NEAR_UNITS(val1, val2, eps) \
   EXPECT_LE(units::math::abs(val1 - val2), eps)

wpilibcIntegrationTests/src/main/native/cpp/DMATest.cpp

@@ -8,10 +8,11 @@
 #include <frc/Timer.h>
 #include <frc/motorcontrol/Jaguar.h>
 
+#include <gtest/gtest.h>
+
 #include "TestBench.h"
 #include "frc/DMA.h"
 #include "frc/DMASample.h"
-#include "gtest/gtest.h"
 
 using namespace frc;
 

wpilibcIntegrationTests/src/main/native/cpp/DigitalGlitchFilterTest.cpp

@@ -4,10 +4,11 @@
 
 #include "frc/DigitalGlitchFilter.h"  // NOLINT(build/include_order)
 
+#include <gtest/gtest.h>
+
 #include "frc/Counter.h"
 #include "frc/DigitalInput.h"
 #include "frc/Encoder.h"
-#include "gtest/gtest.h"
 
 /**
  * Tests that configuring inputs to be filtered succeeds.

wpilibcIntegrationTests/src/main/native/cpp/DriverStationTest.cpp

@@ -4,13 +4,13 @@
 
 #include "frc/DriverStation.h"  // NOLINT(build/include_order)
 
+#include <gtest/gtest.h>
 #include <hal/DriverStation.h>
 #include <units/math.h>
 #include <units/time.h>
 
 #include "TestBench.h"
 #include "frc/RobotController.h"
-#include "gtest/gtest.h"
 
 #define EXPECT_NEAR_UNITS(val1, val2, eps) \
   EXPECT_LE(units::math::abs(val1 - val2), eps)

wpilibcIntegrationTests/src/main/native/cpp/FakeEncoderTest.cpp

@@ -4,6 +4,7 @@
 
 #include "frc/Encoder.h"  // NOLINT(build/include_order)
 
+#include <gtest/gtest.h>
 #include <units/time.h>
 
 #include "TestBench.h"
@@ -11,7 +12,6 @@
 #include "frc/AnalogTrigger.h"
 #include "frc/DigitalOutput.h"
 #include "frc/Timer.h"
-#include "gtest/gtest.h"
 
 static constexpr auto kDelayTime = 1_ms;
 

wpilibcIntegrationTests/src/main/native/cpp/Main.cpp

@@ -2,7 +2,7 @@
 // Open Source Software; you can modify and/or share it under the terms of
 // the WPILib BSD license file in the root directory of this project.
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
 
 int main(int argc, char** argv) {
   testing::InitGoogleTest(&argc, argv);

wpilibcIntegrationTests/src/main/native/cpp/MotorEncoderTest.cpp

@@ -4,6 +4,7 @@
 
 #include <algorithm>
 
+#include <gtest/gtest.h>
 #include <units/time.h>
 
 #include "TestBench.h"
@@ -15,7 +16,6 @@
 #include "frc/motorcontrol/Jaguar.h"
 #include "frc/motorcontrol/Talon.h"
 #include "frc/motorcontrol/Victor.h"
-#include "gtest/gtest.h"
 
 enum MotorEncoderTestType { TEST_VICTOR, TEST_JAGUAR, TEST_TALON };
 

wpilibcIntegrationTests/src/main/native/cpp/MotorInvertingTest.cpp

@@ -2,6 +2,7 @@
 // Open Source Software; you can modify and/or share it under the terms of
 // the WPILib BSD license file in the root directory of this project.
 
+#include <gtest/gtest.h>
 #include <units/time.h>
 
 #include "TestBench.h"
@@ -10,7 +11,6 @@
 #include "frc/motorcontrol/Jaguar.h"
 #include "frc/motorcontrol/Talon.h"
 #include "frc/motorcontrol/Victor.h"
-#include "gtest/gtest.h"
 
 enum MotorInvertingTestType { TEST_VICTOR, TEST_JAGUAR, TEST_TALON };
 

wpilibcIntegrationTests/src/main/native/cpp/NotifierTest.cpp

@@ -5,9 +5,9 @@
 #include "frc/Notifier.h"  // NOLINT(build/include_order)
 
 #include <fmt/core.h>
+#include <gtest/gtest.h>
 
 #include "frc/Timer.h"
-#include "gtest/gtest.h"
 
 TEST(NotifierTest, StartPeriodicAndStop) {
   uint32_t counter = 0;

wpilibcIntegrationTests/src/main/native/cpp/PCMTest.cpp

@@ -2,6 +2,8 @@
 // Open Source Software; you can modify and/or share it under the terms of
 // the WPILib BSD license file in the root directory of this project.
 
+#include <gtest/gtest.h>
+
 #include "TestBench.h"
 #include "frc/AnalogInput.h"
 #include "frc/DigitalInput.h"
@@ -10,7 +12,6 @@
 #include "frc/PneumaticsControlModule.h"
 #include "frc/Solenoid.h"
 #include "frc/Timer.h"
-#include "gtest/gtest.h"
 
 /* The PCM switches the compressor up to a couple seconds after the pressure
         switch changes. */

wpilibcIntegrationTests/src/main/native/cpp/PowerDistributionPanelTest.cpp

@@ -4,13 +4,13 @@
 
 #include "frc/PowerDistribution.h"  // NOLINT(build/include_order)
 
+#include <gtest/gtest.h>
 #include <hal/Ports.h>
 #include <units/time.h>
 
 #include "TestBench.h"
 #include "frc/Timer.h"
 #include "frc/motorcontrol/Talon.h"
-#include "gtest/gtest.h"
 
 static constexpr auto kMotorTime = 0.25_s;
 

wpilibcIntegrationTests/src/main/native/cpp/PreferencesTest.cpp

@@ -7,13 +7,13 @@
 #include <cstdio>
 #include <fstream>
 
+#include <gtest/gtest.h>
 #include <networktables/MultiSubscriber.h>
 #include <networktables/NetworkTableInstance.h>
 #include <ntcore.h>
 #include <units/time.h>
 
 #include "frc/Timer.h"
-#include "gtest/gtest.h"
 
 static const char* kFileName = "networktables.json";
 static constexpr auto kSaveTime = 1.2_s;

wpilibcIntegrationTests/src/main/native/cpp/PriorityTest.cpp

@@ -4,11 +4,11 @@
 
 #include <thread>
 
+#include <gtest/gtest.h>
 #include <wpi/condition_variable.h>
 #include <wpi/mutex.h>
 
 #include "frc/Threads.h"
-#include "gtest/gtest.h"
 
 TEST(PriorityTest, SetThreadPriority) {
   bool exited = false;

wpilibcIntegrationTests/src/main/native/cpp/RelayTest.cpp

@@ -4,12 +4,12 @@
 
 #include "frc/Relay.h"  // NOLINT(build/include_order)
 
+#include <gtest/gtest.h>
 #include <units/time.h>
 
 #include "TestBench.h"
 #include "frc/DigitalInput.h"
 #include "frc/Timer.h"
-#include "gtest/gtest.h"
 
 static constexpr auto kDelayTime = 10_ms;
 

wpilibcIntegrationTests/src/main/native/cpp/TestEnvironment.cpp

@@ -6,11 +6,11 @@
 #include <thread>
 
 #include <fmt/core.h>
+#include <gtest/gtest.h>
 #include <hal/HAL.h>
 
 #include "frc/DriverStation.h"
 #include "frc/livewindow/LiveWindow.h"
-#include "gtest/gtest.h"
 #include "mockds/MockDS.h"
 
 using namespace std::chrono_literals;

wpilibcIntegrationTests/src/main/native/cpp/TiltPanCameraTest.cpp

@@ -4,6 +4,7 @@
 
 #include <cmath>
 
+#include <gtest/gtest.h>
 #include <units/time.h>
 
 #include "TestBench.h"
@@ -11,7 +12,6 @@
 #include "frc/AnalogGyro.h"
 #include "frc/Servo.h"
 #include "frc/Timer.h"
-#include "gtest/gtest.h"
 
 static constexpr double kTiltSetpoint0 = 0.22;
 static constexpr double kTiltSetpoint45 = 0.45;

wpilibcIntegrationTests/src/main/native/cpp/TimerTest.cpp

@@ -4,10 +4,9 @@
 
 #include "frc/Timer.h"  // NOLINT(build/include_order)
 
+#include <gtest/gtest.h>
 #include <units/math.h>
 
-#include "gtest/gtest.h"
-
 #define EXPECT_NEAR_UNITS(val1, val2, eps) \
   EXPECT_LE(units::math::abs(val1 - val2), eps)