Include thirdparty libraries with angle brackets (#5578)

wpiutil/src/test/native/cpp/ArrayTest.cpp

@@ -2,7 +2,8 @@
 // Open Source Software; you can modify and/or share it under the terms of
 // the WPILib BSD license file in the root directory of this project.
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
+
 #include "wpi/array.h"
 
 namespace {

wpiutil/src/test/native/cpp/Base64Test.cpp

@@ -2,7 +2,8 @@
 // Open Source Software; you can modify and/or share it under the terms of
 // the WPILib BSD license file in the root directory of this project.
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
+
 #include "wpi/Base64.h"
 #include "wpi/SmallString.h"
 

wpiutil/src/test/native/cpp/CircularBufferTest.cpp

@@ -6,7 +6,7 @@
 
 #include <array>
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
 
 static const std::array<double, 10> values = {
     {751.848, 766.366, 342.657, 234.252, 716.126, 132.344, 445.697, 22.727,

wpiutil/src/test/native/cpp/ScopeExitTest.cpp

@@ -2,7 +2,8 @@
 // Open Source Software; you can modify and/or share it under the terms of
 // the WPILib BSD license file in the root directory of this project.
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
+
 #include "wpi/scope"
 
 TEST(ScopeExitTest, ScopeExit) {

wpiutil/src/test/native/cpp/StaticCircularBufferTest.cpp

@@ -6,7 +6,7 @@
 
 #include <array>
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
 
 static const std::array<double, 10> values = {
     {751.848, 766.366, 342.657, 234.252, 716.126, 132.344, 445.697, 22.727,

wpiutil/src/test/native/cpp/SynchronizationTest.cpp

@@ -6,7 +6,7 @@
 
 #include <thread>
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
 
 TEST(EventTest, AutoReset) {
   auto event = wpi::CreateEvent(false, false);

wpiutil/src/test/native/cpp/UidVectorTest.cpp

@@ -4,7 +4,7 @@
 
 #include "wpi/UidVector.h"  // NOLINT(build/include_order)
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
 
 namespace wpi {
 

wpiutil/src/test/native/cpp/UnescapeCStringTest.cpp

@@ -2,7 +2,8 @@
 // Open Source Software; you can modify and/or share it under the terms of
 // the WPILib BSD license file in the root directory of this project.
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
+
 #include "wpi/SmallString.h"
 #include "wpi/StringExtras.h"
 

wpiutil/src/test/native/cpp/ct_string_test.cpp

@@ -7,7 +7,7 @@
 #include <string>
 #include <string_view>
 
-#include "gtest/gtest.h"  // NOLINT(build/include_order)
+#include <gtest/gtest.h>
 
 TEST(CtStringTest, Concat) {
   using namespace wpi::literals;

wpiutil/src/test/native/cpp/future_test.cpp

@@ -4,10 +4,10 @@
 
 #include "wpi/future.h"  // NOLINT(build/include_order)
 
-#include "gtest/gtest.h"  // NOLINT(build/include_order)
-
 #include <thread>
 
+#include <gtest/gtest.h>
+
 namespace wpi {
 
 TEST(FutureTest, Then) {

wpiutil/src/test/native/cpp/json/unit-algorithms.cpp

@@ -32,13 +32,14 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
-using wpi::json;
 
 #include <algorithm>
 
+#include <gtest/gtest.h>
+
+using wpi::json;
+
 class JsonAlgorithmsTest : public ::testing::Test {
  protected:
     json j_array = {13, 29, 3, {{"one", 1}, {"two", 2}}, true, false, {1, 2, 3}, "foo", "baz"};

wpiutil/src/test/native/cpp/json/unit-capacity.cpp

@@ -32,9 +32,10 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
+
+#include <gtest/gtest.h>
+
 using wpi::json;
 
 TEST(JsonEmptyTest, Boolean)

wpiutil/src/test/native/cpp/json/unit-cbor.cpp

@@ -32,16 +32,15 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
 
 #include <cmath>
+#include <fstream>
+
+#include <gtest/gtest.h>
 
 using wpi::json;
 
-#include <fstream>
-
 TEST(CborDiscardedTest, Case)
 {
     // discarded values are not serialized

wpiutil/src/test/native/cpp/json/unit-comparison.cpp

@@ -32,9 +32,10 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
+
+#include <gtest/gtest.h>
+
 using wpi::json;
 
 class JsonComparisonTypesTest : public ::testing::Test {

wpiutil/src/test/native/cpp/json/unit-concepts.cpp

@@ -32,9 +32,10 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
+
+#include <gtest/gtest.h>
+
 using wpi::json;
 
 TEST(JsonConceptsTest, ContainerRequirements)

wpiutil/src/test/native/cpp/json/unit-constructor1.cpp

@@ -32,7 +32,7 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
+#include "unit-json.h"
 
 #include <array>
 #include <cmath>
@@ -44,7 +44,8 @@ SOFTWARE.
 #include <unordered_map>
 #include <unordered_set>
 
-#include "unit-json.h"
+#include <gtest/gtest.h>
+
 using wpi::json;
 using wpi::JsonTest;
 

wpiutil/src/test/native/cpp/json/unit-constructor2.cpp

@@ -32,9 +32,10 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
+
+#include <gtest/gtest.h>
+
 using wpi::json;
 
 TEST(JsonCopyConstructorTest, Object)

wpiutil/src/test/native/cpp/json/unit-conversions.cpp

@@ -32,11 +32,7 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
-using wpi::json;
-using wpi::JsonTest;
 
 #include <cmath>
 #include <deque>
@@ -46,6 +42,11 @@ using wpi::JsonTest;
 #include <unordered_map>
 #include <unordered_set>
 
+#include <gtest/gtest.h>
+
+using wpi::json;
+using wpi::JsonTest;
+
 template <typename T>
 class JsonGetObjectTest : public ::testing::Test {
  public:

wpiutil/src/test/native/cpp/json/unit-deserialization.cpp

@@ -32,14 +32,16 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
-#include "wpi/raw_istream.h"
-using wpi::json;
 
 #include <valarray>
 
+#include <gtest/gtest.h>
+
+#include "wpi/raw_istream.h"
+
+using wpi::json;
+
 TEST(JsonDeserializationTest, SuccessfulStream)
 {
     std::string s = "[\"foo\",1,2,3,false,{\"one\":1}]";

wpiutil/src/test/native/cpp/json/unit-element_access1.cpp

@@ -32,9 +32,10 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
+
+#include <gtest/gtest.h>
+
 using wpi::json;
 
 class JsonElementArrayAccessTestBase {

wpiutil/src/test/native/cpp/json/unit-element_access2.cpp

@@ -32,12 +32,12 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
 
 #include <cmath>
 
+#include <gtest/gtest.h>
+
 using wpi::json;
 
 class JsonElementObjectAccessTestBase {

wpiutil/src/test/native/cpp/json/unit-inspection.cpp

@@ -32,9 +32,10 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
+
+#include <gtest/gtest.h>
+
 using wpi::json;
 
 TEST(JsonConvTypeCheckTest, Object)

wpiutil/src/test/native/cpp/json/unit-iterators1.cpp

@@ -32,9 +32,10 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
+
+#include <gtest/gtest.h>
+
 using wpi::json;
 using wpi::JsonTest;
 

wpiutil/src/test/native/cpp/json/unit-iterators2.cpp

@@ -32,9 +32,10 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
+
+#include <gtest/gtest.h>
+
 using wpi::json;
 
 TEST(JsonIteratorTest, Comparisons)

wpiutil/src/test/native/cpp/json/unit-json_pointer.cpp

@@ -32,9 +32,10 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
+
+#include <gtest/gtest.h>
+
 using wpi::json;
 using wpi::JsonTest;
 

wpiutil/src/test/native/cpp/json/unit-meta.cpp

@@ -32,9 +32,10 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
+
+#include <gtest/gtest.h>
+
 using wpi::json;
 
 TEST(JsonVersionTest, Meta)

wpiutil/src/test/native/cpp/json/unit-modifiers.cpp

@@ -32,9 +32,10 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
+
+#include <gtest/gtest.h>
+
 using wpi::json;
 
 TEST(JsonClearTest, Boolean)

wpiutil/src/test/native/cpp/json/unit-msgpack.cpp

@@ -32,14 +32,15 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
-using wpi::json;
 
 #include <cmath>
 #include <fstream>
 
+#include <gtest/gtest.h>
+
+using wpi::json;
+
 TEST(MessagePackDiscardedTest, Case)
 {
     // discarded values are not serialized

wpiutil/src/test/native/cpp/json/unit-pointer_access.cpp

@@ -32,12 +32,12 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
 
 #include <cmath>
 
+#include <gtest/gtest.h>
+
 using wpi::json;
 
 TEST(JsonPointerTest, TypesCreate)

wpiutil/src/test/native/cpp/json/unit-readme.cpp

@@ -32,10 +32,7 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
-using wpi::json;
 
 #include <array>
 #include <deque>
@@ -45,8 +42,12 @@ using wpi::json;
 #include <unordered_map>
 #include <unordered_set>
 
+#include <gtest/gtest.h>
+
 #include "wpi/raw_ostream.h"
 
+using wpi::json;
+
 TEST(JsonReadmeTest, Basic)
 {
     // create an empty structure (null)

wpiutil/src/test/native/cpp/json/unit-reference_access.cpp

@@ -32,9 +32,10 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
+
+#include <gtest/gtest.h>
+
 using wpi::json;
 
 // reference access to object_t

wpiutil/src/test/native/cpp/json/unit-unicode.cpp

@@ -32,16 +32,17 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE  OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 */
 
-#include "gtest/gtest.h"
-
 #include "unit-json.h"
-using wpi::json;
 
-#include "fmt/format.h"
+#include <fstream>
+
+#include <fmt/format.h>
+#include <gtest/gtest.h>
+
 #include "wpi/StringExtras.h"
 #include "wpi/raw_ostream.h"
 
-#include <fstream>
+using wpi::json;
 
 // create and check a JSON string with up to four UTF-8 bytes
 ::testing::AssertionResult check_utf8string(bool success_expected, int byte1, int byte2 = -1, int byte3 = -1, int byte4 = -1)

wpiutil/src/test/native/cpp/leb128Test.cpp

@@ -16,7 +16,8 @@
 #include <string>
 #include <string_view>
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
+
 #include "wpi/SmallString.h"
 #include "wpi/leb128.h"
 #include "wpi/raw_istream.h"

wpiutil/src/test/native/cpp/main.cpp

@@ -2,7 +2,7 @@
 // Open Source Software; you can modify and/or share it under the terms of
 // the WPILib BSD license file in the root directory of this project.
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
 
 int main(int argc, char** argv) {
   ::testing::InitGoogleTest(&argc, argv);

wpiutil/src/test/native/cpp/priority_mutex_test.cpp

@@ -8,7 +8,7 @@
 #include <condition_variable>
 #include <thread>
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
 
 namespace wpi {
 

wpiutil/src/test/native/cpp/sha1Test.cpp

@@ -21,7 +21,8 @@
 
 #include <string>
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
+
 #include "wpi/sha1.h"
 
 namespace wpi {

wpiutil/src/test/native/cpp/sigslot/function-traits.cpp

@@ -33,10 +33,10 @@ SOFTWARE.
 
 #include "wpi/Signal.h"  // NOLINT(build/include_order)
 
-#include "gtest/gtest.h"  // NOLINT(build/include_order)
-
 #include <type_traits>
 
+#include <gtest/gtest.h>
+
 using namespace wpi::sig::trait;
 
 namespace {

wpiutil/src/test/native/cpp/sigslot/recursive.cpp

@@ -33,7 +33,7 @@ SOFTWARE.
 
 #include "wpi/Signal.h"  // NOLINT(build/include_order)
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
 
 namespace {
 

wpiutil/src/test/native/cpp/sigslot/signal-extended.cpp

@@ -33,7 +33,7 @@ SOFTWARE.
 
 #include "wpi/Signal.h"  // NOLINT(build/include_order)
 
-#include "gtest/gtest.h"
+#include <gtest/gtest.h>
 
 using namespace wpi::sig;
 

wpiutil/src/test/native/cpp/sigslot/signal-threaded.cpp

@@ -33,12 +33,12 @@ SOFTWARE.
 
 #include "wpi/Signal.h"  // NOLINT(build/include_order)
 
-#include "gtest/gtest.h"  // NOLINT(build/include_order)
-
 #include <array>
 #include <atomic>
 #include <thread>
 
+#include <gtest/gtest.h>
+
 using namespace wpi::sig;
 
 namespace {

wpiutil/src/test/native/cpp/sigslot/signal-tracking.cpp

@@ -33,12 +33,12 @@ SOFTWARE.
 
 #include "wpi/Signal.h"  // NOLINT(build/include_order)
 
-#include "gtest/gtest.h"  // NOLINT(build/include_order)
-
 #include <cmath>
 #include <sstream>
 #include <string>
 
+#include <gtest/gtest.h>
+
 using namespace wpi::sig;
 
 namespace {

wpiutil/src/test/native/cpp/sigslot/signal.cpp

@@ -33,12 +33,12 @@ SOFTWARE.
 
 #include "wpi/Signal.h"  // NOLINT(build/include_order)
 
-#include "gtest/gtest.h"  // NOLINT(build/include_order)
-
 #include <cmath>
 #include <sstream>
 #include <string>
 
+#include <gtest/gtest.h>
+
 using namespace wpi::sig;
 
 namespace {

wpiutil/src/test/native/cpp/spinlock_bench.cpp

@@ -8,8 +8,9 @@
 #include <mutex>
 #include <thread>
 
-#include "fmt/core.h"
-#include "gtest/gtest.h"
+#include <fmt/core.h>
+#include <gtest/gtest.h>
+
 #include "wpi/mutex.h"
 
 static std::mutex std_mutex;