From 8fa6976cb2e1ddf91f121a0cfd86ade3ff7697d5 Mon Sep 17 00:00:00 2001 From: Peter Johnson Date: Tue, 17 Mar 2026 16:37:56 -0700 Subject: [PATCH] [wpilib] Rename EdgeConfiguration constants to all caps --- wpilibc/src/main/native/cpp/counter/Tachometer.cpp | 4 ++-- wpilibc/src/main/native/cpp/counter/UpDownCounter.cpp | 4 ++-- .../src/main/native/include/wpi/counter/EdgeConfiguration.hpp | 4 ++-- .../src/main/java/org/wpilib/counter/EdgeConfiguration.java | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/wpilibc/src/main/native/cpp/counter/Tachometer.cpp b/wpilibc/src/main/native/cpp/counter/Tachometer.cpp index d7e6c09dba..2e735f7ebf 100644 --- a/wpilibc/src/main/native/cpp/counter/Tachometer.cpp +++ b/wpilibc/src/main/native/cpp/counter/Tachometer.cpp @@ -19,7 +19,7 @@ Tachometer::Tachometer(int channel, EdgeConfiguration configuration) int32_t status = 0; std::string stackTrace = wpi::util::GetStackTrace(1); m_handle = HAL_InitializeCounter( - channel, configuration == EdgeConfiguration::kRisingEdge, + channel, configuration == EdgeConfiguration::RISING_EDGE, stackTrace.c_str(), &status); WPILIB_CheckErrorStatus(status, "{}", channel); @@ -29,7 +29,7 @@ Tachometer::Tachometer(int channel, EdgeConfiguration configuration) void Tachometer::SetEdgeConfiguration(EdgeConfiguration configuration) { int32_t status = 0; - bool rising = configuration == EdgeConfiguration::kRisingEdge; + bool rising = configuration == EdgeConfiguration::RISING_EDGE; HAL_SetCounterEdgeConfiguration(m_handle, rising, &status); WPILIB_CheckErrorStatus(status, "{}", m_channel); } diff --git a/wpilibc/src/main/native/cpp/counter/UpDownCounter.cpp b/wpilibc/src/main/native/cpp/counter/UpDownCounter.cpp index a733095738..13f94559d7 100644 --- a/wpilibc/src/main/native/cpp/counter/UpDownCounter.cpp +++ b/wpilibc/src/main/native/cpp/counter/UpDownCounter.cpp @@ -19,7 +19,7 @@ UpDownCounter::UpDownCounter(int channel, EdgeConfiguration configuration) int32_t status = 0; std::string stackTrace = wpi::util::GetStackTrace(1); m_handle = HAL_InitializeCounter( - channel, configuration == EdgeConfiguration::kRisingEdge, + channel, configuration == EdgeConfiguration::RISING_EDGE, stackTrace.c_str(), &status); WPILIB_CheckErrorStatus(status, "{}", channel); @@ -44,7 +44,7 @@ void UpDownCounter::Reset() { void UpDownCounter::SetEdgeConfiguration(EdgeConfiguration configuration) { int32_t status = 0; - bool rising = configuration == EdgeConfiguration::kRisingEdge; + bool rising = configuration == EdgeConfiguration::RISING_EDGE; HAL_SetCounterEdgeConfiguration(m_handle, rising, &status); WPILIB_CheckErrorStatus(status, "{}", m_channel); } diff --git a/wpilibc/src/main/native/include/wpi/counter/EdgeConfiguration.hpp b/wpilibc/src/main/native/include/wpi/counter/EdgeConfiguration.hpp index 8954cc0ae9..c95ebe4ace 100644 --- a/wpilibc/src/main/native/include/wpi/counter/EdgeConfiguration.hpp +++ b/wpilibc/src/main/native/include/wpi/counter/EdgeConfiguration.hpp @@ -10,8 +10,8 @@ namespace wpi { */ enum class EdgeConfiguration { /// Rising edge configuration. - kRisingEdge = 0, + RISING_EDGE = 0, /// Falling edge configuration. - kFallingEdge = 1, + FALLING_EDGE = 1, }; } // namespace wpi diff --git a/wpilibj/src/main/java/org/wpilib/counter/EdgeConfiguration.java b/wpilibj/src/main/java/org/wpilib/counter/EdgeConfiguration.java index 1ff9c3285f..d16c8cc5b4 100644 --- a/wpilibj/src/main/java/org/wpilib/counter/EdgeConfiguration.java +++ b/wpilibj/src/main/java/org/wpilib/counter/EdgeConfiguration.java @@ -7,9 +7,9 @@ package org.wpilib.counter; /** Edge configuration. */ public enum EdgeConfiguration { /** Rising edge configuration. */ - kRisingEdge(true), + RISING_EDGE(true), /** Falling edge configuration. */ - kFallingEdge(false); + FALLING_EDGE(false); /** True if triggering on rising edge. */ @SuppressWarnings("MemberName")