Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-27 02:01:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpilib] Make protected fields in accelerometers/gyros private (#6134)

Browse Source 
This avoids needing add redundant JavaDocs to them, and better reflects
how we design our modern classes (the classes modified here were around
with minimal changes since 2008 or so).
This commit is contained in:
Tyler Veness
2024-01-01 16:49:50 -08:00
committed by GitHub
parent e7c9f27683
commit 91d8837c11
6 changed files with 16 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
wpilibc/src/main/native/include/frc/ADXL345_I2C.h
View File

@@ -100,7 +100,7 @@ class ADXL345_I2C : public nt::NTSendable,
void InitSendable(nt::NTSendableBuilder& builder) override;
protected:
private:
I2C m_i2c;
hal::SimDevice m_simDevice;

2
wpilibc/src/main/native/include/frc/ADXL345_SPI.h
View File

@@ -93,7 +93,7 @@ class ADXL345_SPI : public nt::NTSendable,
void InitSendable(nt::NTSendableBuilder& builder) override;
protected:
private:
SPI m_spi;
hal::SimDevice m_simDevice;

4
wpilibc/src/main/native/include/frc/AnalogGyro.h
View File

@@ -218,10 +218,8 @@ class AnalogGyro : public wpi::Sendable,
void InitSendable(wpi::SendableBuilder& builder) override;
protected:
std::shared_ptr<AnalogInput> m_analog;
private:
std::shared_ptr<AnalogInput> m_analog;
hal::Handle<HAL_GyroHandle> m_gyroHandle;
};