Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-22 01:11:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpilib] Make protected fields in accelerometers/gyros private (#6134)

Browse Source 
This avoids needing add redundant JavaDocs to them, and better reflects
how we design our modern classes (the classes modified here were around
with minimal changes since 2008 or so).
This commit is contained in:
Tyler Veness
2024-01-01 16:49:50 -08:00
committed by GitHub
parent e7c9f27683
commit 91d8837c11
6 changed files with 16 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_I2C.java
View File

@@ -70,13 +70,13 @@ public class ADXL345_I2C implements NTSendable, AutoCloseable {
public double ZAxis;
}
protected I2C m_i2c;
private I2C m_i2c;
protected SimDevice m_simDevice;
protected SimEnum m_simRange;
protected SimDouble m_simX;
protected SimDouble m_simY;
protected SimDouble m_simZ;
private SimDevice m_simDevice;
private SimEnum m_simRange;
private SimDouble m_simX;
private SimDouble m_simY;
private SimDouble m_simZ;
/**
* Constructs the ADXL345 Accelerometer with I2C address 0x1D.

12
wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_SPI.java
View File

@@ -67,13 +67,13 @@ public class ADXL345_SPI implements NTSendable, AutoCloseable {
public double ZAxis;
}
protected SPI m_spi;
private SPI m_spi;
protected SimDevice m_simDevice;
protected SimEnum m_simRange;
protected SimDouble m_simX;
protected SimDouble m_simY;
protected SimDouble m_simZ;
private SimDevice m_simDevice;
private SimEnum m_simRange;
private SimDouble m_simX;
private SimDouble m_simY;
private SimDouble m_simZ;
/**
* Constructor.

2
wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogGyro.java
View File

@@ -25,7 +25,7 @@ import edu.wpi.first.util.sendable.SendableRegistry;
*/
public class AnalogGyro implements Sendable, AutoCloseable {
private static final double kDefaultVoltsPerDegreePerSecond = 0.007;
protected AnalogInput m_analog;
private AnalogInput m_analog;
private boolean m_channelAllocated;
private int m_gyroHandle;