mirror of
https://github.com/wpilibsuite/allwpilib
synced 2026-06-19 00:41:43 +00:00
[hal,wpilib] Fix TimedRobot notifier race (#8445)
It was possible for the alarm to fire between the set alarm and ack, resulting in a hang on next wait. It's not possible to ack before set alarm due to a race in sim step timing, so the fix is to provide an atomic ack and set alarm; the easiest way to implement this in the API was to change ack to optionally also set the alarm again.
This commit is contained in:
@@ -95,7 +95,7 @@ public class Notifier implements AutoCloseable {
|
||||
}
|
||||
|
||||
// Acknowledge the alarm
|
||||
NotifierJNI.acknowledgeNotifierAlarm(notifier);
|
||||
NotifierJNI.acknowledgeNotifierAlarm(notifier, false, 0, 0, false);
|
||||
}
|
||||
});
|
||||
m_thread.setName("Notifier");
|
||||
|
||||
Reference in New Issue
Block a user