Reclassified NetworkTables headers as "other library" (#775)

.styleguide

@@ -31,6 +31,7 @@ modifiableFileExclude {
 includeOtherLibs {
   ^HAL/
   ^llvm/
+  ^networktables/
   ^opencv2/
   ^support/
 }

wpilibc/src/main/native/cpp/Buttons/NetworkButton.cpp

@@ -7,8 +7,8 @@
 
 #include "Buttons/NetworkButton.h"
 
-#include "networktables/NetworkTable.h"
-#include "networktables/NetworkTableInstance.h"
+#include <networktables/NetworkTable.h>
+#include <networktables/NetworkTableInstance.h>
 
 using namespace frc;
 

wpilibc/src/main/native/cpp/CameraServer.cpp

@@ -10,10 +10,10 @@
 #include <HAL/HAL.h>
 #include <llvm/SmallString.h>
 #include <llvm/raw_ostream.h>
+#include <networktables/NetworkTableInstance.h>
 
 #include "Utility.h"
 #include "WPIErrors.h"
-#include "networktables/NetworkTableInstance.h"
 #include "ntcore_cpp.h"
 
 using namespace frc;

wpilibc/src/main/native/cpp/LiveWindow/LiveWindow.cpp

@@ -12,13 +12,13 @@
 #include <llvm/DenseMap.h>
 #include <llvm/SmallString.h>
 #include <llvm/raw_ostream.h>
+#include <networktables/NetworkTable.h>
+#include <networktables/NetworkTableEntry.h>
+#include <networktables/NetworkTableInstance.h>
 #include <support/mutex.h>
 
 #include "Commands/Scheduler.h"
 #include "SmartDashboard/SendableBuilderImpl.h"
-#include "networktables/NetworkTable.h"
-#include "networktables/NetworkTableEntry.h"
-#include "networktables/NetworkTableInstance.h"
 
 using namespace frc;
 

wpilibc/src/main/native/cpp/Preferences.cpp

@@ -11,9 +11,9 @@
 
 #include <HAL/HAL.h>
 #include <llvm/StringRef.h>
+#include <networktables/NetworkTableInstance.h>
 
 #include "WPIErrors.h"
-#include "networktables/NetworkTableInstance.h"
 
 using namespace frc;
 

wpilibc/src/main/native/cpp/RobotBase.cpp

@@ -10,6 +10,7 @@
 #include <cstdio>
 
 #include <HAL/HAL.h>
+#include <networktables/NetworkTableInstance.h>
 
 #include "DriverStation.h"
 #include "HLUsageReporting.h"
@@ -19,7 +20,6 @@
 #include "SmartDashboard/SmartDashboard.h"
 #include "Utility.h"
 #include "WPILibVersion.h"
-#include "networktables/NetworkTableInstance.h"
 
 using namespace frc;
 

wpilibc/src/main/native/cpp/SampleRobot.cpp

@@ -8,11 +8,11 @@
 #include "SampleRobot.h"
 
 #include <llvm/raw_ostream.h>
+#include <networktables/NetworkTable.h>
 
 #include "DriverStation.h"
 #include "LiveWindow/LiveWindow.h"
 #include "Timer.h"
-#include "networktables/NetworkTable.h"
 
 using namespace frc;
 

wpilibc/src/main/native/cpp/SmartDashboard/SmartDashboard.cpp

@@ -8,14 +8,14 @@
 #include "SmartDashboard/SmartDashboard.h"
 
 #include <llvm/StringMap.h>
+#include <networktables/NetworkTable.h>
+#include <networktables/NetworkTableInstance.h>
 #include <support/mutex.h>
 
 #include "HLUsageReporting.h"
 #include "SmartDashboard/Sendable.h"
 #include "SmartDashboard/SendableBuilderImpl.h"
 #include "WPIErrors.h"
-#include "networktables/NetworkTable.h"
-#include "networktables/NetworkTableInstance.h"
 
 using namespace frc;
 

wpilibc/src/main/native/include/Buttons/NetworkButton.h

@@ -10,10 +10,10 @@
 #include <memory>
 
 #include <llvm/Twine.h>
+#include <networktables/NetworkTable.h>
+#include <networktables/NetworkTableEntry.h>
 
 #include "Buttons/Button.h"
-#include "networktables/NetworkTable.h"
-#include "networktables/NetworkTableEntry.h"
 
 namespace frc {
 

wpilibc/src/main/native/include/CameraServer.h

@@ -17,11 +17,11 @@
 #include <llvm/DenseMap.h>
 #include <llvm/StringMap.h>
 #include <llvm/StringRef.h>
+#include <networktables/NetworkTable.h>
 #include <support/mutex.h>
 
 #include "ErrorBase.h"
 #include "cscore.h"
-#include "networktables/NetworkTable.h"
 
 namespace frc {
 

wpilibc/src/main/native/include/Commands/Scheduler.h

@@ -12,12 +12,12 @@
 #include <string>
 #include <vector>
 
+#include <networktables/NetworkTableEntry.h>
 #include <support/mutex.h>
 
 #include "Commands/Command.h"
 #include "ErrorBase.h"
 #include "SmartDashboard/SendableBase.h"
-#include "networktables/NetworkTableEntry.h"
 
 namespace frc {
 

wpilibc/src/main/native/include/Preferences.h

@@ -13,8 +13,9 @@
 #include <string>
 #include <vector>
 
+#include <networktables/NetworkTable.h>
+
 #include "ErrorBase.h"
-#include "networktables/NetworkTable.h"
 
 namespace frc {
 

wpilibc/src/main/native/include/SmartDashboard/SendableBuilder.h

@@ -15,9 +15,8 @@
 #include <llvm/ArrayRef.h>
 #include <llvm/SmallVector.h>
 #include <llvm/Twine.h>
-
-#include "networktables/NetworkTableEntry.h"
-#include "networktables/NetworkTableValue.h"
+#include <networktables/NetworkTableEntry.h>
+#include <networktables/NetworkTableValue.h>
 
 namespace frc {
 

wpilibc/src/main/native/include/SmartDashboard/SendableBuilderImpl.h

@@ -16,11 +16,11 @@
 #include <llvm/ArrayRef.h>
 #include <llvm/SmallVector.h>
 #include <llvm/Twine.h>
+#include <networktables/NetworkTable.h>
+#include <networktables/NetworkTableEntry.h>
+#include <networktables/NetworkTableValue.h>
 
 #include "SendableBuilder.h"
-#include "networktables/NetworkTable.h"
-#include "networktables/NetworkTableEntry.h"
-#include "networktables/NetworkTableValue.h"
 
 namespace frc {
 

wpilibc/src/main/native/include/SmartDashboard/SendableChooserBase.h

@@ -9,8 +9,9 @@
 
 #include <string>
 
+#include <networktables/NetworkTableEntry.h>
+
 #include "SmartDashboard/SendableBase.h"
-#include "networktables/NetworkTableEntry.h"
 
 namespace frc {
 

wpilibc/src/main/native/include/SmartDashboard/SmartDashboard.h

@@ -11,8 +11,9 @@
 #include <string>
 #include <vector>
 
+#include <networktables/NetworkTableValue.h>
+
 #include "SensorBase.h"
-#include "networktables/NetworkTableValue.h"
 
 namespace frc {
 

wpilibcIntegrationTests/src/FRCUserProgram/cpp/PreferencesTest.cpp

@@ -10,9 +10,10 @@
 #include <cstdio>
 #include <fstream>
 
+#include <networktables/NetworkTableInstance.h>
+
 #include "Timer.h"
 #include "gtest/gtest.h"
-#include "networktables/NetworkTableInstance.h"
 #include "ntcore.h"
 
 using namespace frc;