Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-23 01:21:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[build] Enable spotbugs (#3601)

Browse Source 
Benign spotbugs warnings were suppressed, and all others were fixed. Bug
descriptions are documented here:
https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html

Co-authored-by: Austin Shalit <austinshalit@gmail.com>
This commit is contained in:
Tyler Veness
2021-09-24 16:04:02 -07:00
committed by GitHub
parent b65fce86bf
commit 95dd20a151
73 changed files with 356 additions and 558 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command/CommandGroupErrorTest.java
View File

@@ -17,8 +17,7 @@ class CommandGroupErrorTest extends CommandTestBase {
MockCommandHolder command2Holder = new MockCommandHolder(true);
Command command2 = command2Holder.getMock();
@SuppressWarnings("PMD.UnusedLocalVariable")
Command group = new ParallelCommandGroup(command1, command2);
new ParallelCommandGroup(command1, command2);
assertThrows(
IllegalArgumentException.class, () -> new ParallelCommandGroup(command1, command2));
}
@@ -31,8 +30,7 @@ class CommandGroupErrorTest extends CommandTestBase {
MockCommandHolder command2Holder = new MockCommandHolder(true);
Command command2 = command2Holder.getMock();
@SuppressWarnings("PMD.UnusedLocalVariable")
Command group = new ParallelCommandGroup(command1, command2);
new ParallelCommandGroup(command1, command2);
assertThrows(IllegalArgumentException.class, () -> scheduler.schedule(command1));
}

8
wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command/CommandTestBase.java
View File

@@ -41,9 +41,9 @@ public abstract class CommandTestBase {
}
}
public class TestSubsystem extends SubsystemBase {}
public static class TestSubsystem extends SubsystemBase {}
public class MockCommandHolder {
public static class MockCommandHolder {
private final Command m_mockCommand = mock(Command.class);
public MockCommandHolder(boolean runWhenDisabled, Subsystem... requirements) {
@@ -61,7 +61,7 @@ public abstract class CommandTestBase {
}
}
public class Counter {
public static class Counter {
public int m_counter;
public void increment() {
@@ -69,7 +69,7 @@ public abstract class CommandTestBase {
}
}
public class ConditionHolder {
public static class ConditionHolder {
private boolean m_condition;
public void setCondition(boolean condition) {