[build] Enable spotbugs (#3601)

Benign spotbugs warnings were suppressed, and all others were fixed. Bug
descriptions are documented here:
https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html

Co-authored-by: Austin Shalit <austinshalit@gmail.com>
This commit is contained in:
Tyler Veness
2021-09-24 16:04:02 -07:00
committed by GitHub
parent b65fce86bf
commit 95dd20a151
73 changed files with 356 additions and 558 deletions

View File

@@ -30,11 +30,11 @@ public class Robot extends TimedRobot {
public static OI oi;
// Initialize the subsystems
public static Drivetrain drivetrain = new Drivetrain();
public static Collector collector = new Collector();
public static Shooter shooter = new Shooter();
public static Pneumatics pneumatics = new Pneumatics();
public static Pivot pivot = new Pivot();
public static final Drivetrain drivetrain = new Drivetrain();
public static final Collector collector = new Collector();
public static final Shooter shooter = new Shooter();
public static final Pneumatics pneumatics = new Pneumatics();
public static final Pivot pivot = new Pivot();
public SendableChooser<Command> m_autoChooser;

View File

@@ -19,7 +19,7 @@ import edu.wpi.first.wpilibj.templates.oldcommandbased.subsystems.ExampleSubsyst
* project.
*/
public class Robot extends TimedRobot {
public static ExampleSubsystem m_subsystem = new ExampleSubsystem();
public static final ExampleSubsystem m_subsystem = new ExampleSubsystem();
public static OI m_oi;
Command m_autonomousCommand;