[build] Enable spotbugs (#3601)

Benign spotbugs warnings were suppressed, and all others were fixed. Bug
descriptions are documented here:
https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html

Co-authored-by: Austin Shalit <austinshalit@gmail.com>
This commit is contained in:
Tyler Veness
2021-09-24 16:04:02 -07:00
committed by GitHub
parent b65fce86bf
commit 95dd20a151
73 changed files with 356 additions and 558 deletions

View File

@@ -16,7 +16,7 @@ public class FakeCounterSource implements AutoCloseable {
private boolean m_allocated;
/** Thread object that allows emulation of an encoder. */
private class EncoderThread extends Thread {
private static class EncoderThread extends Thread {
FakeCounterSource m_encoder;
EncoderThread(FakeCounterSource encode) {

View File

@@ -18,7 +18,7 @@ public class FakeEncoderSource implements AutoCloseable {
private final boolean m_allocatedOutputs;
/** Thread object that allows emulation of a quadrature encoder. */
private class QuadEncoderThread extends Thread {
private static class QuadEncoderThread extends Thread {
FakeEncoderSource m_encoder;
QuadEncoderThread(FakeEncoderSource encode) {