Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[build] Enable spotbugs (#3601)

Browse Source 
Benign spotbugs warnings were suppressed, and all others were fixed. Bug
descriptions are documented here:
https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html

Co-authored-by: Austin Shalit <austinshalit@gmail.com>
This commit is contained in:
Tyler Veness
2021-09-24 16:04:02 -07:00
committed by GitHub
parent b65fce86bf
commit 95dd20a151
73 changed files with 356 additions and 558 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wpiutil/src/main/java/edu/wpi/first/util/CombinedRuntimeLoader.java
View File

@@ -100,7 +100,11 @@ public final class CombinedRuntimeLoader {
if (outputFile.toFile().exists()) {
continue;
}
outputFile.getParent().toFile().mkdirs();
var parent = outputFile.getParent();
if (parent == null) {
throw new IOException("Output file has no parent");
}
parent.toFile().mkdirs();
try (var os = Files.newOutputStream(outputFile)) {
int readBytes;

3
wpiutil/src/main/java/edu/wpi/first/util/RuntimeDetector.java
View File

@@ -135,6 +135,9 @@ public final class RuntimeDetector {
public static boolean isRaspbian() {
try (BufferedReader reader = Files.newBufferedReader(Paths.get("/etc/os-release"))) {
String value = reader.readLine();
if (value == null) {
return false;
}
return value.contains("Raspbian");
} catch (IOException ex) {
return false;

16
wpiutil/src/main/java/edu/wpi/first/util/RuntimeLoader.java
View File

@@ -105,7 +105,13 @@ public final class RuntimeLoader<T> {
if (resIs == null) {
throw new IOException(getLoadErrorMessage(ule));
}
jniLibrary.getParentFile().mkdirs();
var parentFile = jniLibrary.getParentFile();
if (parentFile == null) {
throw new IOException("JNI library has no parent file");
}
parentFile.mkdirs();
try (OutputStream os = Files.newOutputStream(jniLibrary.toPath())) {
byte[] buffer = new byte[0xFFFF]; // 64K copy buffer
int readBytes;
@@ -171,7 +177,13 @@ public final class RuntimeLoader<T> {
if (resIs == null) {
throw new IOException(getLoadErrorMessage(ule));
}
jniLibrary.getParentFile().mkdirs();
var parentFile = jniLibrary.getParentFile();
if (parentFile == null) {
throw new IOException("JNI library has no parent file");
}
parentFile.mkdirs();
try (OutputStream os = Files.newOutputStream(jniLibrary.toPath())) {
byte[] buffer = new byte[0xFFFF]; // 64K copy buffer
int readBytes;