[build] Enable spotbugs (#3601)

Benign spotbugs warnings were suppressed, and all others were fixed. Bug
descriptions are documented here:
https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html

Co-authored-by: Austin Shalit <austinshalit@gmail.com>
This commit is contained in:
Tyler Veness
2021-09-24 16:04:02 -07:00
committed by GitHub
parent b65fce86bf
commit 95dd20a151
73 changed files with 356 additions and 558 deletions

View File

@@ -100,7 +100,11 @@ public final class CombinedRuntimeLoader {
if (outputFile.toFile().exists()) {
continue;
}
outputFile.getParent().toFile().mkdirs();
var parent = outputFile.getParent();
if (parent == null) {
throw new IOException("Output file has no parent");
}
parent.toFile().mkdirs();
try (var os = Files.newOutputStream(outputFile)) {
int readBytes;