Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-22 01:11:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Changed const char* -> string in most of wpilibc.

Browse Source 
The HAL will remain untouched in order to maintain C-style
compatibility. A few places in wpilibc were left as
C-style strings, especially if special formatting (eg,
elaborate uses of snprintf or sscanf) was being used.

In general, const char* was changed to std::string.
character buffers used for formatting were either
untouched, changed to std::stringstream, or changed
to std::string, depending on what was done with
the buffer.

Change-Id: I5e431ddf1cc4d9a6d534e1f21b16ea23be26e7f1
This commit is contained in:
James Kuszmaul
2015-06-30 15:01:20 -04:00
parent 534ea134a4
commit 98f2d08103
55 changed files with 300 additions and 234 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
wpilibc/wpilibC++Devices/src/AnalogOutput.cpp
View File

@@ -10,6 +10,8 @@
#include "WPIErrors.h"
#include "LiveWindow/LiveWindow.h"
#include <sstream>
static ::std::unique_ptr<Resource> outputs;
/**
@@ -20,15 +22,15 @@ static ::std::unique_ptr<Resource> outputs;
AnalogOutput::AnalogOutput(uint32_t channel) {
Resource::CreateResourceObject(outputs, kAnalogOutputs);
char buf[64];
std::stringstream buf;
buf << "analog input " << channel;
if (!checkAnalogOutputChannel(channel)) {
snprintf(buf, 64, "analog input %d", channel);
wpi_setWPIErrorWithContext(ChannelIndexOutOfRange, buf);
wpi_setWPIErrorWithContext(ChannelIndexOutOfRange, buf.str());
return;
}
if (outputs->Allocate(channel, buf) == ~0ul) {
if (outputs->Allocate(channel, buf.str()) == ~0ul) {
CloneError(*outputs);
return;
}