Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[epilogue] Revert "Add a measure's symbol to its name when logged by Epilogue (#7535)" (#7652)

Browse Source 
This reverts commit 469bb3290d.

The approach used has issues due to the fact unit symbols often have a literal / in them,
which causes issues with NT topic visualization.

A better approach would be to use topic metadata.
This commit is contained in:
oh-yes-0-fps
2025-01-07 14:35:10 -05:00
committed by GitHub
parent 2de03c9601
commit 995bc98ccf
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
epilogue-runtime/src/main/java/edu/wpi/first/epilogue/logging/EpilogueBackend.java
View File

@@ -198,10 +198,9 @@ public interface EpilogueBackend {
*
* @param identifier the identifier of the data field
* @param value the new value of the data field
* @param <U> the dimension of the unit
*/
default <U extends Unit> void log(String identifier, Measure<U> value) {
log(identifier, value, value.baseUnit());
default void log(String identifier, Measure<?> value) {
log(identifier, value.baseUnitMagnitude());
}
/**
@@ -213,7 +212,7 @@ public interface EpilogueBackend {
* @param <U> the dimension of the unit
*/
default <U extends Unit> void log(String identifier, Measure<U> value, U unit) {
log(identifier + " (" + unit.symbol() + ")", value.in(unit));
log(identifier, value.in(unit));
}
/**