diff --git a/apriltag/src/main/java/edu/wpi/first/apriltag/AprilTagFieldLayout.java b/apriltag/src/main/java/edu/wpi/first/apriltag/AprilTagFieldLayout.java index c670cf1ae1..3a85ded7c0 100644 --- a/apriltag/src/main/java/edu/wpi/first/apriltag/AprilTagFieldLayout.java +++ b/apriltag/src/main/java/edu/wpi/first/apriltag/AprilTagFieldLayout.java @@ -152,9 +152,10 @@ public class AprilTagFieldLayout { var pose = switch (origin) { case kBlueAllianceWallRightSide -> Pose3d.kZero; - case kRedAllianceWallRightSide -> new Pose3d( - new Translation3d(m_fieldDimensions.fieldLength, m_fieldDimensions.fieldWidth, 0), - new Rotation3d(0, 0, Math.PI)); + case kRedAllianceWallRightSide -> + new Pose3d( + new Translation3d(m_fieldDimensions.fieldLength, m_fieldDimensions.fieldWidth, 0), + new Rotation3d(0, 0, Math.PI)); }; setOrigin(pose); } diff --git a/apriltag/src/test/java/edu/wpi/first/apriltag/AprilTagDetectorTest.java b/apriltag/src/test/java/edu/wpi/first/apriltag/AprilTagDetectorTest.java index e290343fa0..4a83016b8c 100644 --- a/apriltag/src/test/java/edu/wpi/first/apriltag/AprilTagDetectorTest.java +++ b/apriltag/src/test/java/edu/wpi/first/apriltag/AprilTagDetectorTest.java @@ -24,7 +24,6 @@ import org.opencv.core.Mat; import org.opencv.imgcodecs.Imgcodecs; import org.opencv.imgproc.Imgproc; -@SuppressWarnings("PMD.MutableStaticState") class AprilTagDetectorTest { @SuppressWarnings("MemberName") AprilTagDetector detector; diff --git a/build.gradle b/build.gradle index 3e8f45f37e..c752168520 100644 --- a/build.gradle +++ b/build.gradle @@ -17,10 +17,10 @@ plugins { id 'edu.wpi.first.GradleVsCode' id 'idea' id 'visual-studio' - id 'net.ltgt.errorprone' version '3.1.0' apply false - id 'com.gradleup.shadow' version '8.3.4' apply false - id 'com.diffplug.spotless' version '6.20.0' apply false - id 'com.github.spotbugs' version '6.0.2' apply false + id 'net.ltgt.errorprone' version '4.3.0' apply false + id 'com.gradleup.shadow' version '9.0.0' apply false + id 'com.diffplug.spotless' version '7.2.1' apply false + id 'com.github.spotbugs' version '6.2.3' apply false } wpilibVersioning.buildServerMode = project.hasProperty('buildServer') diff --git a/cameraserver/multiCameraServer/build.gradle b/cameraserver/multiCameraServer/build.gradle index 377bdbcf3c..687c20046e 100644 --- a/cameraserver/multiCameraServer/build.gradle +++ b/cameraserver/multiCameraServer/build.gradle @@ -31,7 +31,7 @@ repositories { } dependencies { - implementation 'com.google.code.gson:gson:2.10.1' + implementation 'com.google.code.gson:gson:2.13.1' implementation project(':wpiutil') implementation project(':wpinet') diff --git a/cameraserver/src/main/java/edu/wpi/first/cameraserver/CameraServer.java b/cameraserver/src/main/java/edu/wpi/first/cameraserver/CameraServer.java index 0ff47f8f5c..e724cbdccc 100644 --- a/cameraserver/src/main/java/edu/wpi/first/cameraserver/CameraServer.java +++ b/cameraserver/src/main/java/edu/wpi/first/cameraserver/CameraServer.java @@ -46,7 +46,7 @@ public final class CameraServer { private static final String kPublishName = "/CameraPublisher"; private static final class PropertyPublisher implements AutoCloseable { - @SuppressWarnings({"PMD.MissingBreakInSwitch", "PMD.ImplicitSwitchFallThrough", "fallthrough"}) + @SuppressWarnings("fallthrough") PropertyPublisher(NetworkTable table, VideoEvent event) { String name; String infoName; @@ -66,7 +66,7 @@ public final class CameraServer { break; case kEnum: m_choicesTopic = table.getStringArrayTopic(infoName + "/choices"); - // fall through + // fallthrough case kInteger: m_integerValueEntry = table.getIntegerTopic(name).getEntry(0); m_minPublisher = table.getIntegerTopic(infoName + "/min").publish(); diff --git a/cameraserver/src/main/java/edu/wpi/first/vision/VisionPipeline.java b/cameraserver/src/main/java/edu/wpi/first/vision/VisionPipeline.java index 29c285f03e..d9e65df896 100644 --- a/cameraserver/src/main/java/edu/wpi/first/vision/VisionPipeline.java +++ b/cameraserver/src/main/java/edu/wpi/first/vision/VisionPipeline.java @@ -13,6 +13,7 @@ import org.opencv.core.Mat; * @see VisionRunner * @see VisionThread */ +@FunctionalInterface public interface VisionPipeline { /** * Processes the image input and sets the result objects. Implementations should make these diff --git a/cscore/src/main/java/edu/wpi/first/cscore/CvSource.java b/cscore/src/main/java/edu/wpi/first/cscore/CvSource.java index 944b58f0eb..4ca03a4194 100644 --- a/cscore/src/main/java/edu/wpi/first/cscore/CvSource.java +++ b/cscore/src/main/java/edu/wpi/first/cscore/CvSource.java @@ -68,8 +68,9 @@ public class CvSource extends ImageSource { case 2 -> PixelFormat.kYUYV; // 2 channels is assumed YUYV case 3 -> PixelFormat.kBGR; // 3 channels is assumed BGR case 4 -> PixelFormat.kBGRA; // 4 channels is assumed BGRA - default -> throw new VideoException( - "Unable to get pixel format for " + channels + " channels"); + default -> + throw new VideoException( + "Unable to get pixel format for " + channels + " channels"); }; putFrame(finalImage, format, true); diff --git a/docs/build.gradle b/docs/build.gradle index 597699515f..f18433901a 100644 --- a/docs/build.gradle +++ b/docs/build.gradle @@ -1,6 +1,6 @@ plugins { id 'java' - id "org.ysb33r.doxygen" version "1.0.4" + id "org.ysb33r.doxygen" version "2.0.0" } evaluationDependsOn(':apriltag') @@ -62,12 +62,12 @@ doxygen { } } -doxygen { - template 'Doxyfile' +doxygen.sourceSets.main { + template = 'Doxyfile' cppProjectZips.each { - dependsOn it - source it.source + doxygenDox.dependsOn it + sources it.source it.ext.includeDirs.each { cppIncludeRoots.add(it.absolutePath) } @@ -169,7 +169,7 @@ doxygen { tasks.register("zipCppDocs", Zip) { archiveBaseName = zipBaseNameCpp destinationDirectory = outputsFolder - dependsOn doxygen + dependsOn doxygenDox from ("$buildDir/docs/doxygen/html") into '/' } diff --git a/epilogue-processor/src/test/java/edu/wpi/first/epilogue/processor/AnnotationProcessorTest.java b/epilogue-processor/src/test/java/edu/wpi/first/epilogue/processor/AnnotationProcessorTest.java index 50795a45b0..bc6189bf0b 100644 --- a/epilogue-processor/src/test/java/edu/wpi/first/epilogue/processor/AnnotationProcessorTest.java +++ b/epilogue-processor/src/test/java/edu/wpi/first/epilogue/processor/AnnotationProcessorTest.java @@ -2536,7 +2536,8 @@ class AnnotationProcessorTest { class Example {} """; - String packageInfo = """ + String packageInfo = + """ package example; """; diff --git a/epilogue-runtime/src/main/java/edu/wpi/first/epilogue/logging/LogBackedSendableBuilder.java b/epilogue-runtime/src/main/java/edu/wpi/first/epilogue/logging/LogBackedSendableBuilder.java index 5de5756ff4..67277e30b5 100644 --- a/epilogue-runtime/src/main/java/edu/wpi/first/epilogue/logging/LogBackedSendableBuilder.java +++ b/epilogue-runtime/src/main/java/edu/wpi/first/epilogue/logging/LogBackedSendableBuilder.java @@ -19,7 +19,6 @@ import java.util.function.LongSupplier; import java.util.function.Supplier; /** A sendable builder implementation that sends data to a {@link EpilogueBackend}. */ -@SuppressWarnings("PMD.CouplingBetweenObjects") // most methods simply delegate to the backend public class LogBackedSendableBuilder implements SendableBuilder { private final EpilogueBackend m_backend; private final Collection m_updates = new ArrayList<>(); diff --git a/hal/src/main/java/edu/wpi/first/hal/AnalogJNI.java b/hal/src/main/java/edu/wpi/first/hal/AnalogJNI.java index f2996f60c2..3b8f439356 100644 --- a/hal/src/main/java/edu/wpi/first/hal/AnalogJNI.java +++ b/hal/src/main/java/edu/wpi/first/hal/AnalogJNI.java @@ -15,19 +15,19 @@ package edu.wpi.first.hal; public class AnalogJNI extends JNIWrapper { /** * native declaration : AthenaJava\target\native\include\HAL\Analog.h:58
- * enum values + * enum values. */ public interface AnalogTriggerType { - /** native declaration : AthenaJava\target\native\include\HAL\Analog.h:54 */ + /** native declaration : AthenaJava\target\native\include\HAL\Analog.h:54. */ int kInWindow = 0; - /** native declaration : AthenaJava\target\native\include\HAL\Analog.h:55 */ + /** native declaration : AthenaJava\target\native\include\HAL\Analog.h:55. */ int kState = 1; - /** native declaration : AthenaJava\target\native\include\HAL\Analog.h:56 */ + /** native declaration : AthenaJava\target\native\include\HAL\Analog.h:56. */ int kRisingPulse = 2; - /** native declaration : AthenaJava\target\native\include\HAL\Analog.h:57 */ + /** native declaration : AthenaJava\target\native\include\HAL\Analog.h:57. */ int kFallingPulse = 3; } diff --git a/hal/src/main/java/edu/wpi/first/hal/CANAPITypes.java b/hal/src/main/java/edu/wpi/first/hal/CANAPITypes.java index e485ee6399..cef69b65b2 100644 --- a/hal/src/main/java/edu/wpi/first/hal/CANAPITypes.java +++ b/hal/src/main/java/edu/wpi/first/hal/CANAPITypes.java @@ -53,7 +53,7 @@ public final class CANAPITypes { kFirmwareUpdate(31); /** The device type ID. */ - @SuppressWarnings("PMD.MemberName") + @SuppressWarnings("MemberName") public final int id; CANDeviceType(int id) { @@ -108,7 +108,7 @@ public final class CANAPITypes { kVividHosting(16); /** The manufacturer ID. */ - @SuppressWarnings("PMD.MemberName") + @SuppressWarnings("MemberName") public final int id; CANManufacturer(int id) { diff --git a/hal/src/main/java/edu/wpi/first/hal/PowerDistributionFaults.java b/hal/src/main/java/edu/wpi/first/hal/PowerDistributionFaults.java index 052c72b4cd..ac141c1006 100644 --- a/hal/src/main/java/edu/wpi/first/hal/PowerDistributionFaults.java +++ b/hal/src/main/java/edu/wpi/first/hal/PowerDistributionFaults.java @@ -125,8 +125,8 @@ public class PowerDistributionFaults { case 21 -> Channel21BreakerFault; case 22 -> Channel22BreakerFault; case 23 -> Channel23BreakerFault; - default -> throw new IndexOutOfBoundsException( - "Power distribution fault channel out of bounds!"); + default -> + throw new IndexOutOfBoundsException("Power distribution fault channel out of bounds!"); }; } diff --git a/hal/src/main/java/edu/wpi/first/hal/PowerDistributionStickyFaults.java b/hal/src/main/java/edu/wpi/first/hal/PowerDistributionStickyFaults.java index 4d7836c5e6..aced62501e 100644 --- a/hal/src/main/java/edu/wpi/first/hal/PowerDistributionStickyFaults.java +++ b/hal/src/main/java/edu/wpi/first/hal/PowerDistributionStickyFaults.java @@ -134,8 +134,8 @@ public class PowerDistributionStickyFaults { case 21 -> Channel21BreakerFault; case 22 -> Channel22BreakerFault; case 23 -> Channel23BreakerFault; - default -> throw new IndexOutOfBoundsException( - "Power distribution fault channel out of bounds!"); + default -> + throw new IndexOutOfBoundsException("Power distribution fault channel out of bounds!"); }; } diff --git a/hal/src/main/java/edu/wpi/first/hal/can/CANExceptionFactory.java b/hal/src/main/java/edu/wpi/first/hal/can/CANExceptionFactory.java index d5b5688ce5..32bf43de03 100644 --- a/hal/src/main/java/edu/wpi/first/hal/can/CANExceptionFactory.java +++ b/hal/src/main/java/edu/wpi/first/hal/can/CANExceptionFactory.java @@ -32,15 +32,14 @@ public final class CANExceptionFactory { case NIRioStatus.kRioStatusSuccess -> { // Everything is ok... don't throw. } - case ERR_CANSessionMux_InvalidBuffer, - NIRioStatus.kRIOStatusBufferInvalidSize -> throw new CANInvalidBufferException(); - case ERR_CANSessionMux_MessageNotFound, - NIRioStatus.kRIOStatusOperationTimedOut -> throw new CANMessageNotFoundException(); - case ERR_CANSessionMux_NotAllowed, - NIRioStatus.kRIOStatusFeatureNotSupported -> throw new CANMessageNotAllowedException( - "MessageID = " + messageID); - case ERR_CANSessionMux_NotInitialized, - NIRioStatus.kRIOStatusResourceNotInitialized -> throw new CANNotInitializedException(); + case ERR_CANSessionMux_InvalidBuffer, NIRioStatus.kRIOStatusBufferInvalidSize -> + throw new CANInvalidBufferException(); + case ERR_CANSessionMux_MessageNotFound, NIRioStatus.kRIOStatusOperationTimedOut -> + throw new CANMessageNotFoundException(); + case ERR_CANSessionMux_NotAllowed, NIRioStatus.kRIOStatusFeatureNotSupported -> + throw new CANMessageNotAllowedException("MessageID = " + messageID); + case ERR_CANSessionMux_NotInitialized, NIRioStatus.kRIOStatusResourceNotInitialized -> + throw new CANNotInitializedException(); default -> throw new UncleanStatusException("Fatal status code detected: " + status); } } diff --git a/hal/src/main/java/edu/wpi/first/hal/simulation/BufferCallback.java b/hal/src/main/java/edu/wpi/first/hal/simulation/BufferCallback.java index 7c66563a32..efe70af800 100644 --- a/hal/src/main/java/edu/wpi/first/hal/simulation/BufferCallback.java +++ b/hal/src/main/java/edu/wpi/first/hal/simulation/BufferCallback.java @@ -5,6 +5,7 @@ package edu.wpi.first.hal.simulation; /** Interface for simulation buffer callbacks. */ +@FunctionalInterface public interface BufferCallback { /** * Simulation buffer callback function. diff --git a/hal/src/main/java/edu/wpi/first/hal/simulation/ConstBufferCallback.java b/hal/src/main/java/edu/wpi/first/hal/simulation/ConstBufferCallback.java index 9e88ec3a88..21277b3c0b 100644 --- a/hal/src/main/java/edu/wpi/first/hal/simulation/ConstBufferCallback.java +++ b/hal/src/main/java/edu/wpi/first/hal/simulation/ConstBufferCallback.java @@ -4,6 +4,7 @@ package edu.wpi.first.hal.simulation; +@FunctionalInterface public interface ConstBufferCallback { void callback(String name, byte[] buffer, int count); } diff --git a/hal/src/main/java/edu/wpi/first/hal/simulation/NotifyCallback.java b/hal/src/main/java/edu/wpi/first/hal/simulation/NotifyCallback.java index 55605b8167..e0b3233f52 100644 --- a/hal/src/main/java/edu/wpi/first/hal/simulation/NotifyCallback.java +++ b/hal/src/main/java/edu/wpi/first/hal/simulation/NotifyCallback.java @@ -6,6 +6,7 @@ package edu.wpi.first.hal.simulation; import edu.wpi.first.hal.HALValue; +@FunctionalInterface public interface NotifyCallback { void callback(String name, HALValue value); diff --git a/hal/src/main/java/edu/wpi/first/hal/simulation/SpiReadAutoReceiveBufferCallback.java b/hal/src/main/java/edu/wpi/first/hal/simulation/SpiReadAutoReceiveBufferCallback.java index 10dd0d2e21..6aa446b7b4 100644 --- a/hal/src/main/java/edu/wpi/first/hal/simulation/SpiReadAutoReceiveBufferCallback.java +++ b/hal/src/main/java/edu/wpi/first/hal/simulation/SpiReadAutoReceiveBufferCallback.java @@ -4,6 +4,7 @@ package edu.wpi.first.hal.simulation; +@FunctionalInterface public interface SpiReadAutoReceiveBufferCallback { int callback(String name, int[] buffer, int numToRead); } diff --git a/ntcore/src/generate/main/java/EntryImpl.java.jinja b/ntcore/src/generate/main/java/EntryImpl.java.jinja index 5053e10cdb..e022bd8ac9 100644 --- a/ntcore/src/generate/main/java/EntryImpl.java.jinja +++ b/ntcore/src/generate/main/java/EntryImpl.java.jinja @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.nio.ByteBuffer; {% endif %} /** NetworkTables {{ TypeName }} implementation. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") final class {{ TypeName }}EntryImpl extends EntryBase implements {{ TypeName }}Entry { /** * Constructor. diff --git a/ntcore/src/generate/main/java/GenericSubscriber.java.jinja b/ntcore/src/generate/main/java/GenericSubscriber.java.jinja index c0ed6611a9..883d20ecb9 100644 --- a/ntcore/src/generate/main/java/GenericSubscriber.java.jinja +++ b/ntcore/src/generate/main/java/GenericSubscriber.java.jinja @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.util.function.Supplier; /** NetworkTables generic subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface GenericSubscriber extends Subscriber, Supplier { /** * Get the corresponding topic. diff --git a/ntcore/src/generate/main/java/NetworkTableValue.java.jinja b/ntcore/src/generate/main/java/NetworkTableValue.java.jinja index 7d82b25b3b..8b0baf1a83 100644 --- a/ntcore/src/generate/main/java/NetworkTableValue.java.jinja +++ b/ntcore/src/generate/main/java/NetworkTableValue.java.jinja @@ -9,7 +9,7 @@ package edu.wpi.first.networktables; import java.util.Objects; /** A network table entry value. */ -@SuppressWarnings({"UnnecessaryParentheses", "PMD.MethodReturnsInternalArray"}) +@SuppressWarnings("UnnecessaryParentheses") public final class NetworkTableValue { NetworkTableValue(NetworkTableType type, Object value, long time, long serverTime) { m_type = type; @@ -176,7 +176,6 @@ public final class NetworkTableValue { return out; } - @SuppressWarnings("PMD.AvoidArrayLoops") static double[] toNativeDoubleArray(Number[] arr) { double[] out = new double[arr.length]; for (int i = 0; i < arr.length; i++) { @@ -185,7 +184,6 @@ public final class NetworkTableValue { return out; } - @SuppressWarnings("PMD.AvoidArrayLoops") static long[] toNativeIntegerArray(Number[] arr) { long[] out = new long[arr.length]; for (int i = 0; i < arr.length; i++) { @@ -194,7 +192,6 @@ public final class NetworkTableValue { return out; } - @SuppressWarnings("PMD.AvoidArrayLoops") static float[] toNativeFloatArray(Number[] arr) { float[] out = new float[arr.length]; for (int i = 0; i < arr.length; i++) { diff --git a/ntcore/src/generate/main/java/Subscriber.java.jinja b/ntcore/src/generate/main/java/Subscriber.java.jinja index 73e6190379..c3531068c7 100644 --- a/ntcore/src/generate/main/java/Subscriber.java.jinja +++ b/ntcore/src/generate/main/java/Subscriber.java.jinja @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import {{ java.SupplierFunctionPackage|default('java.util.function') }}.{{ java.FunctionTypePrefix }}Supplier; /** NetworkTables {{ TypeName }} subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface {{ TypeName }}Subscriber extends Subscriber, {{ java.FunctionTypePrefix }}Supplier{{ java.FunctionTypeSuffix }} { /** * Get the corresponding topic. diff --git a/ntcore/src/generate/main/java/Timestamped.java.jinja b/ntcore/src/generate/main/java/Timestamped.java.jinja index 21e50e244f..0bbd74774e 100644 --- a/ntcore/src/generate/main/java/Timestamped.java.jinja +++ b/ntcore/src/generate/main/java/Timestamped.java.jinja @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables timestamped {{ TypeName }}. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") public final class Timestamped{{ TypeName }} { /** * Create a timestamped value. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanArrayEntryImpl.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanArrayEntryImpl.java index 40e455ccac..88ed6cb787 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanArrayEntryImpl.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanArrayEntryImpl.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables BooleanArray implementation. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") final class BooleanArrayEntryImpl extends EntryBase implements BooleanArrayEntry { /** * Constructor. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanArraySubscriber.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanArraySubscriber.java index ff07119840..479336cf2e 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanArraySubscriber.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanArraySubscriber.java @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.util.function.Supplier; /** NetworkTables BooleanArray subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface BooleanArraySubscriber extends Subscriber, Supplier { /** * Get the corresponding topic. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanEntryImpl.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanEntryImpl.java index f099afc0da..273bd5e2ed 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanEntryImpl.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanEntryImpl.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables Boolean implementation. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") final class BooleanEntryImpl extends EntryBase implements BooleanEntry { /** * Constructor. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanSubscriber.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanSubscriber.java index 7f54f4b3fd..b037bc0977 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanSubscriber.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/BooleanSubscriber.java @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.util.function.BooleanSupplier; /** NetworkTables Boolean subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface BooleanSubscriber extends Subscriber, BooleanSupplier { /** * Get the corresponding topic. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleArrayEntryImpl.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleArrayEntryImpl.java index 7bb270ac37..effce7a9b8 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleArrayEntryImpl.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleArrayEntryImpl.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables DoubleArray implementation. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") final class DoubleArrayEntryImpl extends EntryBase implements DoubleArrayEntry { /** * Constructor. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleArraySubscriber.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleArraySubscriber.java index a807d66efc..19f15f5c48 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleArraySubscriber.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleArraySubscriber.java @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.util.function.Supplier; /** NetworkTables DoubleArray subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface DoubleArraySubscriber extends Subscriber, Supplier { /** * Get the corresponding topic. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleEntryImpl.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleEntryImpl.java index 968686d502..579834a322 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleEntryImpl.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleEntryImpl.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables Double implementation. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") final class DoubleEntryImpl extends EntryBase implements DoubleEntry { /** * Constructor. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleSubscriber.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleSubscriber.java index 688f6eaed7..c8ec1d0051 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleSubscriber.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/DoubleSubscriber.java @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.util.function.DoubleSupplier; /** NetworkTables Double subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface DoubleSubscriber extends Subscriber, DoubleSupplier { /** * Get the corresponding topic. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatArrayEntryImpl.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatArrayEntryImpl.java index 1afe83728b..86753c4019 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatArrayEntryImpl.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatArrayEntryImpl.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables FloatArray implementation. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") final class FloatArrayEntryImpl extends EntryBase implements FloatArrayEntry { /** * Constructor. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatArraySubscriber.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatArraySubscriber.java index b70bece391..9e778d37b5 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatArraySubscriber.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatArraySubscriber.java @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.util.function.Supplier; /** NetworkTables FloatArray subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface FloatArraySubscriber extends Subscriber, Supplier { /** * Get the corresponding topic. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatEntryImpl.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatEntryImpl.java index f7efebfce4..ad0a1d3410 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatEntryImpl.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatEntryImpl.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables Float implementation. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") final class FloatEntryImpl extends EntryBase implements FloatEntry { /** * Constructor. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatSubscriber.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatSubscriber.java index 758463b89e..83696ae10a 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatSubscriber.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/FloatSubscriber.java @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import edu.wpi.first.util.function.FloatSupplier; /** NetworkTables Float subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface FloatSubscriber extends Subscriber, FloatSupplier { /** * Get the corresponding topic. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/GenericSubscriber.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/GenericSubscriber.java index 7d7ca9639b..35738f2300 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/GenericSubscriber.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/GenericSubscriber.java @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.util.function.Supplier; /** NetworkTables generic subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface GenericSubscriber extends Subscriber, Supplier { /** * Get the corresponding topic. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerArrayEntryImpl.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerArrayEntryImpl.java index e74f4893b9..d26d55f447 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerArrayEntryImpl.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerArrayEntryImpl.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables IntegerArray implementation. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") final class IntegerArrayEntryImpl extends EntryBase implements IntegerArrayEntry { /** * Constructor. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerArraySubscriber.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerArraySubscriber.java index cbb2e6fe81..c77ed10038 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerArraySubscriber.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerArraySubscriber.java @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.util.function.Supplier; /** NetworkTables IntegerArray subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface IntegerArraySubscriber extends Subscriber, Supplier { /** * Get the corresponding topic. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerEntryImpl.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerEntryImpl.java index a8db1bff9d..49b691c5e4 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerEntryImpl.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerEntryImpl.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables Integer implementation. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") final class IntegerEntryImpl extends EntryBase implements IntegerEntry { /** * Constructor. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerSubscriber.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerSubscriber.java index 81a9740ef7..bdeb65cc05 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerSubscriber.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/IntegerSubscriber.java @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.util.function.LongSupplier; /** NetworkTables Integer subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface IntegerSubscriber extends Subscriber, LongSupplier { /** * Get the corresponding topic. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/NetworkTableValue.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/NetworkTableValue.java index 78786bc6c7..780553c43e 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/NetworkTableValue.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/NetworkTableValue.java @@ -9,7 +9,7 @@ package edu.wpi.first.networktables; import java.util.Objects; /** A network table entry value. */ -@SuppressWarnings({"UnnecessaryParentheses", "PMD.MethodReturnsInternalArray"}) +@SuppressWarnings("UnnecessaryParentheses") public final class NetworkTableValue { NetworkTableValue(NetworkTableType type, Object value, long time, long serverTime) { m_type = type; @@ -668,7 +668,6 @@ public final class NetworkTableValue { return out; } - @SuppressWarnings("PMD.AvoidArrayLoops") static double[] toNativeDoubleArray(Number[] arr) { double[] out = new double[arr.length]; for (int i = 0; i < arr.length; i++) { @@ -677,7 +676,6 @@ public final class NetworkTableValue { return out; } - @SuppressWarnings("PMD.AvoidArrayLoops") static long[] toNativeIntegerArray(Number[] arr) { long[] out = new long[arr.length]; for (int i = 0; i < arr.length; i++) { @@ -686,7 +684,6 @@ public final class NetworkTableValue { return out; } - @SuppressWarnings("PMD.AvoidArrayLoops") static float[] toNativeFloatArray(Number[] arr) { float[] out = new float[arr.length]; for (int i = 0; i < arr.length; i++) { diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/RawEntryImpl.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/RawEntryImpl.java index 55767f73ea..ab8ca0e1f3 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/RawEntryImpl.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/RawEntryImpl.java @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.nio.ByteBuffer; /** NetworkTables Raw implementation. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") final class RawEntryImpl extends EntryBase implements RawEntry { /** * Constructor. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/RawSubscriber.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/RawSubscriber.java index 089d999dc2..cf8fc8636e 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/RawSubscriber.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/RawSubscriber.java @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.util.function.Supplier; /** NetworkTables Raw subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface RawSubscriber extends Subscriber, Supplier { /** * Get the corresponding topic. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringArrayEntryImpl.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringArrayEntryImpl.java index 536db7b8ac..d97f70b773 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringArrayEntryImpl.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringArrayEntryImpl.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables StringArray implementation. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") final class StringArrayEntryImpl extends EntryBase implements StringArrayEntry { /** * Constructor. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringArraySubscriber.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringArraySubscriber.java index 62a05759bf..3cd20f2360 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringArraySubscriber.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringArraySubscriber.java @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.util.function.Supplier; /** NetworkTables StringArray subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface StringArraySubscriber extends Subscriber, Supplier { /** * Get the corresponding topic. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringEntryImpl.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringEntryImpl.java index 76c9b98545..7780f4c832 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringEntryImpl.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringEntryImpl.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables String implementation. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") final class StringEntryImpl extends EntryBase implements StringEntry { /** * Constructor. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringSubscriber.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringSubscriber.java index 8c453b03a4..c11da81341 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringSubscriber.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/StringSubscriber.java @@ -9,7 +9,6 @@ package edu.wpi.first.networktables; import java.util.function.Supplier; /** NetworkTables String subscriber. */ -@SuppressWarnings("PMD.MissingOverride") public interface StringSubscriber extends Subscriber, Supplier { /** * Get the corresponding topic. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedBoolean.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedBoolean.java index 05497fcb3b..97b85e68a9 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedBoolean.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedBoolean.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables timestamped Boolean. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") public final class TimestampedBoolean { /** * Create a timestamped value. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedBooleanArray.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedBooleanArray.java index 51e2591291..0aec21ad59 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedBooleanArray.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedBooleanArray.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables timestamped BooleanArray. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") public final class TimestampedBooleanArray { /** * Create a timestamped value. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedDouble.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedDouble.java index 586c9fc1d1..7ca5f71c8e 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedDouble.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedDouble.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables timestamped Double. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") public final class TimestampedDouble { /** * Create a timestamped value. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedDoubleArray.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedDoubleArray.java index aaeafd788e..1d0beb6fda 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedDoubleArray.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedDoubleArray.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables timestamped DoubleArray. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") public final class TimestampedDoubleArray { /** * Create a timestamped value. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedFloat.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedFloat.java index 4d8aa095df..49cfa15ce7 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedFloat.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedFloat.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables timestamped Float. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") public final class TimestampedFloat { /** * Create a timestamped value. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedFloatArray.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedFloatArray.java index 85fe7bcac7..8f97ddd85e 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedFloatArray.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedFloatArray.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables timestamped FloatArray. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") public final class TimestampedFloatArray { /** * Create a timestamped value. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedInteger.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedInteger.java index 0ee7855363..bc518dae33 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedInteger.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedInteger.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables timestamped Integer. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") public final class TimestampedInteger { /** * Create a timestamped value. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedIntegerArray.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedIntegerArray.java index 8686326996..bb08a85c17 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedIntegerArray.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedIntegerArray.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables timestamped IntegerArray. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") public final class TimestampedIntegerArray { /** * Create a timestamped value. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedRaw.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedRaw.java index 12ec095e3f..8423d06e7b 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedRaw.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedRaw.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables timestamped Raw. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") public final class TimestampedRaw { /** * Create a timestamped value. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedString.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedString.java index a51432ee49..c033f3fefd 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedString.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedString.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables timestamped String. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") public final class TimestampedString { /** * Create a timestamped value. diff --git a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedStringArray.java b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedStringArray.java index 420a4685a9..b314fc9125 100644 --- a/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedStringArray.java +++ b/ntcore/src/generated/main/java/edu/wpi/first/networktables/TimestampedStringArray.java @@ -7,7 +7,6 @@ package edu.wpi.first.networktables; /** NetworkTables timestamped StringArray. */ -@SuppressWarnings("PMD.ArrayIsStoredDirectly") public final class TimestampedStringArray { /** * Create a timestamped value. diff --git a/ntcore/src/main/java/edu/wpi/first/networktables/NTSendable.java b/ntcore/src/main/java/edu/wpi/first/networktables/NTSendable.java index 641224d3fc..992cfffe7e 100644 --- a/ntcore/src/main/java/edu/wpi/first/networktables/NTSendable.java +++ b/ntcore/src/main/java/edu/wpi/first/networktables/NTSendable.java @@ -8,6 +8,7 @@ import edu.wpi.first.util.sendable.Sendable; import edu.wpi.first.util.sendable.SendableBuilder; /** Interface for NetworkTable Sendable objects. */ +@SuppressWarnings("PMD.ImplicitFunctionalInterface") public interface NTSendable extends Sendable { /** * Initializes this {@link Sendable} object. diff --git a/ntcore/src/test/java/edu/wpi/first/networktables/RawTest.java b/ntcore/src/test/java/edu/wpi/first/networktables/RawTest.java index 293d4437bd..871f6b0672 100644 --- a/ntcore/src/test/java/edu/wpi/first/networktables/RawTest.java +++ b/ntcore/src/test/java/edu/wpi/first/networktables/RawTest.java @@ -12,7 +12,6 @@ import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -@SuppressWarnings("PMD.SimplifiableTestAssertion") class RawTest { private NetworkTableInstance m_inst; diff --git a/shared/java/javacommon.gradle b/shared/java/javacommon.gradle index 3f82db58ed..dd94007785 100644 --- a/shared/java/javacommon.gradle +++ b/shared/java/javacommon.gradle @@ -72,6 +72,7 @@ publishing { } test { + jvmArgs '--enable-native-access=ALL-UNNAMED' useJUnitPlatform() systemProperty 'junit.jupiter.extensions.autodetection.enabled', 'true' testLogging { @@ -118,7 +119,7 @@ tasks.withType(JavaCompile).configureEach { } dependencies { - testImplementation 'org.junit.jupiter:junit-jupiter:5.10.1' + testImplementation 'org.junit.jupiter:junit-jupiter:5.13.4' testRuntimeOnly 'org.junit.platform:junit-platform-launcher' devImplementation sourceSets.main.output @@ -133,7 +134,7 @@ task run(type: JavaExec) { build.dependsOn devClasses jacoco { - toolVersion = "0.8.10" + toolVersion = "0.8.13" } jacocoTestReport { diff --git a/shared/java/javastyle.gradle b/shared/java/javastyle.gradle index e2b713e7e6..e81ad9967f 100644 --- a/shared/java/javastyle.gradle +++ b/shared/java/javastyle.gradle @@ -5,7 +5,7 @@ if (project.hasProperty('skipJavaFormat')) { apply plugin: 'checkstyle' checkstyle { - toolVersion = "10.12.2" + toolVersion = "11.0.0" configDirectory = file("${project.rootDir}/styleguide") config = resources.text.fromFile(new File(configDirectory.get().getAsFile(), "checkstyle.xml")) } @@ -13,7 +13,7 @@ checkstyle { apply plugin: 'pmd' pmd { - toolVersion = '7.2.0' + toolVersion = '7.16.0' consoleOutput = true reportsDir = file("$project.buildDir/reports/pmd") ruleSetFiles = files(new File(rootDir, "styleguide/pmd-ruleset.xml")) @@ -40,7 +40,7 @@ spotless { exclude '**/build/**', '**/build-*/**', '**/bin/**' } greclipse() - indentWithSpaces(4) + leadingTabsToSpaces(4) trimTrailingWhitespace() endWithNewline() } @@ -60,7 +60,7 @@ spotless { } eclipseWtp('xml') trimTrailingWhitespace() - indentWithSpaces(2) + leadingTabsToSpaces(2) endWithNewline() } format 'misc', { @@ -69,7 +69,7 @@ spotless { exclude '**/build/**', '**/build-*/**', '**/bin/**' } trimTrailingWhitespace() - indentWithSpaces(2) + leadingTabsToSpaces(2) endWithNewline() } } diff --git a/styleguide/pmd-ruleset.xml b/styleguide/pmd-ruleset.xml index 8553506b6f..4d3c46258e 100644 --- a/styleguide/pmd-ruleset.xml +++ b/styleguide/pmd-ruleset.xml @@ -6,8 +6,13 @@ PMD Ruleset for WPILib - .*/*JNI.* + + .*/*EntryImpl\.java + .*/*Subscriber\.java + .*/Timestamped.*\.java + .*/*IntegrationTests.* + .*/*JNI.* .*/math/proto.* @@ -18,18 +23,19 @@ - - - - - - + + - + + + + + + @@ -45,8 +51,8 @@ - + @@ -82,6 +88,7 @@ + diff --git a/styleguide/spotbugs-exclude.xml b/styleguide/spotbugs-exclude.xml index c5807cb459..084206b4e0 100644 --- a/styleguide/spotbugs-exclude.xml +++ b/styleguide/spotbugs-exclude.xml @@ -1,5 +1,45 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -30,12 +70,21 @@ + + + + - + @@ -49,50 +98,81 @@ - + + + + + - + - + - + - + - + - + - + - + + + + + + + + - + + + + + + + + + + + + + + + + + + + + + - + @@ -141,27 +221,11 @@ - - - - - - - - - - - - - - + + + diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelRaceGroup.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelRaceGroup.java index 36eaf27543..069f4a8162 100644 --- a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelRaceGroup.java +++ b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelRaceGroup.java @@ -42,7 +42,6 @@ public class ParallelRaceGroup extends Command { * * @param commands Commands to add to the group. */ - @SuppressWarnings("PMD.UseArraysAsList") public final void addCommands(Command... commands) { if (!m_finished) { throw new IllegalStateException( diff --git a/wpilibc/src/main/native/cpp/DigitalGlitchFilter.cpp b/wpilibc/src/main/native/cpp/DigitalGlitchFilter.cpp index 44bcabe463..be15e6ca98 100644 --- a/wpilibc/src/main/native/cpp/DigitalGlitchFilter.cpp +++ b/wpilibc/src/main/native/cpp/DigitalGlitchFilter.cpp @@ -39,6 +39,7 @@ DigitalGlitchFilter::~DigitalGlitchFilter() { if (m_channelIndex >= 0) { std::scoped_lock lock(m_mutex); m_filterAllocated[m_channelIndex] = false; + m_channelIndex = -1; } } diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16448_IMU.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16448_IMU.java index 008b17864f..8a2e6ba7d5 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16448_IMU.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16448_IMU.java @@ -29,7 +29,7 @@ import edu.wpi.first.util.sendable.SendableBuilder; // CHECKSTYLE.OFF: EmptyCatchBlock /** This class is for the ADIS16448 IMU that connects to the RoboRIO MXP port. */ -@SuppressWarnings({"PMD.RedundantFieldInitializer", "PMD.ImmutableField"}) +@SuppressWarnings({"PMD.RedundantFieldInitializer", "PMD.ImmutableField", "PMD.UnusedPrivateField"}) public class ADIS16448_IMU implements AutoCloseable, Sendable { // ADIS16448 Register Map Declaration private static final int FLASH_CNT = 0x00; // Flash memory write count diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16470_IMU.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16470_IMU.java index 0a957e3d65..27707b63e7 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16470_IMU.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16470_IMU.java @@ -20,7 +20,7 @@ import edu.wpi.first.util.sendable.SendableBuilder; // CHECKSTYLE.OFF: EmptyCatchBlock /** This class is for the ADIS16470 IMU that connects to the RoboRIO SPI port. */ -@SuppressWarnings("PMD.RedundantFieldInitializer") +@SuppressWarnings({"PMD.RedundantFieldInitializer", "PMD.UnusedPrivateField"}) public class ADIS16470_IMU implements AutoCloseable, Sendable { /* ADIS16470 Register Map Declaration */ private static final int FLASH_CNT = 0x00; // Flash memory write count diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Alert.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Alert.java index 828a3e3a21..ae791573e4 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Alert.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Alert.java @@ -8,6 +8,7 @@ import edu.wpi.first.util.sendable.Sendable; import edu.wpi.first.util.sendable.SendableBuilder; import edu.wpi.first.wpilibj.smartdashboard.SmartDashboard; import java.util.Comparator; +import java.util.EnumMap; import java.util.HashMap; import java.util.Map; import java.util.Set; @@ -186,7 +187,7 @@ public class Alert implements AutoCloseable { private static final class SendableAlerts implements Sendable { private static final Map groups = new HashMap(); - private final Map> m_alerts = new HashMap<>(); + private final EnumMap> m_alerts = new EnumMap<>(AlertType.class); /** * Returns a reference to the set of active alerts for the given type. diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalGlitchFilter.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalGlitchFilter.java index 9d3086e952..f87836e5d4 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalGlitchFilter.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalGlitchFilter.java @@ -38,11 +38,10 @@ public class DigitalGlitchFilter implements Sendable, AutoCloseable { m_mutex.lock(); try { m_filterAllocated[m_channelIndex] = false; + m_channelIndex = -1; } finally { m_mutex.unlock(); } - - m_channelIndex = -1; } } diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java index 36721e355a..befa01636c 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java @@ -285,7 +285,6 @@ public final class DriverStation { System.arraycopy(axes.m_axes, 0, m_prevAxes.m_axes, 0, count); } - @SuppressWarnings("PMD.AvoidArrayLoops") void appendPOVs(HALJoystickPOVs povs, long timestamp) { int count = povs.m_count; if (m_sizedPOVs == null || m_sizedPOVs.length != count) { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/GenericHID.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/GenericHID.java index ba48da1662..138d54c808 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/GenericHID.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/GenericHID.java @@ -70,7 +70,6 @@ public class GenericHID { /** HIDType value. */ public final int value; - @SuppressWarnings("PMD.UseConcurrentHashMap") private static final Map map = new HashMap<>(); HIDType(int value) { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/I2C.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/I2C.java index 1ed131b2c7..bc90e67043 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/I2C.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/I2C.java @@ -40,6 +40,7 @@ public class I2C implements AutoCloseable { private final int m_port; private final int m_deviceAddress; + private ByteBuffer m_readDataToSendBuffer; /** * Constructor. @@ -265,8 +266,6 @@ public class I2C implements AutoCloseable { return transaction(registerAddressArray, registerAddressArray.length, buffer, count); } - private ByteBuffer m_readDataToSendBuffer; - /** * Execute a read transaction with the device. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/RobotBase.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/RobotBase.java index e595a5899e..0cf6403196 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/RobotBase.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/RobotBase.java @@ -96,29 +96,36 @@ public abstract class RobotBase implements AutoCloseable { @Override public void reportUsage(MathUsageId id, int count) { switch (id) { - case kKinematics_DifferentialDrive -> HAL.report( - tResourceType.kResourceType_Kinematics, tInstances.kKinematics_DifferentialDrive); - case kKinematics_MecanumDrive -> HAL.report( - tResourceType.kResourceType_Kinematics, tInstances.kKinematics_MecanumDrive); - case kKinematics_SwerveDrive -> HAL.report( - tResourceType.kResourceType_Kinematics, tInstances.kKinematics_SwerveDrive); - case kTrajectory_TrapezoidProfile -> HAL.report( - tResourceType.kResourceType_TrapezoidProfile, count); + case kKinematics_DifferentialDrive -> + HAL.report( + tResourceType.kResourceType_Kinematics, + tInstances.kKinematics_DifferentialDrive); + case kKinematics_MecanumDrive -> + HAL.report( + tResourceType.kResourceType_Kinematics, tInstances.kKinematics_MecanumDrive); + case kKinematics_SwerveDrive -> + HAL.report( + tResourceType.kResourceType_Kinematics, tInstances.kKinematics_SwerveDrive); + case kTrajectory_TrapezoidProfile -> + HAL.report(tResourceType.kResourceType_TrapezoidProfile, count); case kFilter_Linear -> HAL.report(tResourceType.kResourceType_LinearFilter, count); - case kOdometry_DifferentialDrive -> HAL.report( - tResourceType.kResourceType_Odometry, tInstances.kOdometry_DifferentialDrive); - case kOdometry_SwerveDrive -> HAL.report( - tResourceType.kResourceType_Odometry, tInstances.kOdometry_SwerveDrive); - case kOdometry_MecanumDrive -> HAL.report( - tResourceType.kResourceType_Odometry, tInstances.kOdometry_MecanumDrive); - case kController_PIDController2 -> HAL.report( - tResourceType.kResourceType_PIDController2, count); - case kController_ProfiledPIDController -> HAL.report( - tResourceType.kResourceType_ProfiledPIDController, count); - case kController_BangBangController -> HAL.report( - tResourceType.kResourceType_BangBangController, count); - case kTrajectory_PathWeaver -> HAL.report( - tResourceType.kResourceType_PathWeaverTrajectory, count); + case kOdometry_DifferentialDrive -> + HAL.report( + tResourceType.kResourceType_Odometry, tInstances.kOdometry_DifferentialDrive); + case kOdometry_SwerveDrive -> + HAL.report( + tResourceType.kResourceType_Odometry, tInstances.kOdometry_SwerveDrive); + case kOdometry_MecanumDrive -> + HAL.report( + tResourceType.kResourceType_Odometry, tInstances.kOdometry_MecanumDrive); + case kController_PIDController2 -> + HAL.report(tResourceType.kResourceType_PIDController2, count); + case kController_ProfiledPIDController -> + HAL.report(tResourceType.kResourceType_ProfiledPIDController, count); + case kController_BangBangController -> + HAL.report(tResourceType.kResourceType_BangBangController, count); + case kTrajectory_PathWeaver -> + HAL.report(tResourceType.kResourceType_PathWeaverTrajectory, count); default -> { // NOP } diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SynchronousInterrupt.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SynchronousInterrupt.java index 449402c6cd..57d80c04dc 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SynchronousInterrupt.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SynchronousInterrupt.java @@ -16,7 +16,6 @@ import edu.wpi.first.hal.InterruptJNI; *

Asynchronous interrupts are handled by the AsynchronousInterrupt class. */ public class SynchronousInterrupt implements AutoCloseable { - @SuppressWarnings("PMD.SingularField") private final DigitalSource m_source; private final int m_handle; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Ultrasonic.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Ultrasonic.java index 14103544ce..f96ba47c8e 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Ultrasonic.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Ultrasonic.java @@ -44,7 +44,6 @@ public class Ultrasonic implements Sendable, AutoCloseable { private static Thread m_task; private static int m_instances; - @SuppressWarnings("PMD.SingularField") private SimDevice m_simDevice; private SimBoolean m_simRangeValid; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/LayoutType.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/LayoutType.java index 82ffcbef20..038539af42 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/LayoutType.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/LayoutType.java @@ -10,6 +10,7 @@ package edu.wpi.first.wpilibj.shuffleboard; * * @see BuiltInWidgets the built-in widget types */ +@SuppressWarnings("PMD.ImplicitFunctionalInterface") public interface LayoutType { /** * Gets the string type of the layout as defined by that layout in Shuffleboard. diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/WidgetType.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/WidgetType.java index 3033f8efc8..a1cfc8fcda 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/WidgetType.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/shuffleboard/WidgetType.java @@ -10,6 +10,7 @@ package edu.wpi.first.wpilibj.shuffleboard; * * @see BuiltInWidgets the built-in widget types */ +@SuppressWarnings("PMD.ImplicitFunctionalInterface") public interface WidgetType { /** * Gets the string type of the widget as defined by that widget in Shuffleboard. diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/CallbackStore.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/CallbackStore.java index 75bae9e767..c6ea362a44 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/CallbackStore.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/CallbackStore.java @@ -7,16 +7,19 @@ package edu.wpi.first.wpilibj.simulation; /** Manages simulation callbacks; each object is associated with a callback. */ public class CallbackStore implements AutoCloseable { /** Note: This interface is for simulation classes only. It should not be used by teams! */ + @SuppressWarnings("PMD.ImplicitFunctionalInterface") interface CancelCallbackFunc { void cancel(int index, int uid); } /** Note: This interface is for simulation classes only. It should not be used by teams! */ + @SuppressWarnings("PMD.ImplicitFunctionalInterface") interface CancelCallbackChannelFunc { void cancel(int index, int channel, int uid); } /** Note: This interface is for simulation classes only. It should not be used by teams! */ + @SuppressWarnings("PMD.ImplicitFunctionalInterface") interface CancelCallbackNoIndexFunc { void cancel(int uid); } diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableBuilderImpl.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableBuilderImpl.java index 09a16860e5..e05cb652c4 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableBuilderImpl.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableBuilderImpl.java @@ -58,7 +58,6 @@ import java.util.function.LongSupplier; import java.util.function.Supplier; /** Implementation detail for SendableBuilder. */ -@SuppressWarnings("PMD.CompareObjectsWithEquals") public class SendableBuilderImpl implements NTSendableBuilder { @FunctionalInterface private interface TimedConsumer { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SmartDashboard.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SmartDashboard.java index 81fbaa6c19..6e90a48696 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SmartDashboard.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SmartDashboard.java @@ -30,7 +30,6 @@ public final class SmartDashboard { /** * A table linking tables in the SmartDashboard to the {@link Sendable} objects they came from. */ - @SuppressWarnings("PMD.UseConcurrentHashMap") private static final Map tablesToData = new HashMap<>(); /** The executor for listener tasks; calls listener tasks synchronously from main thread. */ diff --git a/wpilibj/src/test/java/edu/wpi/first/wpilibj/AddressableLEDBufferTest.java b/wpilibj/src/test/java/edu/wpi/first/wpilibj/AddressableLEDBufferTest.java index 267cc293ca..c15f1dfb37 100644 --- a/wpilibj/src/test/java/edu/wpi/first/wpilibj/AddressableLEDBufferTest.java +++ b/wpilibj/src/test/java/edu/wpi/first/wpilibj/AddressableLEDBufferTest.java @@ -103,18 +103,21 @@ class AddressableLEDBufferTest { buffer.forEach( (index, r, g, b) -> { switch (index) { - case 0 -> assertAll( - () -> assertEquals(1, r, "red at index 0"), - () -> assertEquals(2, g, "green at index 0"), - () -> assertEquals(3, b, "blue at index 0")); - case 1 -> assertAll( - () -> assertEquals(4, r, "red at index 1"), - () -> assertEquals(5, g, "green at index 1"), - () -> assertEquals(6, b, "blue at index 1")); - case 2 -> assertAll( - () -> assertEquals(7, r, "red at index 2"), - () -> assertEquals(8, g, "green at index 2"), - () -> assertEquals(9, b, "blue at index 2")); + case 0 -> + assertAll( + () -> assertEquals(1, r, "red at index 0"), + () -> assertEquals(2, g, "green at index 0"), + () -> assertEquals(3, b, "blue at index 0")); + case 1 -> + assertAll( + () -> assertEquals(4, r, "red at index 1"), + () -> assertEquals(5, g, "green at index 1"), + () -> assertEquals(6, b, "blue at index 1")); + case 2 -> + assertAll( + () -> assertEquals(7, r, "red at index 2"), + () -> assertEquals(8, g, "green at index 2"), + () -> assertEquals(9, b, "blue at index 2")); default -> fail("Unexpected index " + index); } }); diff --git a/wpilibjExamples/build.gradle b/wpilibjExamples/build.gradle index 9bca5f3a39..a1e6a29151 100644 --- a/wpilibjExamples/build.gradle +++ b/wpilibjExamples/build.gradle @@ -27,12 +27,12 @@ dependencies { implementation project(':epilogue-runtime') annotationProcessor project(':epilogue-processor') - testImplementation 'org.junit.jupiter:junit-jupiter:5.10.1' + testImplementation 'org.junit.jupiter:junit-jupiter:5.13.4' testRuntimeOnly 'org.junit.platform:junit-platform-launcher' } jacoco { - toolVersion = "0.8.10" + toolVersion = "0.8.13" } jacocoTestReport { diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/commandbased/commands/ExampleCommand.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/commandbased/commands/ExampleCommand.java index 181de6dbb4..36f57ccabb 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/commandbased/commands/ExampleCommand.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/commandbased/commands/ExampleCommand.java @@ -9,7 +9,7 @@ import edu.wpi.first.wpilibj2.command.Command; /** An example command that uses an example subsystem. */ public class ExampleCommand extends Command { - @SuppressWarnings({"PMD.UnusedPrivateField", "PMD.SingularField"}) + @SuppressWarnings("PMD.UnusedPrivateField") private final ExampleSubsystem m_subsystem; /** diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/romicommandbased/commands/ExampleCommand.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/romicommandbased/commands/ExampleCommand.java index c05a53a272..62e8d0ca73 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/romicommandbased/commands/ExampleCommand.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/romicommandbased/commands/ExampleCommand.java @@ -9,7 +9,7 @@ import edu.wpi.first.wpilibj2.command.Command; /** An example command that uses an example subsystem. */ public class ExampleCommand extends Command { - @SuppressWarnings({"PMD.UnusedPrivateField", "PMD.SingularField"}) + @SuppressWarnings("PMD.UnusedPrivateField") private final RomiDrivetrain m_subsystem; /** diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/xrpcommandbased/commands/ExampleCommand.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/xrpcommandbased/commands/ExampleCommand.java index 27f759a8c7..6b352b939e 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/xrpcommandbased/commands/ExampleCommand.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/xrpcommandbased/commands/ExampleCommand.java @@ -9,7 +9,7 @@ import edu.wpi.first.wpilibj2.command.Command; /** An example command that uses an example subsystem. */ public class ExampleCommand extends Command { - @SuppressWarnings({"PMD.UnusedPrivateField", "PMD.SingularField"}) + @SuppressWarnings("PMD.UnusedPrivateField") private final XRPDrivetrain m_subsystem; /** diff --git a/wpimath/src/generate/main/java/Nat.java.jinja b/wpimath/src/generate/main/java/Nat.java.jinja index 66f06390c2..a65c3c912a 100644 --- a/wpimath/src/generate/main/java/Nat.java.jinja +++ b/wpimath/src/generate/main/java/Nat.java.jinja @@ -18,6 +18,7 @@ import edu.wpi.first.math.numbers.N{{ num }}; * * @param The {@link Num} this represents. */ +@SuppressWarnings("PMD.ImplicitFunctionalInterface") public interface Nat { /** * The number this interface represents. diff --git a/wpimath/src/generated/main/java/edu/wpi/first/math/Nat.java b/wpimath/src/generated/main/java/edu/wpi/first/math/Nat.java index f6b0b81250..f2647738a5 100644 --- a/wpimath/src/generated/main/java/edu/wpi/first/math/Nat.java +++ b/wpimath/src/generated/main/java/edu/wpi/first/math/Nat.java @@ -37,6 +37,7 @@ import edu.wpi.first.math.numbers.N20; * * @param The {@link Num} this represents. */ +@SuppressWarnings("PMD.ImplicitFunctionalInterface") public interface Nat { /** * The number this interface represents. diff --git a/wpimath/src/main/java/edu/wpi/first/math/interpolation/Interpolatable.java b/wpimath/src/main/java/edu/wpi/first/math/interpolation/Interpolatable.java index 9fe09fe475..186ed41841 100644 --- a/wpimath/src/main/java/edu/wpi/first/math/interpolation/Interpolatable.java +++ b/wpimath/src/main/java/edu/wpi/first/math/interpolation/Interpolatable.java @@ -11,6 +11,7 @@ package edu.wpi.first.math.interpolation; * * @param The class that is interpolatable. */ +@SuppressWarnings("PMD.ImplicitFunctionalInterface") public interface Interpolatable { /** * Return the interpolated value. This object is assumed to be the starting position, or lower diff --git a/wpimath/src/main/java/edu/wpi/first/math/spline/SplineHelper.java b/wpimath/src/main/java/edu/wpi/first/math/spline/SplineHelper.java index 2df70589c6..44f4fee85b 100644 --- a/wpimath/src/main/java/edu/wpi/first/math/spline/SplineHelper.java +++ b/wpimath/src/main/java/edu/wpi/first/math/spline/SplineHelper.java @@ -226,7 +226,7 @@ public final class SplineHelper { * @param splines An array of un-optimized quintic splines. * @return An array of optimized quintic splines. */ - @SuppressWarnings({"LocalVariableName", "PMD.AvoidInstantiatingObjectsInLoops"}) + @SuppressWarnings("LocalVariableName") public static QuinticHermiteSpline[] optimizeCurvature(QuinticHermiteSpline[] splines) { // If there's only spline in the array, we can't optimize anything so just return that. if (splines.length < 2) { diff --git a/wpiunits/src/generate/main/java/Measure-immutable.java.jinja b/wpiunits/src/generate/main/java/Measure-immutable.java.jinja index 526c950977..b4c11266b1 100644 --- a/wpiunits/src/generate/main/java/Measure-immutable.java.jinja +++ b/wpiunits/src/generate/main/java/Measure-immutable.java.jinja @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record Immutable{{ helpers['type_decl'](name) }}(double magnitude, double baseUnitMagnitude, {{ helpers['mtou'](name) }} unit) implements {{ helpers['type_usage'](name) }} { @Override public {{ helpers['type_usage'](name) }} copy() { diff --git a/wpiunits/src/generate/main/java/Measure-mutable.java.jinja b/wpiunits/src/generate/main/java/Measure-mutable.java.jinja index 8adf22f74d..ecc855418b 100644 --- a/wpiunits/src/generate/main/java/Measure-mutable.java.jinja +++ b/wpiunits/src/generate/main/java/Measure-mutable.java.jinja @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class Mut{{ helpers['type_decl'](name) }} extends MutableMeasureBase<{{ helpers['mtou'](name) }}, {{ helpers['type_usage'](name) }}, Mut{{ helpers['type_usage'](name) }}> implements {{ helpers['type_usage'](name) }} { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAcceleration.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAcceleration.java index ab6f0449bf..481ad454c6 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAcceleration.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAcceleration.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableAcceleration(double magnitude, double baseUnitMagnitude, AccelerationUnit unit) implements Acceleration { @Override public Acceleration copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngle.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngle.java index 352e19ea38..e15951a581 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngle.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngle.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableAngle(double magnitude, double baseUnitMagnitude, AngleUnit unit) implements Angle { @Override public Angle copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngularAcceleration.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngularAcceleration.java index 0c417e08c6..59b55b5e94 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngularAcceleration.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngularAcceleration.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableAngularAcceleration(double magnitude, double baseUnitMagnitude, AngularAccelerationUnit unit) implements AngularAcceleration { @Override public AngularAcceleration copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngularMomentum.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngularMomentum.java index 7d00dd669e..f4bda92003 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngularMomentum.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngularMomentum.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableAngularMomentum(double magnitude, double baseUnitMagnitude, AngularMomentumUnit unit) implements AngularMomentum { @Override public AngularMomentum copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngularVelocity.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngularVelocity.java index c692a116d5..2a8f7eb089 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngularVelocity.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableAngularVelocity.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableAngularVelocity(double magnitude, double baseUnitMagnitude, AngularVelocityUnit unit) implements AngularVelocity { @Override public AngularVelocity copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableCurrent.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableCurrent.java index 8710f57efe..2c529d90a4 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableCurrent.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableCurrent.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableCurrent(double magnitude, double baseUnitMagnitude, CurrentUnit unit) implements Current { @Override public Current copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableDimensionless.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableDimensionless.java index 455bd2b402..1043b052e1 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableDimensionless.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableDimensionless.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableDimensionless(double magnitude, double baseUnitMagnitude, DimensionlessUnit unit) implements Dimensionless { @Override public Dimensionless copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableDistance.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableDistance.java index f919782236..eff6a5ea0d 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableDistance.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableDistance.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableDistance(double magnitude, double baseUnitMagnitude, DistanceUnit unit) implements Distance { @Override public Distance copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableEnergy.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableEnergy.java index 7e443075b0..4978e60e0c 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableEnergy.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableEnergy.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableEnergy(double magnitude, double baseUnitMagnitude, EnergyUnit unit) implements Energy { @Override public Energy copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableForce.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableForce.java index 14f11ec7a1..e42f8a3d98 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableForce.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableForce.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableForce(double magnitude, double baseUnitMagnitude, ForceUnit unit) implements Force { @Override public Force copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableFrequency.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableFrequency.java index f9084ed569..c9f7b011c3 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableFrequency.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableFrequency.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableFrequency(double magnitude, double baseUnitMagnitude, FrequencyUnit unit) implements Frequency { @Override public Frequency copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableLinearAcceleration.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableLinearAcceleration.java index 3212588d05..05a400ff4e 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableLinearAcceleration.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableLinearAcceleration.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableLinearAcceleration(double magnitude, double baseUnitMagnitude, LinearAccelerationUnit unit) implements LinearAcceleration { @Override public LinearAcceleration copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableLinearMomentum.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableLinearMomentum.java index 0d7afd654b..404c33adb2 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableLinearMomentum.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableLinearMomentum.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableLinearMomentum(double magnitude, double baseUnitMagnitude, LinearMomentumUnit unit) implements LinearMomentum { @Override public LinearMomentum copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableLinearVelocity.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableLinearVelocity.java index 7373307d39..6453893b70 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableLinearVelocity.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableLinearVelocity.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableLinearVelocity(double magnitude, double baseUnitMagnitude, LinearVelocityUnit unit) implements LinearVelocity { @Override public LinearVelocity copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableMass.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableMass.java index c74ad2711a..d3eff5ab87 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableMass.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableMass.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableMass(double magnitude, double baseUnitMagnitude, MassUnit unit) implements Mass { @Override public Mass copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableMomentOfInertia.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableMomentOfInertia.java index ea903c7652..b593428cb6 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableMomentOfInertia.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableMomentOfInertia.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableMomentOfInertia(double magnitude, double baseUnitMagnitude, MomentOfInertiaUnit unit) implements MomentOfInertia { @Override public MomentOfInertia copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableMult.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableMult.java index fc69825ee4..7cdc8e9ea6 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableMult.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableMult.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableMult(double magnitude, double baseUnitMagnitude, MultUnit unit) implements Mult { @Override public Mult copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutablePer.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutablePer.java index 3d9ad1fe14..8a21ba5c54 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutablePer.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutablePer.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutablePer(double magnitude, double baseUnitMagnitude, PerUnit unit) implements Per { @Override public Per copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutablePower.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutablePower.java index 0c7ffc0d95..f5a55b3862 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutablePower.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutablePower.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutablePower(double magnitude, double baseUnitMagnitude, PowerUnit unit) implements Power { @Override public Power copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableResistance.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableResistance.java index 34b780e7d3..adcbd597ed 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableResistance.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableResistance.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableResistance(double magnitude, double baseUnitMagnitude, ResistanceUnit unit) implements Resistance { @Override public Resistance copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableTemperature.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableTemperature.java index e035d80922..71ebf5cfc5 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableTemperature.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableTemperature.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableTemperature(double magnitude, double baseUnitMagnitude, TemperatureUnit unit) implements Temperature { @Override public Temperature copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableTime.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableTime.java index 1230d92028..77a32c08f3 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableTime.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableTime.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableTime(double magnitude, double baseUnitMagnitude, TimeUnit unit) implements Time { @Override public Time copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableTorque.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableTorque.java index 7c756e75dc..177311a6b3 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableTorque.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableTorque.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableTorque(double magnitude, double baseUnitMagnitude, TorqueUnit unit) implements Torque { @Override public Torque copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableVelocity.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableVelocity.java index 89256f9d05..04d2f1b125 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableVelocity.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableVelocity.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableVelocity(double magnitude, double baseUnitMagnitude, VelocityUnit unit) implements Velocity { @Override public Velocity copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableVoltage.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableVoltage.java index ca5dfebbf3..2345859477 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableVoltage.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/ImmutableVoltage.java @@ -9,7 +9,7 @@ package edu.wpi.first.units.measure; import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public record ImmutableVoltage(double magnitude, double baseUnitMagnitude, VoltageUnit unit) implements Voltage { @Override public Voltage copy() { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAcceleration.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAcceleration.java index ed74009c45..b3191e2862 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAcceleration.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAcceleration.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutAcceleration extends MutableMeasureBase, Acceleration, MutAcceleration> implements Acceleration { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngle.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngle.java index ff356e33c2..45f7f2dc29 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngle.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngle.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutAngle extends MutableMeasureBase implements Angle { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngularAcceleration.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngularAcceleration.java index 8d7cecc803..065aa9cd2e 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngularAcceleration.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngularAcceleration.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutAngularAcceleration extends MutableMeasureBase implements AngularAcceleration { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngularMomentum.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngularMomentum.java index c7ee472622..9b716b3e11 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngularMomentum.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngularMomentum.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutAngularMomentum extends MutableMeasureBase implements AngularMomentum { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngularVelocity.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngularVelocity.java index d4083e179c..ba4465b720 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngularVelocity.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutAngularVelocity.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutAngularVelocity extends MutableMeasureBase implements AngularVelocity { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutCurrent.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutCurrent.java index 3dab503de2..c2e736a88d 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutCurrent.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutCurrent.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutCurrent extends MutableMeasureBase implements Current { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutDimensionless.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutDimensionless.java index 13ee3f6e8c..3f06defa28 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutDimensionless.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutDimensionless.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutDimensionless extends MutableMeasureBase implements Dimensionless { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutDistance.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutDistance.java index 35f1e3faa9..134ead958f 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutDistance.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutDistance.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutDistance extends MutableMeasureBase implements Distance { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutEnergy.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutEnergy.java index bd23cd1e9b..362547ab57 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutEnergy.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutEnergy.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutEnergy extends MutableMeasureBase implements Energy { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutForce.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutForce.java index da6c973164..73a1e2c2ea 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutForce.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutForce.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutForce extends MutableMeasureBase implements Force { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutFrequency.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutFrequency.java index 091afd130b..aa26c18124 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutFrequency.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutFrequency.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutFrequency extends MutableMeasureBase implements Frequency { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutLinearAcceleration.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutLinearAcceleration.java index dd074db5f8..34bf7d5cc7 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutLinearAcceleration.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutLinearAcceleration.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutLinearAcceleration extends MutableMeasureBase implements LinearAcceleration { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutLinearMomentum.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutLinearMomentum.java index da3113c345..0c95a0ad6f 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutLinearMomentum.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutLinearMomentum.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutLinearMomentum extends MutableMeasureBase implements LinearMomentum { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutLinearVelocity.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutLinearVelocity.java index ffd19e3a7e..ec7a66750b 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutLinearVelocity.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutLinearVelocity.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutLinearVelocity extends MutableMeasureBase implements LinearVelocity { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutMass.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutMass.java index c1b80c191e..f4aa4e7064 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutMass.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutMass.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutMass extends MutableMeasureBase implements Mass { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutMomentOfInertia.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutMomentOfInertia.java index b6f7481fa5..ee5135e183 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutMomentOfInertia.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutMomentOfInertia.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutMomentOfInertia extends MutableMeasureBase implements MomentOfInertia { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutMult.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutMult.java index b743c950fd..317a19bbc7 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutMult.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutMult.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutMult extends MutableMeasureBase, Mult, MutMult> implements Mult { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutPer.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutPer.java index 054d87f19b..76e4f7bb86 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutPer.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutPer.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutPer extends MutableMeasureBase, Per, MutPer> implements Per { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutPower.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutPower.java index 7a08663a7d..54daae6170 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutPower.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutPower.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutPower extends MutableMeasureBase implements Power { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutResistance.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutResistance.java index 6acee59f56..512f214dae 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutResistance.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutResistance.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutResistance extends MutableMeasureBase implements Resistance { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutTemperature.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutTemperature.java index 31ae1fe7b5..7105031e2a 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutTemperature.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutTemperature.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutTemperature extends MutableMeasureBase implements Temperature { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutTime.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutTime.java index 4b9b81a745..59b2808849 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutTime.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutTime.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutTime extends MutableMeasureBase implements Time { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutTorque.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutTorque.java index 30f9152329..b87e8453fb 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutTorque.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutTorque.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutTorque extends MutableMeasureBase implements Torque { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutVelocity.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutVelocity.java index 660cfa9de2..8bfb75879c 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutVelocity.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutVelocity.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutVelocity extends MutableMeasureBase, Velocity, MutVelocity> implements Velocity { diff --git a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutVoltage.java b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutVoltage.java index 7002767b9e..709c5b12b6 100644 --- a/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutVoltage.java +++ b/wpiunits/src/generated/main/java/edu/wpi/first/units/measure/MutVoltage.java @@ -10,7 +10,7 @@ import static edu.wpi.first.units.Units.*; import edu.wpi.first.units.*; import edu.wpi.first.units.mutable.MutableMeasureBase; -@SuppressWarnings({"unchecked", "cast", "checkstyle", "PMD"}) +@SuppressWarnings({"unchecked", "cast", "checkstyle"}) public final class MutVoltage extends MutableMeasureBase implements Voltage { diff --git a/wpiutil/src/main/java/edu/wpi/first/util/cleanup/ReflectionCleanup.java b/wpiutil/src/main/java/edu/wpi/first/util/cleanup/ReflectionCleanup.java index 0803028f40..bed453ef21 100644 --- a/wpiutil/src/main/java/edu/wpi/first/util/cleanup/ReflectionCleanup.java +++ b/wpiutil/src/main/java/edu/wpi/first/util/cleanup/ReflectionCleanup.java @@ -11,6 +11,7 @@ import java.lang.reflect.Field; * your `close` method, that will use reflection to find all `AutoCloseable` instance members and * close them. */ +@SuppressWarnings("PMD.ImplicitFunctionalInterface") public interface ReflectionCleanup extends AutoCloseable { /** * Default implementation that uses reflection to find all AutoCloseable fields not marked diff --git a/wpiutil/src/main/java/edu/wpi/first/util/sendable/Sendable.java b/wpiutil/src/main/java/edu/wpi/first/util/sendable/Sendable.java index ad1fe28d09..e593e48c2e 100644 --- a/wpiutil/src/main/java/edu/wpi/first/util/sendable/Sendable.java +++ b/wpiutil/src/main/java/edu/wpi/first/util/sendable/Sendable.java @@ -5,6 +5,7 @@ package edu.wpi.first.util.sendable; /** The base interface for objects that can be sent over the network. */ +@SuppressWarnings("PMD.ImplicitFunctionalInterface") public interface Sendable { /** * Initializes this {@link Sendable} object. diff --git a/wpiutil/src/main/java/edu/wpi/first/util/struct/StructGenerator.java b/wpiutil/src/main/java/edu/wpi/first/util/struct/StructGenerator.java index 24b2541e1c..e883d9da76 100644 --- a/wpiutil/src/main/java/edu/wpi/first/util/struct/StructGenerator.java +++ b/wpiutil/src/main/java/edu/wpi/first/util/struct/StructGenerator.java @@ -435,7 +435,6 @@ public final class StructGenerator { } int size = 0; - boolean failed = false; for (final E constant : enumVariants) { final String name = constant.name(); @@ -452,6 +451,8 @@ public final class StructGenerator { .filter(f -> !f.isEnumConstant() && !Modifier.isStatic(f.getModifiers())) .toList(); + boolean failed = false; + for (final Field field : enumFields) { final Class type = field.getType(); final String name = field.getName(); diff --git a/wpiutil/src/test/java/edu/wpi/first/util/cleanup/CleanupPoolTest.java b/wpiutil/src/test/java/edu/wpi/first/util/cleanup/CleanupPoolTest.java index a953a855e6..2906bf2f9f 100644 --- a/wpiutil/src/test/java/edu/wpi/first/util/cleanup/CleanupPoolTest.java +++ b/wpiutil/src/test/java/edu/wpi/first/util/cleanup/CleanupPoolTest.java @@ -87,7 +87,6 @@ class CleanupPoolTest { } @Test - @SuppressWarnings("PMD.AvoidCatchingGenericException") void cleanupStackWithExceptionInCloseWorks() { List objects = new ArrayList<>(); objects.add(new AutoCloseableObject());