Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-07-05 03:21:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpimath] Replace Speeds with Velocities (#8479)

Browse Source 
I left "free speed" alone since that's the technical term for it. In
general, velocity is a vector quantity, and speed is a magnitude (i.e.,
a strictly positive value).

This PR also replaces the speed verbiage in MotorController with duty
cycle.

Fixes #8423.
This commit is contained in:
Tyler Veness
2026-03-06 14:19:15 -08:00
committed by GitHub
parent 1e39f39128
commit 9bd9656871
594 changed files with 8073 additions and 7875 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
wpilibc/src/main/native/cpp/simulation/PWMMotorControllerSim.cpp
View File

@@ -6,7 +6,6 @@
#include "wpi/hal/SimDevice.h"
#include "wpi/simulation/SimDeviceSim.hpp"
#include "wpi/units/length.hpp"
using namespace wpi;
using namespace wpi::sim;
@@ -17,9 +16,9 @@ PWMMotorControllerSim::PWMMotorControllerSim(
PWMMotorControllerSim::PWMMotorControllerSim(int channel) {
wpi::sim::SimDeviceSim deviceSim{"PWMMotorController", channel};
m_simSpeed = deviceSim.GetDouble("Speed");
m_simDutyCycle = deviceSim.GetDouble("DutyCycle");
}
double PWMMotorControllerSim::GetSpeed() const {
return m_simSpeed.Get();
double PWMMotorControllerSim::GetDutyCycle() const {
return m_simDutyCycle.Get();
}