Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Value: Disambiguate std::string&& and StringRef.

Browse Source 
Making the former a template causes the compiler to prefer the latter
when given a bare C string.
This commit is contained in:
Peter Johnson
2015-07-22 22:08:13 -07:00
parent 4c14f7823a
commit 9c204533e8
3 changed files with 22 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/unit/ValueTest.cpp
View File

@@ -62,7 +62,7 @@ TEST_F(ValueTest, Double) {
}
TEST_F(ValueTest, String) {
auto v = Value::MakeString(llvm::StringRef("hello"));
auto v = Value::MakeString("hello");
ASSERT_EQ(NT_STRING, v->type());
ASSERT_EQ("hello", v->GetString());
NT_Value cv;
@@ -72,7 +72,7 @@ TEST_F(ValueTest, String) {
ASSERT_EQ(llvm::StringRef("hello"), cv.data.v_string.str);
ASSERT_EQ(5u, cv.data.v_string.len);
v = Value::MakeString(llvm::StringRef("goodbye"));
v = Value::MakeString("goodbye");
ASSERT_EQ(NT_STRING, v->type());
ASSERT_EQ("goodbye", v->GetString());
ConvertToC(*v, &cv);
@@ -84,7 +84,7 @@ TEST_F(ValueTest, String) {
}
TEST_F(ValueTest, Raw) {
auto v = Value::MakeRaw(llvm::StringRef("hello"));
auto v = Value::MakeRaw("hello");
ASSERT_EQ(NT_RAW, v->type());
ASSERT_EQ("hello", v->GetRaw());
NT_Value cv;
@@ -94,7 +94,7 @@ TEST_F(ValueTest, Raw) {
ASSERT_EQ(llvm::StringRef("hello"), cv.data.v_string.str);
ASSERT_EQ(5u, cv.data.v_string.len);
v = Value::MakeRaw(llvm::StringRef("goodbye"));
v = Value::MakeRaw("goodbye");
ASSERT_EQ(NT_RAW, v->type());
ASSERT_EQ("goodbye", v->GetRaw());
ConvertToC(*v, &cv);
@@ -282,12 +282,12 @@ TEST_F(ValueTest, DoubleComparison) {
}
TEST_F(ValueTest, StringComparison) {
auto v1 = Value::MakeString(llvm::StringRef("hello"));
auto v2 = Value::MakeString(llvm::StringRef("hello"));
auto v1 = Value::MakeString("hello");
auto v2 = Value::MakeString("hello");
ASSERT_EQ(*v1, *v2);
v2 = Value::MakeString(llvm::StringRef("world")); // different contents
v2 = Value::MakeString("world"); // different contents
ASSERT_NE(*v1, *v2);
v2 = Value::MakeString(llvm::StringRef("goodbye")); // different size
v2 = Value::MakeString("goodbye"); // different size
ASSERT_NE(*v1, *v2);
}