Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ntcore] Catch file open error when saving preferences (#4571)

Browse Source
This commit is contained in:
Peter Johnson
2022-11-05 21:16:39 -07:00
committed by GitHub
parent 5005e2ca04
commit 9d1ce6a6d9
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
ntcore/src/main/native/cpp/NetworkServer.cpp
View File

@@ -111,6 +111,7 @@ class NSImpl {
void HandleLocal();
void LoadPersistent();
void SavePersistent(std::string_view filename, std::string_view data);
void Init();
void AddConnection(ServerConnection* conn, const ConnectionInfo& info);
void RemoveConnection(ServerConnection* conn);
@@ -372,11 +373,16 @@ void NSImpl::LoadPersistent() {
}
}
static void SavePersistent(std::string_view filename, std::string_view data) {
void NSImpl::SavePersistent(std::string_view filename, std::string_view data) {
// write to temporary file
auto tmp = fmt::format("{}.tmp", filename);
std::error_code ec;
wpi::raw_fd_ostream os{tmp, ec, fs::F_Text};
if (ec.value() != 0) {
INFO("could not open persistent file '{}' for write: {}", tmp,
ec.message());
return;
}
os << data;
os.close();
if (os.has_error()) {
@@ -414,9 +420,8 @@ void NSImpl::Init() {
if (m_serverImpl.PersistentChanged()) {
uv::QueueWork(
m_loop,
[fn = m_persistentFilename, data = m_serverImpl.DumpPersistent()] {
SavePersistent(fn, data);
},
[this, fn = m_persistentFilename,
data = m_serverImpl.DumpPersistent()] { SavePersistent(fn, data); },
nullptr);
}
});