Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-21 01:01:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ntcore] Fix null deref in NT3 client (#4530)

Browse Source
This commit is contained in:
Peter Johnson
2022-10-27 21:56:15 -07:00
committed by GitHub
parent 648ab6115c
commit 9e22ffbebf
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ntcore/src/main/native/cpp/NetworkClient.cpp
View File

@@ -242,7 +242,9 @@ NCImpl3::~NCImpl3() {
void NCImpl3::HandleLocal() {
m_localQueue.ReadQueue(&m_localMsgs);
m_clientImpl->HandleLocal(m_localMsgs);
if (m_clientImpl) {
m_clientImpl->HandleLocal(m_localMsgs);
}
}
void NCImpl3::TcpConnected(uv::Tcp& tcp) {
@@ -354,8 +356,10 @@ NCImpl4::NCImpl4(int inst, std::string_view id,
// set up flush async
m_flush = uv::Async<>::Create(m_loop);
m_flush->wakeup.connect([this] {
HandleLocal();
m_clientImpl->SendValues(m_loop.Now().count());
if (m_clientImpl) {
HandleLocal();
m_clientImpl->SendValues(m_loop.Now().count());
}
});
m_flushAtomic = m_flush.get();