Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-22 01:11:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up Java warning suppressions (#4433)

Browse Source 
Checkstyle naming conventions were changed to allow most of what's in
wpimath. Naming rules were disabled completely in wpimath since almost
all suppressions are for math notation.
This commit is contained in:
Tyler Veness
2022-09-24 00:13:55 -07:00
committed by GitHub
parent 17f504f548
commit a791470de7
233 changed files with 282 additions and 881 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/MecanumControllerCommand.java
View File

@@ -38,7 +38,6 @@ import java.util.function.Supplier;
*
* <p>This class is provided by the NewCommands VendorDep
*/
@SuppressWarnings("MemberName")
public class MecanumControllerCommand extends CommandBase {
private final Timer m_timer = new Timer();
private final boolean m_usePID;
@@ -87,7 +86,6 @@ public class MecanumControllerCommand extends CommandBase {
* voltages.
* @param requirements The subsystems to require.
*/
@SuppressWarnings("ParameterName")
public MecanumControllerCommand(
Trajectory trajectory,
Supplier<Pose2d> pose,
@@ -179,7 +177,6 @@ public class MecanumControllerCommand extends CommandBase {
* voltages.
* @param requirements The subsystems to require.
*/
@SuppressWarnings("ParameterName")
public MecanumControllerCommand(
Trajectory trajectory,
Supplier<Pose2d> pose,
@@ -236,7 +233,6 @@ public class MecanumControllerCommand extends CommandBase {
* @param outputWheelSpeeds A MecanumDriveWheelSpeeds object containing the output wheel speeds.
* @param requirements The subsystems to require.
*/
@SuppressWarnings("ParameterName")
public MecanumControllerCommand(
Trajectory trajectory,
Supplier<Pose2d> pose,
@@ -308,7 +304,6 @@ public class MecanumControllerCommand extends CommandBase {
* @param outputWheelSpeeds A MecanumDriveWheelSpeeds object containing the output wheel speeds.
* @param requirements The subsystems to require.
*/
@SuppressWarnings("ParameterName")
public MecanumControllerCommand(
Trajectory trajectory,
Supplier<Pose2d> pose,
@@ -350,7 +345,6 @@ public class MecanumControllerCommand extends CommandBase {
}
@Override
@SuppressWarnings("LocalVariableName")
public void execute() {
double curTime = m_timer.get();
double dt = curTime - m_prevTime;

4
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/SwerveControllerCommand.java
View File

@@ -31,7 +31,6 @@ import java.util.function.Supplier;
*
* <p>This class is provided by the NewCommands VendorDep
*/
@SuppressWarnings("MemberName")
public class SwerveControllerCommand extends CommandBase {
private final Timer m_timer = new Timer();
private final Trajectory m_trajectory;
@@ -61,7 +60,6 @@ public class SwerveControllerCommand extends CommandBase {
* @param outputModuleStates The raw output module states from the position controllers.
* @param requirements The subsystems to require.
*/
@SuppressWarnings("ParameterName")
public SwerveControllerCommand(
Trajectory trajectory,
Supplier<Pose2d> pose,
@@ -114,7 +112,6 @@ public class SwerveControllerCommand extends CommandBase {
* @param outputModuleStates The raw output module states from the position controllers.
* @param requirements The subsystems to require.
*/
@SuppressWarnings("ParameterName")
public SwerveControllerCommand(
Trajectory trajectory,
Supplier<Pose2d> pose,
@@ -144,7 +141,6 @@ public class SwerveControllerCommand extends CommandBase {
}
@Override
@SuppressWarnings("LocalVariableName")
public void execute() {
double curTime = m_timer.get();
var desiredState = m_trajectory.sample(curTime);