mirror of
https://github.com/wpilibsuite/allwpilib
synced 2026-06-22 01:11:42 +00:00
Applies Google Styleguide to Java parts of the library (#23)
This was partially applied to simulation but simulation is a bit of a mess and has a lot of duplicated code.
This commit is contained in:
Jonathan Leitschuh
committed by
Peter Johnson
Peter Johnson
parent
64ab6e51fe
commit
a834fff7b2
@@ -7,9 +7,8 @@
|
||||
|
||||
package edu.wpi.first.wpilibj;
|
||||
|
||||
import static org.junit.Assert.assertEquals;
|
||||
import static org.junit.Assert.assertFalse;
|
||||
import static org.junit.Assert.assertTrue;
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
|
||||
import java.io.File;
|
||||
import java.io.FileOutputStream;
|
||||
@@ -17,22 +16,24 @@ import java.io.IOException;
|
||||
import java.io.OutputStream;
|
||||
import java.util.logging.Logger;
|
||||
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
|
||||
import edu.wpi.first.wpilibj.networktables.NetworkTable;
|
||||
import edu.wpi.first.wpilibj.test.AbstractComsSetup;
|
||||
|
||||
import static org.junit.Assert.assertEquals;
|
||||
import static org.junit.Assert.assertFalse;
|
||||
import static org.junit.Assert.assertTrue;
|
||||
|
||||
/**
|
||||
* @author jonathanleitschuh
|
||||
* Tests the {@link Preferences}.
|
||||
*
|
||||
* @author jonathanleitschuh
|
||||
*/
|
||||
public class PreferencesTest extends AbstractComsSetup {
|
||||
private static final Logger logger = Logger.getLogger(PreferencesTest.class.getName());
|
||||
|
||||
private NetworkTable prefTable;
|
||||
private Preferences pref;
|
||||
private long check;
|
||||
private NetworkTable m_prefTable;
|
||||
private Preferences m_pref;
|
||||
private long m_check;
|
||||
|
||||
@Override
|
||||
protected Logger getClassLogger() {
|
||||
@@ -40,9 +41,6 @@ public class PreferencesTest extends AbstractComsSetup {
|
||||
}
|
||||
|
||||
|
||||
/**
|
||||
* @throws java.lang.Exception
|
||||
*/
|
||||
@Before
|
||||
public void setUp() throws Exception {
|
||||
NetworkTable.shutdown();
|
||||
@@ -55,70 +53,75 @@ public class PreferencesTest extends AbstractComsSetup {
|
||||
file.createNewFile();
|
||||
OutputStream output = new FileOutputStream(file);
|
||||
output
|
||||
.write("[NetworkTables Storage 3.0]\ndouble \"/Preferences/checkedValueInt\"=2\ndouble \"/Preferences/checkedValueDouble\"=.2\ndouble \"/Preferences/checkedValueFloat\"=3.14\ndouble \"/Preferences/checkedValueLong\"=172\nstring \"/Preferences/checkedValueString\"=\"hello \\nHow are you ?\"\nboolean \"/Preferences/checkedValueBoolean\"=false\n"
|
||||
.write(("[NetworkTables Storage 3.0]\ndouble \"/Preferences/checkedValueInt\"=2\ndouble "
|
||||
+ "\"/Preferences/checkedValueDouble\"=.2\ndouble "
|
||||
+ "\"/Preferences/checkedValueFloat\"=3.14\ndouble "
|
||||
+ "\"/Preferences/checkedValueLong\"=172\nstring "
|
||||
+ "\"/Preferences/checkedValueString\"=\"hello \\nHow are you ?\"\nboolean "
|
||||
+ "\"/Preferences/checkedValueBoolean\"=false\n")
|
||||
.getBytes());
|
||||
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace();
|
||||
} catch (IOException ex) {
|
||||
ex.printStackTrace();
|
||||
}
|
||||
NetworkTable.initialize();
|
||||
|
||||
pref = Preferences.getInstance();
|
||||
prefTable = NetworkTable.getTable("Preferences");
|
||||
check = System.currentTimeMillis();
|
||||
m_pref = Preferences.getInstance();
|
||||
m_prefTable = NetworkTable.getTable("Preferences");
|
||||
m_check = System.currentTimeMillis();
|
||||
}
|
||||
|
||||
|
||||
public void remove() {
|
||||
pref.remove("checkedValueLong");
|
||||
pref.remove("checkedValueDouble");
|
||||
pref.remove("checkedValueString");
|
||||
pref.remove("checkedValueInt");
|
||||
pref.remove("checkedValueFloat");
|
||||
pref.remove("checkedValueBoolean");
|
||||
protected void remove() {
|
||||
m_pref.remove("checkedValueLong");
|
||||
m_pref.remove("checkedValueDouble");
|
||||
m_pref.remove("checkedValueString");
|
||||
m_pref.remove("checkedValueInt");
|
||||
m_pref.remove("checkedValueFloat");
|
||||
m_pref.remove("checkedValueBoolean");
|
||||
}
|
||||
|
||||
public void addCheckedValue() {
|
||||
pref.putLong("checkedValueLong", check);
|
||||
pref.putDouble("checkedValueDouble", 1);
|
||||
pref.putString("checkedValueString", "checked");
|
||||
pref.putInt("checkedValueInt", 1);
|
||||
pref.putFloat("checkedValueFloat", 1);
|
||||
pref.putBoolean("checkedValueBoolean", true);
|
||||
protected void addCheckedValue() {
|
||||
m_pref.putLong("checkedValueLong", m_check);
|
||||
m_pref.putDouble("checkedValueDouble", 1);
|
||||
m_pref.putString("checkedValueString", "checked");
|
||||
m_pref.putInt("checkedValueInt", 1);
|
||||
m_pref.putFloat("checkedValueFloat", 1);
|
||||
m_pref.putBoolean("checkedValueBoolean", true);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testAddRemoveSave() {
|
||||
assertEquals(pref.getLong("checkedValueLong", 0), 172L);
|
||||
assertEquals(pref.getDouble("checkedValueDouble", 0), .2, 0);
|
||||
assertEquals(pref.getString("checkedValueString", ""), "hello \nHow are you ?");
|
||||
assertEquals(pref.getInt("checkedValueInt", 0), 2);
|
||||
assertEquals(pref.getFloat("checkedValueFloat", 0), 3.14, .001);
|
||||
assertFalse(pref.getBoolean("checkedValueBoolean", true));
|
||||
assertEquals(m_pref.getLong("checkedValueLong", 0), 172L);
|
||||
assertEquals(m_pref.getDouble("checkedValueDouble", 0), .2, 0);
|
||||
assertEquals(m_pref.getString("checkedValueString", ""), "hello \nHow are you ?");
|
||||
assertEquals(m_pref.getInt("checkedValueInt", 0), 2);
|
||||
assertEquals(m_pref.getFloat("checkedValueFloat", 0), 3.14, .001);
|
||||
assertFalse(m_pref.getBoolean("checkedValueBoolean", true));
|
||||
remove();
|
||||
assertEquals(pref.getLong("checkedValueLong", 0), 0);
|
||||
assertEquals(pref.getDouble("checkedValueDouble", 0), 0, 0);
|
||||
assertEquals(pref.getString("checkedValueString", ""), "");
|
||||
assertEquals(pref.getInt("checkedValueInt", 0), 0);
|
||||
assertEquals(pref.getFloat("checkedValueFloat", 0), 0, 0);
|
||||
assertFalse(pref.getBoolean("checkedValueBoolean", false));
|
||||
assertEquals(m_pref.getLong("checkedValueLong", 0), 0);
|
||||
assertEquals(m_pref.getDouble("checkedValueDouble", 0), 0, 0);
|
||||
assertEquals(m_pref.getString("checkedValueString", ""), "");
|
||||
assertEquals(m_pref.getInt("checkedValueInt", 0), 0);
|
||||
assertEquals(m_pref.getFloat("checkedValueFloat", 0), 0, 0);
|
||||
assertFalse(m_pref.getBoolean("checkedValueBoolean", false));
|
||||
addCheckedValue();
|
||||
pref.save();
|
||||
assertEquals(check, pref.getLong("checkedValueLong", 0));
|
||||
assertEquals(pref.getDouble("checkedValueDouble", 0), 1, 0);
|
||||
assertEquals(pref.getString("checkedValueString", ""), "checked");
|
||||
assertEquals(pref.getInt("checkedValueInt", 0), 1);
|
||||
assertEquals(pref.getFloat("checkedValueFloat", 0), 1, 0);
|
||||
assertTrue(pref.getBoolean("checkedValueBoolean", false));
|
||||
m_pref.save();
|
||||
assertEquals(m_check, m_pref.getLong("checkedValueLong", 0));
|
||||
assertEquals(m_pref.getDouble("checkedValueDouble", 0), 1, 0);
|
||||
assertEquals(m_pref.getString("checkedValueString", ""), "checked");
|
||||
assertEquals(m_pref.getInt("checkedValueInt", 0), 1);
|
||||
assertEquals(m_pref.getFloat("checkedValueFloat", 0), 1, 0);
|
||||
assertTrue(m_pref.getBoolean("checkedValueBoolean", false));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testPreferencesToNetworkTables() {
|
||||
String networkedNumber = "networkCheckedValue";
|
||||
int networkNumberValue = 100;
|
||||
pref.putInt(networkedNumber, networkNumberValue);
|
||||
assertEquals(networkNumberValue, (int)(prefTable.getNumber(networkedNumber)));
|
||||
pref.remove(networkedNumber);
|
||||
m_pref.putInt(networkedNumber, networkNumberValue);
|
||||
assertEquals(networkNumberValue, (int) (m_prefTable.getNumber(networkedNumber)));
|
||||
m_pref.remove(networkedNumber);
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user