Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[hal] Rename SimDevice constants to all caps

Browse Source 
Also use enum class for SimDevice C++ wrapper.
This commit is contained in:
Peter Johnson
2026-03-14 12:57:37 -07:00
parent 70f77a1f8e
commit aad08b9ad1
29 changed files with 145 additions and 131 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
simulation/halsim_gui/src/main/native/cpp/SimDeviceGui.cpp
View File

@@ -151,7 +151,7 @@ static void DisplaySimValue(const char* name, void* data,
switch (value->type) {
case HAL_BOOLEAN: {
bool v = value->data.v_boolean;
if (wpi::glass::DeviceBoolean(name, direction == HAL_SimValueOutput, &v,
if (wpi::glass::DeviceBoolean(name, direction == HAL_SIM_VALUE_OUTPUT, &v,
model->GetSource(handle))) {
valueCopy.data.v_boolean = v ? 1 : 0;
HAL_SetSimValue(handle, valueCopy);
@@ -159,7 +159,7 @@ static void DisplaySimValue(const char* name, void* data,
break;
}
case HAL_DOUBLE:
if (wpi::glass::DeviceDouble(name, direction == HAL_SimValueOutput,
if (wpi::glass::DeviceDouble(name, direction == HAL_SIM_VALUE_OUTPUT,
&valueCopy.data.v_double,
model->GetSource(handle))) {
HAL_SetSimValue(handle, valueCopy);
@@ -168,7 +168,7 @@ static void DisplaySimValue(const char* name, void* data,
case HAL_ENUM: {
int32_t numOptions = 0;
const char** options = HALSIM_GetSimValueEnumOptions(handle, &numOptions);
if (wpi::glass::DeviceEnum(name, direction == HAL_SimValueOutput,
if (wpi::glass::DeviceEnum(name, direction == HAL_SIM_VALUE_OUTPUT,
&valueCopy.data.v_enum, options, numOptions,
model->GetSource(handle))) {
HAL_SetSimValue(handle, valueCopy);
@@ -176,14 +176,14 @@ static void DisplaySimValue(const char* name, void* data,
break;
}
case HAL_INT:
if (wpi::glass::DeviceInt(name, direction == HAL_SimValueOutput,
if (wpi::glass::DeviceInt(name, direction == HAL_SIM_VALUE_OUTPUT,
&valueCopy.data.v_int,
model->GetSource(handle))) {
HAL_SetSimValue(handle, valueCopy);
}
break;
case HAL_LONG:
if (wpi::glass::DeviceLong(name, direction == HAL_SimValueOutput,
if (wpi::glass::DeviceLong(name, direction == HAL_SIM_VALUE_OUTPUT,
&valueCopy.data.v_long,
model->GetSource(handle))) {
HAL_SetSimValue(handle, valueCopy);

6
simulation/halsim_ws_core/src/main/native/cpp/WSProvider_SimDevice.cpp
View File

@@ -133,13 +133,13 @@ void HALSimWSProviderSimDevice::OnValueCreated(const char* name,
const char* prefix = "";
if (name[0] != '<' && name[0] != '>') {
switch (direction) {
case HAL_SimValueInput:
case HAL_SIM_VALUE_INPUT:
prefix = ">";
break;
case HAL_SimValueOutput:
case HAL_SIM_VALUE_OUTPUT:
prefix = "<";
break;
case HAL_SimValueBidir:
case HAL_SIM_VALUE_BIDIR:
prefix = "<>";
break;
default: