Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpimath] Remove unit suffixes from variable names (#7529)

Browse Source 
* Move units into API docs instead because suffixes make user code verbose and hard to read
* Rename trackWidth to trackwidth
* Make ultrasonic classes use meters instead of a mix of m, cm, mm, ft,
  and inches
This commit is contained in:
Tyler Veness
2025-02-10 07:23:04 -08:00
committed by GitHub
parent 764ada9b66
commit ac1705ae2b
250 changed files with 2953 additions and 3584 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
wpimath/src/main/native/cpp/kinematics/proto/DifferentialDriveKinematicsProto.cpp
View File

@@ -14,14 +14,14 @@ wpi::Protobuf<frc::DifferentialDriveKinematics>::Unpack(InputStream& stream) {
}
return frc::DifferentialDriveKinematics{
units::meter_t{msg.track_width},
units::meter_t{msg.trackwidth},
};
}
bool wpi::Protobuf<frc::DifferentialDriveKinematics>::Pack(
OutputStream& stream, const frc::DifferentialDriveKinematics& value) {
wpi_proto_ProtobufDifferentialDriveKinematics msg{
.track_width = value.trackWidth.value(),
.trackwidth = value.trackwidth.value(),
};
return stream.Encode(msg);
}

6
wpimath/src/main/native/cpp/kinematics/struct/DifferentialDriveKinematicsStruct.cpp
View File

@@ -5,7 +5,7 @@
#include "frc/kinematics/struct/DifferentialDriveKinematicsStruct.h"
namespace {
constexpr size_t kTrackWidthOff = 0;
constexpr size_t kTrackwidthOff = 0;
} // namespace
using StructType = wpi::Struct<frc::DifferentialDriveKinematics>;
@@ -13,11 +13,11 @@ using StructType = wpi::Struct<frc::DifferentialDriveKinematics>;
frc::DifferentialDriveKinematics StructType::Unpack(
std::span<const uint8_t> data) {
return frc::DifferentialDriveKinematics{
units::meter_t{wpi::UnpackStruct<double, kTrackWidthOff>(data)},
units::meter_t{wpi::UnpackStruct<double, kTrackwidthOff>(data)},
};
}
void StructType::Pack(std::span<uint8_t> data,
const frc::DifferentialDriveKinematics& value) {
wpi::PackStruct<kTrackWidthOff>(data, value.trackWidth.value());
wpi::PackStruct<kTrackwidthOff>(data, value.trackwidth.value());
}