Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use stricter C++ type conversions (#4357)

Browse Source 
Now, implicit narrowing conversions are only used with wpi::Now(). This
also fixes clang-tidy warnings about C-style casts. For example:
```
== clang-tidy /__w/allwpilib/allwpilib/wpilibNewCommands/src/main/native/include/frc2/command/SwerveControllerCommand.inc ==
/__w/allwpilib/allwpilib/wpilibNewCommands/src/main/native/include/frc2/command/SwerveControllerCommand.inc:95:18: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting]
  auto curTime = units::second_t(m_timer.Get());
                 ^
```
In that case at least, the cast was removed entirely since Get() already
returns a units::second_t.
This commit is contained in:
Tyler Veness
2022-08-17 13:42:36 -07:00
committed by GitHub
parent 151dabb2af
commit ac9be78e27
139 changed files with 547 additions and 593 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
wpilibc/src/main/native/cpp/Timer.cpp
View File

@@ -21,9 +21,9 @@ units::second_t GetTime() {
using std::chrono::duration_cast;
using std::chrono::system_clock;
return units::second_t(
return units::second_t{
duration_cast<duration<double>>(system_clock::now().time_since_epoch())
.count());
.count()};
}
} // namespace frc
@@ -78,9 +78,9 @@ bool Timer::AdvanceIfElapsed(units::second_t period) {
units::second_t Timer::GetFPGATimestamp() {
// FPGA returns the timestamp in microseconds
return units::second_t(frc::RobotController::GetFPGATime() * 1.0e-6);
return units::second_t{frc::RobotController::GetFPGATime() * 1.0e-6};
}
units::second_t Timer::GetMatchTime() {
return units::second_t(frc::DriverStation::GetMatchTime());
return units::second_t{frc::DriverStation::GetMatchTime()};
}