Use stricter C++ type conversions (#4357)

Now, implicit narrowing conversions are only used with wpi::Now(). This
also fixes clang-tidy warnings about C-style casts. For example:
```
== clang-tidy /__w/allwpilib/allwpilib/wpilibNewCommands/src/main/native/include/frc2/command/SwerveControllerCommand.inc ==
/__w/allwpilib/allwpilib/wpilibNewCommands/src/main/native/include/frc2/command/SwerveControllerCommand.inc:95:18: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting]
  auto curTime = units::second_t(m_timer.Get());
                 ^
```
In that case at least, the cast was removed entirely since Get() already
returns a units::second_t.

wpilibcExamples/src/main/cpp/commands/parallelcommandgroup/ReplaceMeParallelCommandGroup.cpp

@@ -9,5 +9,5 @@
 // https://docs.wpilib.org/en/stable/docs/software/commandbased/convenience-features.html
 ReplaceMeParallelCommandGroup::ReplaceMeParallelCommandGroup() {
   // Add your commands here, e.g.
-  // AddCommands(FooCommand(), BarCommand());
+  // AddCommands(FooCommand{}, BarCommand{});
 }

wpilibcExamples/src/main/cpp/commands/paralleldeadlinegroup/ReplaceMeParallelDeadlineGroup.cpp

@@ -10,9 +10,8 @@
 // For more information, see:
 // https://docs.wpilib.org/en/stable/docs/software/commandbased/convenience-features.html
 ReplaceMeParallelDeadlineGroup::ReplaceMeParallelDeadlineGroup()
-    : CommandHelper(
-          // The deadline command
-          frc2::InstantCommand([] {})) {
+    // The deadline command
+    : CommandHelper{frc2::InstantCommand{[] {}}} {
   // Add your commands here, e.g.
-  // AddCommands(FooCommand(), BarCommand());
+  // AddCommands(FooCommand{}, BarCommand{});
 }

wpilibcExamples/src/main/cpp/commands/parallelracegroup/ReplaceMeParallelRaceGroup.cpp

@@ -9,5 +9,5 @@
 // https://docs.wpilib.org/en/stable/docs/software/commandbased/convenience-features.html
 ReplaceMeParallelRaceGroup::ReplaceMeParallelRaceGroup() {
   // Add your commands here, e.g.
-  // AddCommands(FooCommand(), BarCommand());
+  // AddCommands(FooCommand{}, BarCommand{});
 }

wpilibcExamples/src/main/cpp/commands/pidcommand/ReplaceMePIDCommand.cpp

@@ -8,16 +8,15 @@
 // For more information, see:
 // https://docs.wpilib.org/en/stable/docs/software/commandbased/convenience-features.html
 ReplaceMePIDCommand::ReplaceMePIDCommand()
-    : CommandHelper(
-          frc2::PIDController(0, 0, 0),
-          // This should return the measurement
-          [] { return 0; },
-          // This should return the setpoint (can also be a constant)
-          [] { return 0; },
-          // This uses the output
-          [](double output) {
-            // Use the output here
-          }) {}
+    : CommandHelper{frc2::PIDController{0, 0, 0},
+                    // This should return the measurement
+                    [] { return 0; },
+                    // This should return the setpoint (can also be a constant)
+                    [] { return 0; },
+                    // This uses the output
+                    [](double output) {
+                      // Use the output here
+                    }} {}
 
 // Returns true when the command should end.
 bool ReplaceMePIDCommand::IsFinished() {

wpilibcExamples/src/main/cpp/commands/pidsubsystem2/ReplaceMePIDSubsystem2.cpp

@@ -5,9 +5,8 @@
 #include "ReplaceMePIDSubsystem2.h"
 
 ReplaceMePIDSubsystem2::ReplaceMePIDSubsystem2()
-    : PIDSubsystem(
-          // The PIDController used by the subsystem
-          frc2::PIDController(0, 0, 0)) {}
+    // The PIDController used by the subsystem
+    : PIDSubsystem{frc2::PIDController{0, 0, 0}} {}
 
 void ReplaceMePIDSubsystem2::UseOutput(double output, double setpoint) {
   // Use the output here

wpilibcExamples/src/main/cpp/commands/profiledpidcommand/ReplaceMeProfiledPIDCommand.cpp

@@ -11,13 +11,15 @@
 // For more information, see:
 // https://docs.wpilib.org/en/stable/docs/software/commandbased/convenience-features.html
 ReplaceMeProfiledPIDCommand::ReplaceMeProfiledPIDCommand()
-    : CommandHelper(
+    : CommandHelper{
           // The ProfiledPIDController that the command will use
-          frc::ProfiledPIDController<units::meters>(
+          frc::ProfiledPIDController<units::meters>{
               // The PID gains
-              0, 0, 0,
+              0,
+              0,
+              0,
               // The motion profile constraints
-              {0_mps, 0_mps_sq}),
+              {0_mps, 0_mps_sq}},
           // This should return the measurement
           [] { return 0_m; },
           // This should return the goal state (can also be a constant)
@@ -28,7 +30,7 @@ ReplaceMeProfiledPIDCommand::ReplaceMeProfiledPIDCommand()
           [](double output,
              frc::TrapezoidProfile<units::meters>::State setpoint) {
             // Use the output and setpoint here
-          }) {}
+          }} {}
 
 // Returns true when the command should end.
 bool ReplaceMeProfiledPIDCommand::IsFinished() {

wpilibcExamples/src/main/cpp/commands/profiledpidsubsystem/ReplaceMeProfiledPIDSubsystem.cpp

@@ -8,13 +8,14 @@
 #include <units/velocity.h>
 
 ReplaceMeProfiledPIDSubsystem::ReplaceMeProfiledPIDSubsystem()
-    : ProfiledPIDSubsystem(
-          // The ProfiledPIDController used by the subsystem
-          frc::ProfiledPIDController<units::meters>(
-              // The PID gains
-              0, 0, 0,
-              // The constraints for the motion profiles
-              {0_mps, 0_mps_sq})) {}
+    // The ProfiledPIDController used by the subsystem
+    : ProfiledPIDSubsystem{frc::ProfiledPIDController<units::meters>{
+          // The PID gains
+          0,
+          0,
+          0,
+          // The constraints for the motion profiles
+          {0_mps, 0_mps_sq}}} {}
 
 void ReplaceMeProfiledPIDSubsystem::UseOutput(
     double output, frc::TrapezoidProfile<units::meters>::State setpoint) {

wpilibcExamples/src/main/cpp/commands/sequentialcommandgroup/ReplaceMeSequentialCommandGroup.cpp

@@ -9,5 +9,5 @@
 // https://docs.wpilib.org/en/stable/docs/software/commandbased/convenience-features.html
 ReplaceMeSequentialCommandGroup::ReplaceMeSequentialCommandGroup() {
   // Add your commands here, e.g.
-  // AddCommands(FooCommand(), BarCommand());
+  // AddCommands(FooCommand{}, BarCommand{});
 }