Use stricter C++ type conversions (#4357)

Now, implicit narrowing conversions are only used with wpi::Now(). This
also fixes clang-tidy warnings about C-style casts. For example:
```
== clang-tidy /__w/allwpilib/allwpilib/wpilibNewCommands/src/main/native/include/frc2/command/SwerveControllerCommand.inc ==
/__w/allwpilib/allwpilib/wpilibNewCommands/src/main/native/include/frc2/command/SwerveControllerCommand.inc:95:18: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting]
  auto curTime = units::second_t(m_timer.Get());
                 ^
```
In that case at least, the cast was removed entirely since Get() already
returns a units::second_t.
This commit is contained in:
Tyler Veness
2022-08-17 13:42:36 -07:00
committed by GitHub
parent 151dabb2af
commit ac9be78e27
139 changed files with 547 additions and 593 deletions

View File

@@ -11,13 +11,15 @@
// For more information, see:
// https://docs.wpilib.org/en/stable/docs/software/commandbased/convenience-features.html
ReplaceMeProfiledPIDCommand::ReplaceMeProfiledPIDCommand()
: CommandHelper(
: CommandHelper{
// The ProfiledPIDController that the command will use
frc::ProfiledPIDController<units::meters>(
frc::ProfiledPIDController<units::meters>{
// The PID gains
0, 0, 0,
0,
0,
0,
// The motion profile constraints
{0_mps, 0_mps_sq}),
{0_mps, 0_mps_sq}},
// This should return the measurement
[] { return 0_m; },
// This should return the goal state (can also be a constant)
@@ -28,7 +30,7 @@ ReplaceMeProfiledPIDCommand::ReplaceMeProfiledPIDCommand()
[](double output,
frc::TrapezoidProfile<units::meters>::State setpoint) {
// Use the output and setpoint here
}) {}
}} {}
// Returns true when the command should end.
bool ReplaceMeProfiledPIDCommand::IsFinished() {