From ae6954c78fe8d4cc4a209025a53fa4454bc11658 Mon Sep 17 00:00:00 2001 From: Gold856 <117957790+Gold856@users.noreply.github.com> Date: Sun, 9 Jun 2024 19:54:31 -0400 Subject: [PATCH] [wpiunits] Clarify return conditions for isEquivalent (NFC) (#6727) --- wpiunits/src/main/java/edu/wpi/first/units/Measure.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wpiunits/src/main/java/edu/wpi/first/units/Measure.java b/wpiunits/src/main/java/edu/wpi/first/units/Measure.java index 77b46f1d02..f71b80238f 100644 --- a/wpiunits/src/main/java/edu/wpi/first/units/Measure.java +++ b/wpiunits/src/main/java/edu/wpi/first/units/Measure.java @@ -299,7 +299,7 @@ public interface Measure> extends Comparable> { * @return true if this measure is equivalent, false otherwise */ default boolean isEquivalent(Measure other) { - // Check for disjoint units that aren't compatible + // Return false for disjoint units that aren't compatible return this.unit().getBaseUnit().equals(other.unit().getBaseUnit()) && Math.abs(baseUnitMagnitude() - other.baseUnitMagnitude()) <= EQUIVALENCE_THRESHOLD; }