Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-07-03 03:01:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy: modernize-pass-by-value

Browse Source
This commit is contained in:
Peter Johnson
2020-12-28 10:12:52 -08:00
parent 29c7da5f1a
commit aee4603269
32 changed files with 158 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
simulation/halsim_ws_core/src/main/native/cpp/WSBaseProvider.cpp
View File

@@ -4,11 +4,12 @@
#include "WSBaseProvider.h"
#include <utility>
namespace wpilibws {
HALSimWSBaseProvider::HALSimWSBaseProvider(const std::string& key,
const std::string& type)
: m_key(key), m_type(type) {}
HALSimWSBaseProvider::HALSimWSBaseProvider(std::string key, std::string type)
: m_key(std::move(key)), m_type(std::move(type)) {}
void HALSimWSBaseProvider::OnNetValueChanged(const wpi::json& json) {
// empty

3
simulation/halsim_ws_core/src/main/native/include/WSBaseProvider.h
View File

@@ -16,8 +16,7 @@ namespace wpilibws {
class HALSimWSBaseProvider {
public:
explicit HALSimWSBaseProvider(const std::string& key,
const std::string& type = "");
explicit HALSimWSBaseProvider(std::string key, std::string type = "");
virtual ~HALSimWSBaseProvider() = default;
HALSimWSBaseProvider(const HALSimWSBaseProvider&) = delete;