Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy: modernize-pass-by-value

Browse Source
This commit is contained in:
Peter Johnson
2020-12-28 10:12:52 -08:00
parent 29c7da5f1a
commit aee4603269
32 changed files with 158 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wpilibcExamples/src/main/cpp/examples/GearsBot/cpp/commands/TankDrive.cpp
View File

@@ -4,11 +4,15 @@
#include "commands/TankDrive.h"
#include <utility>
#include "Robot.h"
TankDrive::TankDrive(std::function<double()> left,
std::function<double()> right, DriveTrain* drivetrain)
: m_left(left), m_right(right), m_drivetrain(drivetrain) {
: m_left(std::move(left)),
m_right(std::move(right)),
m_drivetrain(drivetrain) {
SetName("TankDrive");
AddRequirements({m_drivetrain});
}

6
wpilibcExamples/src/main/cpp/examples/HatchbotTraditional/cpp/commands/DefaultDrive.cpp
View File

@@ -4,10 +4,14 @@
#include "commands/DefaultDrive.h"
#include <utility>
DefaultDrive::DefaultDrive(DriveSubsystem* subsystem,
std::function<double()> forward,
std::function<double()> rotation)
: m_drive{subsystem}, m_forward{forward}, m_rotation{rotation} {
: m_drive{subsystem},
m_forward{std::move(forward)},
m_rotation{std::move(rotation)} {
AddRequirements({subsystem});
}