[wpilib] Finish gamepad face button rename (#8921)

wpilibc/src/main/native/include/wpi/driverstation/Gamepad.hpp

@@ -28,14 +28,14 @@ class Gamepad : public GenericHID,
  public:
   /** Represents a digital button on an Gamepad. */
   enum class Button {
-    /// South Face button.
-    SOUTH_FACE = 0,
-    /// East Face button.
-    EAST_FACE = 1,
-    /// West Face button.
-    WEST_FACE = 2,
-    /// North Face button.
-    NORTH_FACE = 3,
+    /// Face Down button.
+    FACE_DOWN = 0,
+    /// Face Right button.
+    FACE_RIGHT = 1,
+    /// Face Left button.
+    FACE_LEFT = 2,
+    /// Face Up button.
+    FACE_UP = 3,
     /// Back button.
     BACK = 4,
     /// Guide button.
@@ -202,25 +202,25 @@ class Gamepad : public GenericHID,
   BooleanEvent RightTrigger(EventLoop* loop) const;
 
   /**
-   * Read the value of the South Face button on the controller.
+   * Read the value of the Face Down button on the controller.
    *
    * @return The state of the button.
    */
-  bool GetSouthFaceButton() const;
+  bool GetFaceDownButton() const;
 
   /**
-   * Whether the South Face button was pressed since the last check.
+   * Whether the Face Down button was pressed since the last check.
    *
    * @return Whether the button was pressed since the last check.
    */
-  bool GetSouthFaceButtonPressed();
+  bool GetFaceDownButtonPressed();
 
   /**
-   * Whether the South Face button was released since the last check.
+   * Whether the Face Down button was released since the last check.
    *
    * @return Whether the button was released since the last check.
    */
-  bool GetSouthFaceButtonReleased();
+  bool GetFaceDownButtonReleased();
 
   /**
    * Constructs an event instance around the Face Down button's
@@ -233,25 +233,25 @@ class Gamepad : public GenericHID,
   BooleanEvent FaceDown(EventLoop* loop) const;
 
   /**
-   * Read the value of the East Face button on the controller.
+   * Read the value of the Face Right button on the controller.
    *
    * @return The state of the button.
    */
-  bool GetEastFaceButton() const;
+  bool GetFaceRightButton() const;
 
   /**
-   * Whether the East Face button was pressed since the last check.
+   * Whether the Face Right button was pressed since the last check.
    *
    * @return Whether the button was pressed since the last check.
    */
-  bool GetEastFaceButtonPressed();
+  bool GetFaceRightButtonPressed();
 
   /**
-   * Whether the East Face button was released since the last check.
+   * Whether the Face Right button was released since the last check.
    *
    * @return Whether the button was released since the last check.
    */
-  bool GetEastFaceButtonReleased();
+  bool GetFaceRightButtonReleased();
 
   /**
    * Constructs an event instance around the Face Right button's
@@ -264,25 +264,25 @@ class Gamepad : public GenericHID,
   BooleanEvent FaceRight(EventLoop* loop) const;
 
   /**
-   * Read the value of the West Face button on the controller.
+   * Read the value of the Face Left button on the controller.
    *
    * @return The state of the button.
    */
-  bool GetWestFaceButton() const;
+  bool GetFaceLeftButton() const;
 
   /**
-   * Whether the West Face button was pressed since the last check.
+   * Whether the Face Left button was pressed since the last check.
    *
    * @return Whether the button was pressed since the last check.
    */
-  bool GetWestFaceButtonPressed();
+  bool GetFaceLeftButtonPressed();
 
   /**
-   * Whether the West Face button was released since the last check.
+   * Whether the Face Left button was released since the last check.
    *
    * @return Whether the button was released since the last check.
    */
-  bool GetWestFaceButtonReleased();
+  bool GetFaceLeftButtonReleased();
 
   /**
    * Constructs an event instance around the Face Left button's
@@ -295,25 +295,25 @@ class Gamepad : public GenericHID,
   BooleanEvent FaceLeft(EventLoop* loop) const;
 
   /**
-   * Read the value of the North Face button on the controller.
+   * Read the value of the Face Up button on the controller.
    *
    * @return The state of the button.
    */
-  bool GetNorthFaceButton() const;
+  bool GetFaceUpButton() const;
 
   /**
-   * Whether the North Face button was pressed since the last check.
+   * Whether the Face Up button was pressed since the last check.
    *
    * @return Whether the button was pressed since the last check.
    */
-  bool GetNorthFaceButtonPressed();
+  bool GetFaceUpButtonPressed();
 
   /**
-   * Whether the North Face button was released since the last check.
+   * Whether the Face Up button was released since the last check.
    *
    * @return Whether the button was released since the last check.
    */
-  bool GetNorthFaceButtonReleased();
+  bool GetFaceUpButtonReleased();
 
   /**
    * Constructs an event instance around the Face Up button's