Use std::string_view and fmtlib across all libraries (#3402)

- Twine, StringRef, Format, and NativeFormatting have been removed
- Logging now uses fmtlib style formatting
- Nearly all uses of wpi::outs/errs have been replaced with fmt::print() or
std::puts()/std::fputs() (for unformatted strings).
- A wpi/fmt/raw_ostream.h header has been added to enable
fmt::print() with wpi::raw_ostream
This commit is contained in:
Peter Johnson
2021-06-06 16:13:58 -07:00
committed by GitHub
parent 4f1cecb8e7
commit b2c3b2dd8e
441 changed files with 5061 additions and 9749 deletions

View File

@@ -6,6 +6,7 @@
#include <cinttypes>
#include <memory>
#include <string_view>
#include <utility>
#include <HALSimBaseWebSocketConnection.h>
@@ -38,14 +39,13 @@ class HALSimHttpConnection
protected:
void ProcessRequest() override;
bool IsValidWsUpgrade(wpi::StringRef protocol) override;
bool IsValidWsUpgrade(std::string_view protocol) override;
void ProcessWsUpgrade() override;
void SendFileResponse(int code, const wpi::Twine& codeText,
const wpi::Twine& contentType,
const wpi::Twine& filename,
const wpi::Twine& extraHeader = wpi::Twine{});
void SendFileResponse(int code, std::string_view codeText,
std::string_view contentType, std::string_view filename,
std::string_view extraHeader = {});
void MySendError(int code, const wpi::Twine& message);
void MySendError(int code, std::string_view message);
void Log(int code);
private:

View File

@@ -11,7 +11,6 @@
#include <WSBaseProvider.h>
#include <WSProviderContainer.h>
#include <WSProvider_SimDevice.h>
#include <wpi/StringRef.h>
#include <wpi/uv/Async.h>
#include <wpi/uv/Loop.h>
#include <wpi/uv/Tcp.h>
@@ -42,9 +41,9 @@ class HALSimWeb : public std::enable_shared_from_this<HALSimWeb> {
// network -> sim
void OnNetValueChanged(const wpi::json& msg);
wpi::StringRef GetWebrootSys() const { return m_webroot_sys; }
wpi::StringRef GetWebrootUser() const { return m_webroot_user; }
wpi::StringRef GetServerUri() const { return m_uri; }
const std::string& GetWebrootSys() const { return m_webroot_sys; }
const std::string& GetWebrootUser() const { return m_webroot_user; }
const std::string& GetServerUri() const { return m_uri; }
int GetServerPort() const { return m_port; }
wpi::uv::Loop& GetLoop() { return m_loop; }