Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-22 01:11:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes memory leak for SPI reads (#474)

Browse Source 
Adds a stack allocation for most use cases.
This commit is contained in:
Thad House
2017-02-14 01:14:08 -08:00
committed by Peter Johnson
parent 5a5f10dfc8
commit b50a7bdbee
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
wpilibc/athena/src/SPI.cpp
View File

@@ -12,6 +12,7 @@
#include "HAL/HAL.h"
#include "WPIErrors.h"
#include "llvm/SmallVector.h"
using namespace frc;
@@ -147,9 +148,9 @@ int SPI::Write(uint8_t* data, int size) {
int SPI::Read(bool initiate, uint8_t* dataReceived, int size) {
int retVal = 0;
if (initiate) {
auto dataToSend = new uint8_t[size];
std::memset(dataToSend, 0, size);
retVal = HAL_TransactionSPI(m_port, dataToSend, dataReceived, size);
llvm::SmallVector<uint8_t, 32> dataToSend;
dataToSend.resize(size);
retVal = HAL_TransactionSPI(m_port, dataToSend.data(), dataReceived, size);
} else {
retVal = HAL_ReadSPI(m_port, dataReceived, size);
}