From b50a7bdbeeca7c1acbc4c0e19d6b0f76dabb2f69 Mon Sep 17 00:00:00 2001 From: Thad House Date: Tue, 14 Feb 2017 01:14:08 -0800 Subject: [PATCH] Fixes memory leak for SPI reads (#474) Adds a stack allocation for most use cases. --- wpilibc/athena/src/SPI.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/wpilibc/athena/src/SPI.cpp b/wpilibc/athena/src/SPI.cpp index 5fe18cac3f..0dd2204af6 100644 --- a/wpilibc/athena/src/SPI.cpp +++ b/wpilibc/athena/src/SPI.cpp @@ -12,6 +12,7 @@ #include "HAL/HAL.h" #include "WPIErrors.h" +#include "llvm/SmallVector.h" using namespace frc; @@ -147,9 +148,9 @@ int SPI::Write(uint8_t* data, int size) { int SPI::Read(bool initiate, uint8_t* dataReceived, int size) { int retVal = 0; if (initiate) { - auto dataToSend = new uint8_t[size]; - std::memset(dataToSend, 0, size); - retVal = HAL_TransactionSPI(m_port, dataToSend, dataReceived, size); + llvm::SmallVector dataToSend; + dataToSend.resize(size); + retVal = HAL_TransactionSPI(m_port, dataToSend.data(), dataReceived, size); } else { retVal = HAL_ReadSPI(m_port, dataReceived, size); }