diff --git a/glass/src/libnt/native/cpp/NTCommandScheduler.cpp b/glass/src/libnt/native/cpp/NTCommandScheduler.cpp index 0a46bf9ad9..857e0df16d 100644 --- a/glass/src/libnt/native/cpp/NTCommandScheduler.cpp +++ b/glass/src/libnt/native/cpp/NTCommandScheduler.cpp @@ -23,7 +23,6 @@ NTCommandSchedulerModel::NTCommandSchedulerModel(NT_Inst instance, m_nt.AddListener(m_commands); m_nt.AddListener(m_ids); m_nt.AddListener(m_cancel); - Update(); } void NTCommandSchedulerModel::CancelCommand(size_t index) { diff --git a/glass/src/libnt/native/cpp/NTCommandSelector.cpp b/glass/src/libnt/native/cpp/NTCommandSelector.cpp index 7ee2c35ebd..bf9a399a35 100644 --- a/glass/src/libnt/native/cpp/NTCommandSelector.cpp +++ b/glass/src/libnt/native/cpp/NTCommandSelector.cpp @@ -19,7 +19,6 @@ NTCommandSelectorModel::NTCommandSelectorModel(NT_Inst instance, m_runningData.SetDigital(true); m_nt.AddListener(m_running); m_nt.AddListener(m_name); - Update(); } void NTCommandSelectorModel::SetRunning(bool run) { diff --git a/glass/src/libnt/native/cpp/NTDigitalInput.cpp b/glass/src/libnt/native/cpp/NTDigitalInput.cpp index 76cb51646f..a823dbbd25 100644 --- a/glass/src/libnt/native/cpp/NTDigitalInput.cpp +++ b/glass/src/libnt/native/cpp/NTDigitalInput.cpp @@ -21,7 +21,6 @@ NTDigitalInputModel::NTDigitalInputModel(NT_Inst inst, wpi::StringRef path) m_nt.AddListener(m_name); m_valueData.SetDigital(true); - Update(); } void NTDigitalInputModel::Update() { diff --git a/glass/src/libnt/native/cpp/NTDigitalOutput.cpp b/glass/src/libnt/native/cpp/NTDigitalOutput.cpp index 8910d67870..ca260b548d 100644 --- a/glass/src/libnt/native/cpp/NTDigitalOutput.cpp +++ b/glass/src/libnt/native/cpp/NTDigitalOutput.cpp @@ -22,7 +22,6 @@ NTDigitalOutputModel::NTDigitalOutputModel(NT_Inst inst, wpi::StringRef path) m_nt.AddListener(m_controllable); m_valueData.SetDigital(true); - Update(); } void NTDigitalOutputModel::SetValue(bool val) { diff --git a/glass/src/libnt/native/cpp/NTFMS.cpp b/glass/src/libnt/native/cpp/NTFMS.cpp index 7c9967d0b8..f1dc2eede9 100644 --- a/glass/src/libnt/native/cpp/NTFMS.cpp +++ b/glass/src/libnt/native/cpp/NTFMS.cpp @@ -37,7 +37,6 @@ NTFMSModel::NTFMSModel(NT_Inst inst, wpi::StringRef path) m_enabled.SetDigital(true); m_test.SetDigital(true); m_autonomous.SetDigital(true); - Update(); } wpi::StringRef NTFMSModel::GetGameSpecificMessage( diff --git a/glass/src/libnt/native/cpp/NTField2D.cpp b/glass/src/libnt/native/cpp/NTField2D.cpp index 620bb05865..47fcf2fb23 100644 --- a/glass/src/libnt/native/cpp/NTField2D.cpp +++ b/glass/src/libnt/native/cpp/NTField2D.cpp @@ -147,7 +147,7 @@ void NTField2DModel::GroupModel::ObjectModel::SetPoseImpl(double x, double y, return; } auto origArr = value->GetDoubleArray(); - if (origArr.size() < static_cast((m_index + 1) * 3)) { + if (static_cast(origArr.size()) < ((m_index + 1) * 3)) { return; } diff --git a/glass/src/libnt/native/cpp/NTGyro.cpp b/glass/src/libnt/native/cpp/NTGyro.cpp index db5fb41e1f..e0af6a0480 100644 --- a/glass/src/libnt/native/cpp/NTGyro.cpp +++ b/glass/src/libnt/native/cpp/NTGyro.cpp @@ -17,7 +17,6 @@ NTGyroModel::NTGyroModel(NT_Inst instance, wpi::StringRef path) m_nameValue(path.rsplit('/').second) { m_nt.AddListener(m_angle); m_nt.AddListener(m_name); - Update(); } void NTGyroModel::Update() { diff --git a/glass/src/libnt/native/cpp/NTPIDController.cpp b/glass/src/libnt/native/cpp/NTPIDController.cpp index 0edb565f04..f8eaa80e72 100644 --- a/glass/src/libnt/native/cpp/NTPIDController.cpp +++ b/glass/src/libnt/native/cpp/NTPIDController.cpp @@ -27,7 +27,6 @@ NTPIDControllerModel::NTPIDControllerModel(NT_Inst instance, m_nt.AddListener(m_i); m_nt.AddListener(m_d); m_nt.AddListener(m_setpoint); - Update(); } void NTPIDControllerModel::SetP(double value) { diff --git a/glass/src/libnt/native/cpp/NTSpeedController.cpp b/glass/src/libnt/native/cpp/NTSpeedController.cpp index 3ca3a35f4b..1c84a4471e 100644 --- a/glass/src/libnt/native/cpp/NTSpeedController.cpp +++ b/glass/src/libnt/native/cpp/NTSpeedController.cpp @@ -18,7 +18,6 @@ NTSpeedControllerModel::NTSpeedControllerModel(NT_Inst instance, m_nameValue(path.rsplit('/').second) { m_nt.AddListener(m_value); m_nt.AddListener(m_name); - Update(); } void NTSpeedControllerModel::SetPercent(double value) { diff --git a/glass/src/libnt/native/cpp/NTStringChooser.cpp b/glass/src/libnt/native/cpp/NTStringChooser.cpp index 46c8b93403..33c8fa2d0b 100644 --- a/glass/src/libnt/native/cpp/NTStringChooser.cpp +++ b/glass/src/libnt/native/cpp/NTStringChooser.cpp @@ -19,8 +19,6 @@ NTStringChooserModel::NTStringChooserModel(NT_Inst inst, wpi::StringRef path) m_nt.AddListener(m_selected); m_nt.AddListener(m_active); m_nt.AddListener(m_options); - - Update(); } void NTStringChooserModel::SetDefault(wpi::StringRef val) { diff --git a/glass/src/libnt/native/cpp/NTSubsystem.cpp b/glass/src/libnt/native/cpp/NTSubsystem.cpp index 0254f849be..e7976ec958 100644 --- a/glass/src/libnt/native/cpp/NTSubsystem.cpp +++ b/glass/src/libnt/native/cpp/NTSubsystem.cpp @@ -17,7 +17,6 @@ NTSubsystemModel::NTSubsystemModel(NT_Inst instance, wpi::StringRef path) m_nt.AddListener(m_name); m_nt.AddListener(m_defaultCommand); m_nt.AddListener(m_currentCommand); - Update(); } void NTSubsystemModel::Update() { diff --git a/wpilibNewCommands/src/main/native/include/frc2/command/ParallelCommandGroup.h b/wpilibNewCommands/src/main/native/include/frc2/command/ParallelCommandGroup.h index dd7c24e996..342265acb2 100644 --- a/wpilibNewCommands/src/main/native/include/frc2/command/ParallelCommandGroup.h +++ b/wpilibNewCommands/src/main/native/include/frc2/command/ParallelCommandGroup.h @@ -83,7 +83,7 @@ class ParallelCommandGroup bool RunsWhenDisabled() const override; private: - void AddCommands(std::vector>&& commands) override; + void AddCommands(std::vector>&& commands) final; std::vector, bool>> m_commands; bool m_runWhenDisabled{true}; diff --git a/wpilibNewCommands/src/main/native/include/frc2/command/ParallelDeadlineGroup.h b/wpilibNewCommands/src/main/native/include/frc2/command/ParallelDeadlineGroup.h index f6a05ddaf7..af78c3b0bd 100644 --- a/wpilibNewCommands/src/main/native/include/frc2/command/ParallelDeadlineGroup.h +++ b/wpilibNewCommands/src/main/native/include/frc2/command/ParallelDeadlineGroup.h @@ -91,7 +91,7 @@ class ParallelDeadlineGroup bool RunsWhenDisabled() const override; private: - void AddCommands(std::vector>&& commands) override; + void AddCommands(std::vector>&& commands) final; void SetDeadline(std::unique_ptr&& deadline); diff --git a/wpilibNewCommands/src/main/native/include/frc2/command/ParallelRaceGroup.h b/wpilibNewCommands/src/main/native/include/frc2/command/ParallelRaceGroup.h index 2a7065cf33..3ba390711f 100644 --- a/wpilibNewCommands/src/main/native/include/frc2/command/ParallelRaceGroup.h +++ b/wpilibNewCommands/src/main/native/include/frc2/command/ParallelRaceGroup.h @@ -71,7 +71,7 @@ class ParallelRaceGroup bool RunsWhenDisabled() const override; private: - void AddCommands(std::vector>&& commands) override; + void AddCommands(std::vector>&& commands) final; std::vector> m_commands; bool m_runWhenDisabled{true}; diff --git a/wpilibc/src/main/native/include/frc/ADXL345_I2C.h b/wpilibc/src/main/native/include/frc/ADXL345_I2C.h index 06feae5174..7820751442 100644 --- a/wpilibc/src/main/native/include/frc/ADXL345_I2C.h +++ b/wpilibc/src/main/native/include/frc/ADXL345_I2C.h @@ -51,7 +51,7 @@ class ADXL345_I2C : public ErrorBase, ADXL345_I2C& operator=(ADXL345_I2C&&) = default; // Accelerometer interface - void SetRange(Range range) override; + void SetRange(Range range) final; double GetX() override; double GetY() override; double GetZ() override; diff --git a/wpilibc/src/main/native/include/frc/ADXL345_SPI.h b/wpilibc/src/main/native/include/frc/ADXL345_SPI.h index 5d4b995fda..ee16518760 100644 --- a/wpilibc/src/main/native/include/frc/ADXL345_SPI.h +++ b/wpilibc/src/main/native/include/frc/ADXL345_SPI.h @@ -47,7 +47,7 @@ class ADXL345_SPI : public ErrorBase, ADXL345_SPI& operator=(ADXL345_SPI&&) = default; // Accelerometer interface - void SetRange(Range range) override; + void SetRange(Range range) final; double GetX() override; double GetY() override; double GetZ() override; diff --git a/wpilibc/src/main/native/include/frc/ADXL362.h b/wpilibc/src/main/native/include/frc/ADXL362.h index 075d6c1f5a..39734e1d57 100644 --- a/wpilibc/src/main/native/include/frc/ADXL362.h +++ b/wpilibc/src/main/native/include/frc/ADXL362.h @@ -55,7 +55,7 @@ class ADXL362 : public ErrorBase, ADXL362& operator=(ADXL362&&) = default; // Accelerometer interface - void SetRange(Range range) override; + void SetRange(Range range) final; double GetX() override; double GetY() override; double GetZ() override; diff --git a/wpilibc/src/main/native/include/frc/ADXRS450_Gyro.h b/wpilibc/src/main/native/include/frc/ADXRS450_Gyro.h index 7adb83c9fc..3c49c05622 100644 --- a/wpilibc/src/main/native/include/frc/ADXRS450_Gyro.h +++ b/wpilibc/src/main/native/include/frc/ADXRS450_Gyro.h @@ -87,7 +87,7 @@ class ADXRS450_Gyro : public GyroBase { * robot is first turned on while it's sitting at rest before the competition * starts. */ - void Calibrate() override; + void Calibrate() final; /** * Get the SPI port number. diff --git a/wpilibc/src/main/native/include/frc/AnalogGyro.h b/wpilibc/src/main/native/include/frc/AnalogGyro.h index 07b7fd762c..42b6317def 100644 --- a/wpilibc/src/main/native/include/frc/AnalogGyro.h +++ b/wpilibc/src/main/native/include/frc/AnalogGyro.h @@ -172,16 +172,16 @@ class AnalogGyro : public GyroBase { * significant drift in the gyro and it needs to be recalibrated after it has * been running. */ - void Reset() override; + void Reset() final; /** * Initialize the gyro. * * Calibration is handled by Calibrate(). */ - virtual void InitGyro(); + void InitGyro(); - void Calibrate() override; + void Calibrate() final; /** * Gets the analog input for the gyro. diff --git a/wpilibc/src/main/native/include/frc/simulation/SimDeviceSim.h b/wpilibc/src/main/native/include/frc/simulation/SimDeviceSim.h index f81d1bb610..3e5de8b290 100644 --- a/wpilibc/src/main/native/include/frc/simulation/SimDeviceSim.h +++ b/wpilibc/src/main/native/include/frc/simulation/SimDeviceSim.h @@ -45,7 +45,7 @@ class SimDeviceSim { }); } - operator HAL_SimDeviceHandle() const { return m_handle; } + operator HAL_SimDeviceHandle() const { return m_handle; } // NOLINT template static void EnumerateDevices(const char* prefix, F callback) { diff --git a/wpiutil/src/main/native/include/wpi/TCPAcceptor.h b/wpiutil/src/main/native/include/wpi/TCPAcceptor.h index 8f25a19ba6..f1ff685400 100644 --- a/wpiutil/src/main/native/include/wpi/TCPAcceptor.h +++ b/wpiutil/src/main/native/include/wpi/TCPAcceptor.h @@ -48,7 +48,7 @@ class TCPAcceptor : public NetworkAcceptor { ~TCPAcceptor() override; int start() override; - void shutdown() override; + void shutdown() final; std::unique_ptr accept() override; }; diff --git a/wpiutil/src/main/native/include/wpi/raw_istream.h b/wpiutil/src/main/native/include/wpi/raw_istream.h index ce897569e2..d09f82f08b 100644 --- a/wpiutil/src/main/native/include/wpi/raw_istream.h +++ b/wpiutil/src/main/native/include/wpi/raw_istream.h @@ -158,7 +158,7 @@ class raw_fd_istream : public raw_istream { size_t bufSize = 4096); raw_fd_istream(int fd, bool shouldClose, size_t bufSize = 4096); ~raw_fd_istream() override; - void close() override; + void close() final; size_t in_avail() const override; private: