clang-tidy: bugprone-virtual-near-miss

A few virtual functions are called by constructors or destructors, which is
dangerous in C++ (as an overridden virtual impl won't be called, only the
one in the current class).  Fix by either marking the function final or
not calling at all (if possible).

glass/src/libnt/native/cpp/NTCommandScheduler.cpp

@@ -23,7 +23,6 @@ NTCommandSchedulerModel::NTCommandSchedulerModel(NT_Inst instance,
   m_nt.AddListener(m_commands);
   m_nt.AddListener(m_ids);
   m_nt.AddListener(m_cancel);
-  Update();
 }
 
 void NTCommandSchedulerModel::CancelCommand(size_t index) {

glass/src/libnt/native/cpp/NTCommandSelector.cpp

@@ -19,7 +19,6 @@ NTCommandSelectorModel::NTCommandSelectorModel(NT_Inst instance,
   m_runningData.SetDigital(true);
   m_nt.AddListener(m_running);
   m_nt.AddListener(m_name);
-  Update();
 }
 
 void NTCommandSelectorModel::SetRunning(bool run) {

glass/src/libnt/native/cpp/NTDigitalInput.cpp

@@ -21,7 +21,6 @@ NTDigitalInputModel::NTDigitalInputModel(NT_Inst inst, wpi::StringRef path)
   m_nt.AddListener(m_name);
 
   m_valueData.SetDigital(true);
-  Update();
 }
 
 void NTDigitalInputModel::Update() {

glass/src/libnt/native/cpp/NTDigitalOutput.cpp

@@ -22,7 +22,6 @@ NTDigitalOutputModel::NTDigitalOutputModel(NT_Inst inst, wpi::StringRef path)
   m_nt.AddListener(m_controllable);
 
   m_valueData.SetDigital(true);
-  Update();
 }
 
 void NTDigitalOutputModel::SetValue(bool val) {

glass/src/libnt/native/cpp/NTFMS.cpp

@@ -37,7 +37,6 @@ NTFMSModel::NTFMSModel(NT_Inst inst, wpi::StringRef path)
   m_enabled.SetDigital(true);
   m_test.SetDigital(true);
   m_autonomous.SetDigital(true);
-  Update();
 }
 
 wpi::StringRef NTFMSModel::GetGameSpecificMessage(

glass/src/libnt/native/cpp/NTField2D.cpp

@@ -147,7 +147,7 @@ void NTField2DModel::GroupModel::ObjectModel::SetPoseImpl(double x, double y,
     return;
   }
   auto origArr = value->GetDoubleArray();
-  if (origArr.size() < static_cast<size_t>((m_index + 1) * 3)) {
+  if (static_cast<int>(origArr.size()) < ((m_index + 1) * 3)) {
     return;
   }
 

glass/src/libnt/native/cpp/NTGyro.cpp

@@ -17,7 +17,6 @@ NTGyroModel::NTGyroModel(NT_Inst instance, wpi::StringRef path)
       m_nameValue(path.rsplit('/').second) {
   m_nt.AddListener(m_angle);
   m_nt.AddListener(m_name);
-  Update();
 }
 
 void NTGyroModel::Update() {

glass/src/libnt/native/cpp/NTPIDController.cpp

@@ -27,7 +27,6 @@ NTPIDControllerModel::NTPIDControllerModel(NT_Inst instance,
   m_nt.AddListener(m_i);
   m_nt.AddListener(m_d);
   m_nt.AddListener(m_setpoint);
-  Update();
 }
 
 void NTPIDControllerModel::SetP(double value) {

glass/src/libnt/native/cpp/NTSpeedController.cpp

@@ -18,7 +18,6 @@ NTSpeedControllerModel::NTSpeedControllerModel(NT_Inst instance,
       m_nameValue(path.rsplit('/').second) {
   m_nt.AddListener(m_value);
   m_nt.AddListener(m_name);
-  Update();
 }
 
 void NTSpeedControllerModel::SetPercent(double value) {

glass/src/libnt/native/cpp/NTStringChooser.cpp

@@ -19,8 +19,6 @@ NTStringChooserModel::NTStringChooserModel(NT_Inst inst, wpi::StringRef path)
   m_nt.AddListener(m_selected);
   m_nt.AddListener(m_active);
   m_nt.AddListener(m_options);
-
-  Update();
 }
 
 void NTStringChooserModel::SetDefault(wpi::StringRef val) {

glass/src/libnt/native/cpp/NTSubsystem.cpp

@@ -17,7 +17,6 @@ NTSubsystemModel::NTSubsystemModel(NT_Inst instance, wpi::StringRef path)
   m_nt.AddListener(m_name);
   m_nt.AddListener(m_defaultCommand);
   m_nt.AddListener(m_currentCommand);
-  Update();
 }
 
 void NTSubsystemModel::Update() {