Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy: bugprone-virtual-near-miss

Browse Source 
A few virtual functions are called by constructors or destructors, which is
dangerous in C++ (as an overridden virtual impl won't be called, only the
one in the current class).  Fix by either marking the function final or
not calling at all (if possible).
This commit is contained in:
Peter Johnson
2020-12-26 22:06:28 -08:00
parent cbe59fa3bf
commit b60eb1544b
22 changed files with 14 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
wpilibNewCommands/src/main/native/include/frc2/command/ParallelCommandGroup.h
View File

@@ -83,7 +83,7 @@ class ParallelCommandGroup
bool RunsWhenDisabled() const override;
private:
void AddCommands(std::vector<std::unique_ptr<Command>>&& commands) override;
void AddCommands(std::vector<std::unique_ptr<Command>>&& commands) final;
std::vector<std::pair<std::unique_ptr<Command>, bool>> m_commands;
bool m_runWhenDisabled{true};

2
wpilibNewCommands/src/main/native/include/frc2/command/ParallelDeadlineGroup.h
View File

@@ -91,7 +91,7 @@ class ParallelDeadlineGroup
bool RunsWhenDisabled() const override;
private:
void AddCommands(std::vector<std::unique_ptr<Command>>&& commands) override;
void AddCommands(std::vector<std::unique_ptr<Command>>&& commands) final;
void SetDeadline(std::unique_ptr<Command>&& deadline);

2
wpilibNewCommands/src/main/native/include/frc2/command/ParallelRaceGroup.h
View File

@@ -71,7 +71,7 @@ class ParallelRaceGroup
bool RunsWhenDisabled() const override;
private:
void AddCommands(std::vector<std::unique_ptr<Command>>&& commands) override;
void AddCommands(std::vector<std::unique_ptr<Command>>&& commands) final;
std::vector<std::unique_ptr<Command>> m_commands;
bool m_runWhenDisabled{true};