diff --git a/wpimath/src/main/java/edu/wpi/first/math/controller/LinearQuadraticRegulator.java b/wpimath/src/main/java/edu/wpi/first/math/controller/LinearQuadraticRegulator.java index 660fa8fefa..7ab4e62304 100644 --- a/wpimath/src/main/java/edu/wpi/first/math/controller/LinearQuadraticRegulator.java +++ b/wpimath/src/main/java/edu/wpi/first/math/controller/LinearQuadraticRegulator.java @@ -47,7 +47,7 @@ public class LinearQuadraticRegulator plant, @@ -74,7 +74,7 @@ public class LinearQuadraticRegulator A, @@ -98,7 +98,7 @@ public class LinearQuadraticRegulator A, @@ -112,7 +112,7 @@ public class LinearQuadraticRegulator A, diff --git a/wpimath/src/main/java/edu/wpi/first/math/estimator/KalmanFilter.java b/wpimath/src/main/java/edu/wpi/first/math/estimator/KalmanFilter.java index 9e286255df..497f094668 100644 --- a/wpimath/src/main/java/edu/wpi/first/math/estimator/KalmanFilter.java +++ b/wpimath/src/main/java/edu/wpi/first/math/estimator/KalmanFilter.java @@ -59,7 +59,7 @@ public class KalmanFilter states, @@ -87,7 +87,7 @@ public class KalmanFilter states, @@ -86,7 +86,7 @@ public class SteadyStateKalmanFilter LinearQuadraticRegulator(const LinearSystem& plant, @@ -64,7 +64,7 @@ class LinearQuadraticRegulator { * @param Qelems The maximum desired error tolerance for each state. * @param Relems The maximum desired control effort for each input. * @param dt Discretization timestep. - * @throws std::invalid_argument If the system is uncontrollable. + * @throws std::invalid_argument If the system is unstabilizable. */ LinearQuadraticRegulator(const Matrixd& A, const Matrixd& B, @@ -79,7 +79,7 @@ class LinearQuadraticRegulator { * @param Q The state cost matrix. * @param R The input cost matrix. * @param dt Discretization timestep. - * @throws std::invalid_argument If the system is uncontrollable. + * @throws std::invalid_argument If the system is unstabilizable. */ LinearQuadraticRegulator(const Matrixd& A, const Matrixd& B, @@ -96,7 +96,7 @@ class LinearQuadraticRegulator { * @param R The input cost matrix. * @param N The state-input cross-term cost matrix. * @param dt Discretization timestep. - * @throws std::invalid_argument If the system is uncontrollable. + * @throws std::invalid_argument If the system is unstabilizable. */ LinearQuadraticRegulator(const Matrixd& A, const Matrixd& B, diff --git a/wpimath/src/main/native/include/frc/controller/LinearQuadraticRegulator.inc b/wpimath/src/main/native/include/frc/controller/LinearQuadraticRegulator.inc index 1871244db5..333181ce49 100644 --- a/wpimath/src/main/native/include/frc/controller/LinearQuadraticRegulator.inc +++ b/wpimath/src/main/native/include/frc/controller/LinearQuadraticRegulator.inc @@ -44,8 +44,7 @@ LinearQuadraticRegulator::LinearQuadraticRegulator( if (!IsStabilizable(discA, discB)) { std::string msg = fmt::format( - "The system passed to the LQR is uncontrollable!\n\nA =\n{}\nB " - "=\n{}\n", + "The system passed to the LQR is unstabilizable!\n\nA =\n{}\nB =\n{}\n", discA, discB); wpi::math::MathSharedStore::ReportError(msg); diff --git a/wpimath/src/main/native/include/frc/estimator/KalmanFilter.h b/wpimath/src/main/native/include/frc/estimator/KalmanFilter.h index 56dce0c11c..54ee51bafc 100644 --- a/wpimath/src/main/native/include/frc/estimator/KalmanFilter.h +++ b/wpimath/src/main/native/include/frc/estimator/KalmanFilter.h @@ -55,7 +55,7 @@ class KalmanFilter { * @param stateStdDevs Standard deviations of model states. * @param measurementStdDevs Standard deviations of measurements. * @param dt Nominal discretization timestep. - * @throws std::invalid_argument If the system is unobservable. + * @throws std::invalid_argument If the system is undetectable. */ KalmanFilter(LinearSystem& plant, const StateArray& stateStdDevs, diff --git a/wpimath/src/main/native/include/frc/estimator/KalmanFilter.inc b/wpimath/src/main/native/include/frc/estimator/KalmanFilter.inc index cfb8bd9bf9..a00b455b31 100644 --- a/wpimath/src/main/native/include/frc/estimator/KalmanFilter.inc +++ b/wpimath/src/main/native/include/frc/estimator/KalmanFilter.inc @@ -41,8 +41,8 @@ KalmanFilter::KalmanFilter( if (!IsDetectable(discA, C)) { std::string msg = fmt::format( - "The system passed to the Kalman filter is " - "unobservable!\n\nA =\n{}\nC =\n{}\n", + "The system passed to the Kalman filter is undetectable!\n\n" + "A =\n{}\nC =\n{}\n", discA, C); wpi::math::MathSharedStore::ReportError(msg); diff --git a/wpimath/src/main/native/include/frc/estimator/SteadyStateKalmanFilter.h b/wpimath/src/main/native/include/frc/estimator/SteadyStateKalmanFilter.h index 64b1782b97..0604541561 100644 --- a/wpimath/src/main/native/include/frc/estimator/SteadyStateKalmanFilter.h +++ b/wpimath/src/main/native/include/frc/estimator/SteadyStateKalmanFilter.h @@ -58,7 +58,7 @@ class SteadyStateKalmanFilter { * @param stateStdDevs Standard deviations of model states. * @param measurementStdDevs Standard deviations of measurements. * @param dt Nominal discretization timestep. - * @throws std::invalid_argument If the system is unobservable. + * @throws std::invalid_argument If the system is undetectable. */ SteadyStateKalmanFilter(LinearSystem& plant, const StateArray& stateStdDevs, diff --git a/wpimath/src/main/native/include/frc/estimator/SteadyStateKalmanFilter.inc b/wpimath/src/main/native/include/frc/estimator/SteadyStateKalmanFilter.inc index 1f2f2a2ff6..2f75b241cc 100644 --- a/wpimath/src/main/native/include/frc/estimator/SteadyStateKalmanFilter.inc +++ b/wpimath/src/main/native/include/frc/estimator/SteadyStateKalmanFilter.inc @@ -39,8 +39,8 @@ SteadyStateKalmanFilter::SteadyStateKalmanFilter( if (!IsDetectable(discA, C)) { std::string msg = fmt::format( - "The system passed to the Kalman filter is " - "unobservable!\n\nA =\n{}\nC =\n{}\n", + "The system passed to the Kalman filter is undetectable!\n\n" + "A =\n{}\nC =\n{}\n", discA, C); wpi::math::MathSharedStore::ReportError(msg);