"using" directives are no longer used in global namespaces (#219)

simulation/frc_gazebo_plugins/limit_switch/src/external_limit_switch.cpp

@@ -10,8 +10,8 @@
 #include <string>
 
 ExternalLimitSwitch::ExternalLimitSwitch(sdf::ElementPtr sdf) {
-  sensor = std::dynamic_pointer_cast<sensors::ContactSensor>(
-      sensors::get_sensor(sdf->Get<std::string>("sensor")));
+  sensor = std::dynamic_pointer_cast<gazebo::sensors::ContactSensor>(
+      gazebo::sensors::get_sensor(sdf->Get<std::string>("sensor")));
 
   gzmsg << "\texternal limit switch: "
         << " sensor=" << sensor->Name() << std::endl;

simulation/frc_gazebo_plugins/limit_switch/src/external_limit_switch.h

@@ -17,8 +17,6 @@
 #include <Winsock2.h>
 #endif
 
-using namespace gazebo;
-
 class ExternalLimitSwitch : public Switch {
  public:
   explicit ExternalLimitSwitch(sdf::ElementPtr sdf);
@@ -27,5 +25,5 @@ class ExternalLimitSwitch : public Switch {
   virtual bool Get();
 
  private:
-  sensors::ContactSensorPtr sensor;
+  gazebo::sensors::ContactSensorPtr sensor;
 };

simulation/frc_gazebo_plugins/limit_switch/src/internal_limit_switch.cpp

@@ -9,7 +9,7 @@
 
 #include <string>
 
-InternalLimitSwitch::InternalLimitSwitch(physics::ModelPtr model,
+InternalLimitSwitch::InternalLimitSwitch(gazebo::physics::ModelPtr model,
                                          sdf::ElementPtr sdf) {
   joint = model->GetJoint(sdf->Get<std::string>("joint"));
   min = sdf->Get<double>("min");

simulation/frc_gazebo_plugins/limit_switch/src/internal_limit_switch.h

@@ -16,17 +16,15 @@
 #include <Winsock2.h>
 #endif
 
-using namespace gazebo;
-
 class InternalLimitSwitch : public Switch {
  public:
-  InternalLimitSwitch(physics::ModelPtr model, sdf::ElementPtr sdf);
+  InternalLimitSwitch(gazebo::physics::ModelPtr model, sdf::ElementPtr sdf);
 
   /// \brief Returns true when the switch is triggered.
   virtual bool Get();
 
  private:
-  physics::JointPtr joint;
+  gazebo::physics::JointPtr joint;
   double min, max;
   bool radians;
 };

simulation/frc_gazebo_plugins/limit_switch/src/limit_switch.cpp

@@ -11,7 +11,7 @@
 
 GZ_REGISTER_MODEL_PLUGIN(LimitSwitch)
 
-void LimitSwitch::Load(physics::ModelPtr model, sdf::ElementPtr sdf) {
+void LimitSwitch::Load(gazebo::physics::ModelPtr model, sdf::ElementPtr sdf) {
   this->model = model;
 
   // Parse SDF properties
@@ -36,18 +36,18 @@ void LimitSwitch::Load(physics::ModelPtr model, sdf::ElementPtr sdf) {
   std::string scoped_name =
       model->GetWorld()->GetName() + "::" + model->GetScopedName();
   boost::replace_all(scoped_name, "::", "/");
-  node = transport::NodePtr(new transport::Node());
+  node = gazebo::transport::NodePtr(new gazebo::transport::Node());
   node->Init(scoped_name);
-  pub = node->Advertise<msgs::Bool>(topic);
+  pub = node->Advertise<gazebo::msgs::Bool>(topic);
 
   // Connect to the world update event.
   // This will trigger the Update function every Gazebo iteration
-  updateConn = event::Events::ConnectWorldUpdateBegin(
+  updateConn = gazebo::event::Events::ConnectWorldUpdateBegin(
       boost::bind(&LimitSwitch::Update, this, _1));
 }
 
-void LimitSwitch::Update(const common::UpdateInfo& info) {
-  msgs::Bool msg;
+void LimitSwitch::Update(const gazebo::common::UpdateInfo& info) {
+  gazebo::msgs::Bool msg;
   msg.set_data(ls->Get());
   pub->Publish(msg);
 }

simulation/frc_gazebo_plugins/limit_switch/src/limit_switch.h

@@ -18,8 +18,6 @@
 #include "simulation/gz_msgs/msgs.h"
 #include "switch.h"
 
-using namespace gazebo;
-
 /**
  * \brief Plugin for reading limit switches.
  *
@@ -66,13 +64,13 @@ using namespace gazebo;
  * External
  * - `sensor`: Name of the contact sensor that this limit switch uses.
  */
-class LimitSwitch : public ModelPlugin {
+class LimitSwitch : public gazebo::ModelPlugin {
  public:
   /// \brief Load the limit switch and configures it according to the sdf.
-  void Load(physics::ModelPtr model, sdf::ElementPtr sdf);
+  void Load(gazebo::physics::ModelPtr model, sdf::ElementPtr sdf);
 
   /// \brief Sends out the limit switch reading each timestep.
-  void Update(const common::UpdateInfo& info);
+  void Update(const gazebo::common::UpdateInfo& info);
 
  private:
   /// \brief Publish the limit switch value on this topic.
@@ -81,9 +79,15 @@ class LimitSwitch : public ModelPlugin {
   /// \brief LimitSwitch object, currently internal or external.
   Switch* ls;
 
-  physics::ModelPtr model;  ///< \brief The model that this is attached to.
-  event::ConnectionPtr
-      updateConn;           ///< \brief Pointer to the world update function.
-  transport::NodePtr node;  ///< \brief The node we're advertising on.
-  transport::PublisherPtr pub;  ///< \brief Publisher handle.
+  /// \brief The model to which this is attached.
+  gazebo::physics::ModelPtr model;
+
+  /// \brief Pointer to the world update function.
+  gazebo::event::ConnectionPtr updateConn;
+
+  /// \brief The node on which we're advertising.
+  gazebo::transport::NodePtr node;
+
+  /// \brief Publisher handle.
+  gazebo::transport::PublisherPtr pub;
 };